[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#883854: marked as done (stretch-pu: package mate-polkit/1.16.0-2+deb9u1)

Your message dated Sun, 2 Dec 2018 16:48:31 +0100
with message-id <20181202154831.GA20584@tomate.cristau.org>
and subject line Re: Bug#883854: stretch-pu: package mate-polkit/1.16.0-2+deb9u1
has caused the Debian Bug report #883854,
regarding stretch-pu: package mate-polkit/1.16.0-2+deb9u1
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
883854: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=883854
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: release.debian.org
Severity: normal
Tags: stretch
User: release.debian.org@packages.debian.org
Usertags: pu

Whenever mate-polkit asks for the user's password to change the user
context via PolicyKit, an icon is shown in the system tray.

In Debian stretch, this icon is broken. It should show dialog-password.
The attached .debdiff fixes that.

Please consider an ACK to get this change into the next point release of
Debian 9.

Thanks!
Mike

-- System Information:
Debian Release: 9.1
  APT prefers stable
  APT policy: (990, 'stable'), (500, 'stable-updates'), (500, 'stable-debug'), (500, 'proposed-updates-debug')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.9.0-4-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), LANGUAGE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

diff -Nru mate-polkit-1.16.0/debian/changelog mate-polkit-1.16.0/debian/changelog
--- mate-polkit-1.16.0/debian/changelog	2017-01-10 18:37:26.000000000 +0100
+++ mate-polkit-1.16.0/debian/changelog	2017-12-08 12:12:31.000000000 +0100
@@ -1,3 +1,11 @@
+mate-polkit (1.16.0-2+deb9u1) stretch; urgency=medium
+
+  * debian/patches:
+    + Add 0001_status-icon-dont-use-stock-icon.patch. Fix damaged status icon
+      if GtkStatusIcon is used. (Closes: #870318).
+
+ -- Mike Gabriel <sunweaver@debian.org>  Fri, 08 Dec 2017 12:12:31 +0100
+
 mate-polkit (1.16.0-2) unstable; urgency=medium
 
   * debian/control:
diff -Nru mate-polkit-1.16.0/debian/patches/0001_status-icon-dont-use-stock-icon.patch mate-polkit-1.16.0/debian/patches/0001_status-icon-dont-use-stock-icon.patch
--- mate-polkit-1.16.0/debian/patches/0001_status-icon-dont-use-stock-icon.patch	1970-01-01 01:00:00.000000000 +0100
+++ mate-polkit-1.16.0/debian/patches/0001_status-icon-dont-use-stock-icon.patch	2017-12-08 12:12:31.000000000 +0100
@@ -0,0 +1,32 @@
+From 24c247381e1e0fd62159bdcecf89929f2d846492 Mon Sep 17 00:00:00 2001
+From: raveit65 <mate@raveit.de>
+Date: Tue, 9 May 2017 12:42:34 +0200
+Subject: [PATCH] status-icon: don't use stock icons
+
+Fixes damaged status icon if GtkStatusIcon is used.
+---
+ src/main.c | 4 ++--
+ 1 file changed, 2 insertions(+), 2 deletions(-)
+
+diff --git a/src/main.c b/src/main.c
+index 197d29a..f3d5b74 100644
+--- a/src/main.c
++++ b/src/main.c
+@@ -157,7 +157,7 @@ update_temporary_authorization_icon_real (void)
+           GtkWidget *item, *menu;
+ 
+           app_indicator = app_indicator_new ("mate-polkit",
+-                                             "gtk-dialog-authentication",
++                                             "dialog-password",
+                                              APP_INDICATOR_CATEGORY_SYSTEM_SERVICES);
+ 
+           item = gtk_menu_item_new_with_label (_("Drop all elevated privileges"));
+@@ -178,7 +178,7 @@ update_temporary_authorization_icon_real (void)
+ #else
+       if (status_icon == NULL)
+         {
+-          status_icon = gtk_status_icon_new_from_stock (GTK_STOCK_DIALOG_AUTHENTICATION);
++          status_icon = gtk_status_icon_new_from_icon_name ("dialog-password");
+           gtk_status_icon_set_tooltip_text (status_icon,
+                                             _("Click the icon to drop all elevated privileges"));
+           g_signal_connect (status_icon,
diff -Nru mate-polkit-1.16.0/debian/patches/series mate-polkit-1.16.0/debian/patches/series
--- mate-polkit-1.16.0/debian/patches/series	1970-01-01 01:00:00.000000000 +0100
+++ mate-polkit-1.16.0/debian/patches/series	2017-12-08 12:12:31.000000000 +0100
@@ -0,0 +1 @@
+0001_status-icon-dont-use-stock-icon.patch

--- End Message ---
--- Begin Message --- 
On Sat, Jan 13, 2018 at 06:09:43PM +0100, Julien Cristau wrote:
> Control: tag -1 moreinfo
> 
> On Fri, Dec  8, 2017 at 12:17:33 +0100, Mike Gabriel wrote:
> 
> > Whenever mate-polkit asks for the user's password to change the user
> > context via PolicyKit, an icon is shown in the system tray.
> > 
> > In Debian stretch, this icon is broken. It should show dialog-password.
> > The attached .debdiff fixes that.
> > 
> > Please consider an ACK to get this change into the next point release of
> > Debian 9.
> > 
> The bug severity is "minor".  I'm not convinced that qualifies.
> 
Doesn't look like anyone feels strongly otherwise, so closing.

Cheers,
Julien

--- End Message ---
Reply to: