[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#894027: marked as done (stretch-pu: package addresses-for-gnustep/0.4.8-2+deb9u1)

Your message dated Mon, 3 Dec 2018 08:16:29 +0100
with message-id <20181203071629.GM28494@tomate.cristau.org>
and subject line Re: Bug#894027: stretch-pu: package addresses-for-gnustep/0.4.8-2+deb9u1
has caused the Debian Bug report #894027,
regarding stretch-pu: package addresses-for-gnustep/0.4.8-2+deb9u1
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
894027: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=894027
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: release.debian.org
Severity: normal
Tags: stretch
User: release.debian.org@packages.debian.org
Usertags: pu

If possible, I would like to fix #889534 and #889536 (missing
dependencies).  Debdiff against the package version in stable
attached.  Thanks.

-- System Information:
Debian Release: 9.4
  APT prefers stable-updates
  APT policy: (500, 'stable-updates'), (500, 'stable-debug'), (500, 'stable')
Architecture: i386 (i686)

Kernel: Linux 4.9.0-6-686-pae (SMP w/1 CPU core)
Locale: LANG=bg_BG.UTF-8, LC_CTYPE=bg_BG.UTF-8 (charmap=UTF-8), LANGUAGE=bg_BG.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

diff -Nru addresses-for-gnustep-0.4.8/debian/changelog addresses-for-gnustep-0.4.8/debian/changelog
--- addresses-for-gnustep-0.4.8/debian/changelog	2015-11-17 01:16:26.000000000 +0200
+++ addresses-for-gnustep-0.4.8/debian/changelog	2018-03-25 16:17:58.000000000 +0300
@@ -1,3 +1,12 @@
+addresses-for-gnustep (0.4.8-2+deb9u1) stretch; urgency=medium
+
+  * Team upload.
+  * debian/patches/link-libs.patch: New, link against all needed libraries
+    (Closes: #889534, #889536).
+  * debian/patches/series: Update.
+
+ -- Yavor Doganov <yavor@gnu.org>  Sun, 25 Mar 2018 16:17:58 +0300
+
 addresses-for-gnustep (0.4.8-2) unstable; urgency=medium
 
   * Fix danggling symlinks in libaddressview-dev and libaddresses-dev
diff -Nru addresses-for-gnustep-0.4.8/debian/patches/link-libs.patch addresses-for-gnustep-0.4.8/debian/patches/link-libs.patch
--- addresses-for-gnustep-0.4.8/debian/patches/link-libs.patch	1970-01-01 02:00:00.000000000 +0200
+++ addresses-for-gnustep-0.4.8/debian/patches/link-libs.patch	2018-03-25 16:17:58.000000000 +0300
@@ -0,0 +1,28 @@
+Description: Link against needed libraries.
+ Avoid linking the Addresses framework with GNUstep GUI.
+Bug-Debian: https://bugs.debian.org/889534
+Bug-Debian: https://bugs.debian.org/889536
+Origin: upstream, commit:r3597
+Last-Update: 2018-03-05
+---
+
+--- gnustep-addresses.orig/Frameworks/AddressView/GNUmakefile
++++ gnustep-addresses/Frameworks/AddressView/GNUmakefile
+@@ -36,4 +36,4 @@
+ -include GNUmakefile.postamble
+ 
+ ADDITIONAL_LIB_DIRS += -L../Addresses/Addresses.framework 
+-ADDITIONAL_GUI_LIBS = -lAddresses
+\ No newline at end of file
++LIBRARIES_DEPEND_UPON = -lAddresses $(GUI_LIBS) $(FND_LIBS) $(OBJC_LIBS) $(SYSTEM_LIBS)
+--- gnustep-addresses.orig/Frameworks/Addresses/GNUmakefile
++++ gnustep-addresses/Frameworks/Addresses/GNUmakefile
+@@ -42,6 +42,8 @@
+ Addresses_LOCALIZED_RESOURCE_FILES=PropertiesAndLabels.strings
+ Addresses_LANGUAGES=Dutch English French German Spanish
+ 
++LIBRARIES_DEPEND_UPON = $(FND_LIBS) $(OBJC_LIBS) $(SYSTEM_LIBS)
++
+ -include GNUmakefile.preamble
+ -include GNUmakefile.local
+ include $(GNUSTEP_MAKEFILES)/framework.make
diff -Nru addresses-for-gnustep-0.4.8/debian/patches/series addresses-for-gnustep-0.4.8/debian/patches/series
--- addresses-for-gnustep-0.4.8/debian/patches/series	2015-11-05 21:05:21.000000000 +0200
+++ addresses-for-gnustep-0.4.8/debian/patches/series	2018-03-25 16:17:58.000000000 +0300
@@ -1 +1,2 @@
+link-libs.patch
 fix-adserver-format.patch

--- End Message ---
--- Begin Message --- 
On Mon, Apr 02, 2018 at 01:32:57PM +0300, Yavor Doganov wrote:
> Julien Cristau wrote:
> > On Sun, Mar 25, 2018 at 17:00:43 +0300, Yavor Doganov wrote:
> > > If possible, I would like to fix #889534 and #889536 (missing
> > > dependencies).
> 
> > What does this translate to in terms of changes to binary packages?
> 
> Needed libraries added to Depends:, here are the binary debdiffs:
> 
[...]

Thanks!

> 
> > Is this an issue for users in practice, or mainly a
> > theoretical/correctness issue?
> 
> I would say it's the latter.  Any program linking against libaddresses
> or libaddressview presumably already links with gnustep-base/gui and
> the Objective-C runtime.  There are cases when the dynamic linker
> loads the libraries in the wrong order which may lead to runtime
> failure if loadable modules (bundles) are not linked properly.  But I
> haven't seen this in practice and I'd say it's unlikely to occur on
> modern systems.

OK.  In that case let's not worry about updating stable for it.

Cheers,
Julien

--- End Message ---
Reply to: