Bug#912629: stretch-pu: package espeakup/1:0.80-5+deb9u2

[Samuel Thibault <sthibault@debian.org>]

Package: release.debian.org
Severity: normal
Tags: stretch a11y
User: release.debian.org@packages.debian.org
Usertags: pu

Hello,

We would like to upload the attached change to espeakup in Stretch.

The story is that the init.d script for espeakup used to avoid starting
espeakup if the kernel speakup_soft module is not loaded. When a systemd
service was introduced during for Stretch, that part was not ported
(making a service automatically disabled when a kernel module is not
loaded does not seem to be implemented in systemd), which means that
when installing the espeakup package on a system which doesn't have
speakup_soft loaded, the service start fails, and thus the package
fails to configure. We do not really want to make the espeakup daemon
itself stop reporting an error in such case, and it seems that users'
preference is that the espeakup service just loads the require module
itself anyway, which is what is implemented in the attached changes and
has been used in sid for a week then in testing for a week.

Samuel

-- System Information:
Debian Release: buster/sid
  APT prefers unstable-debug
  APT policy: (500, 'unstable-debug'), (500, 'testing-debug'), (500, 'stable-debug'), (500, 'proposed-updates-debug'), (500, 'proposed-updates'), (500, 'oldoldstable'), (500, 'buildd-unstable'), (500, 'unstable'), (500, 'testing'), (500, 'stable'), (500, 'oldstable'), (1, 'experimental-debug'), (1, 'buildd-experimental'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.19.0 (SMP w/8 CPU cores)
Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8), LANGUAGE=fr_FR.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

-- 
Samuel
"...Deep Hack Mode--that mysterious and frightening state of
consciousness where Mortal Users fear to tread."
(By Matt Welsh)

diff -Nru espeakup-0.80/debian/changelog espeakup-0.80/debian/changelog
--- espeakup-0.80/debian/changelog	2017-12-17 16:35:19.000000000 +0100
+++ espeakup-0.80/debian/changelog	2018-11-02 00:39:25.000000000 +0100
@@ -1,3 +1,10 @@
+espeakup (1:0.80-5+deb9u2) stretch; urgency=medium
+
+  * debian/espeakup.service: Automatically load speakup_soft on daemon
+    startup.
+
+ -- Samuel Thibault <sthibault@debian.org>  Fri, 02 Nov 2018 00:39:25 +0100
+
 espeakup (1:0.80-5+deb9u1) stretch; urgency=medium
 
   * debian/espeakup-udeb.start: Fix case where card 0 does not have an id or
diff -Nru espeakup-0.80/debian/espeakup.service espeakup-0.80/debian/espeakup.service
--- espeakup-0.80/debian/espeakup.service	2017-12-17 16:35:19.000000000 +0100
+++ espeakup-0.80/debian/espeakup.service	2018-11-02 00:38:55.000000000 +0100
@@ -9,7 +9,7 @@
 PIDFile=/run/espeakup.pid
 Environment="VOICE= ALSA_CARD="
 EnvironmentFile=-/etc/default/espeakup
-ExecStart=/usr/bin/espeakup -V ${VOICE}
+ExecStart=sh -c 'modprobe speakup_soft && /usr/bin/espeakup -V ${VOICE}'
 ExecReload=/bin/kill -HUP $MAINPID
 Restart=always