[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#808319: marked as done (britney: Allow skipping the second (upgrade testing) stage)

Your message dated Sun, 29 Jul 2018 15:55:00 +0000
with message-id <30776098-2a8c-1d59-6cc4-b3011465aa0a@thykier.net>
and subject line Re: Bug#808319: britney: Allow skipping the second (upgrade testing) stage
has caused the Debian Bug report #808319,
regarding britney: Allow skipping the second (upgrade testing) stage
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
808319: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=808319
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: release.debian.org
Severity: normal
Tags: patch
User: release.debian.org@packages.debian.org
Usertags: britney

Hello,

It's sometimes useful to run britney in "dry mode" to run tests on the
unstable packages, but not the full second-stage upgrade test. This is
even more useful if/once britney can trigger and evaluate
autopkgtests, but even the current Debian ones are interesting.

Support this by skipping the upgrade test instead of crashing if the
UPGRADE_OUTPUT option in britney.conf is empty or absent.

Thanks for considering,

Martin

-- 
Martin Pitt                        | http://www.piware.de
Ubuntu Developer (www.ubuntu.com)  | Debian Developer  (www.debian.org)

From 95d3c01daa2f8ee2dd6daeecfbb652ad3fdac0d9 Mon Sep 17 00:00:00 2001
From: Martin Pitt <martin.pitt@ubuntu.com>
Date: Fri, 18 Dec 2015 16:51:06 +0100
Subject: [PATCH] Skip upgrade testing if UPGRADE_OUTPUT option is absent or
 empty

It's sometimes useful to run britney in "dry mode" to run tests on the unstable
packages, but not the full second-stage upgrade test.

Support this by skipping the upgrade test instead of crashing if the
UPGRADE_OUTPUT option is empty or absent.
---
 britney.py | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/britney.py b/britney.py
index 86158fe..cec4ee0 100755
--- a/britney.py
+++ b/britney.py
@@ -2891,6 +2891,13 @@ class Britney(object):
         else:
             self.upgrade_me = self.options.actions.split()
 
+        # skip upgrade testing if UPGRADE_OUTPUT option is absent or empty
+        try:
+            if not self.options.upgrade_output:
+                return
+        except AttributeError:
+            return
+
         with open(self.options.upgrade_output, 'w', encoding='utf-8') as f:
             self.__output = f
 
-- 
2.6.4

Attachment: signature.asc
Description: Digital signature


--- End Message ---
--- Begin Message --- 
On Fri, 18 Dec 2015 18:49:03 +0000 Niels Thykier <niels@thykier.net> wrote:
> Control: tags -1 moreinfo
> 
> Martin Pitt:
> > Package: release.debian.org
> > Severity: normal
> > Tags: patch
> > User: release.debian.org@packages.debian.org
> > Usertags: britney
> > 
> > Hello,
> > 
> > It's sometimes useful to run britney in "dry mode" to run tests on the
> > unstable packages, but not the full second-stage upgrade test. This is
> > even more useful if/once britney can trigger and evaluate
> > autopkgtests, but even the current Debian ones are interesting.
> > 
> > Support this by skipping the upgrade test instead of crashing if the
> > UPGRADE_OUTPUT option in britney.conf is empty or absent.
> > 
> > Thanks for considering,
> > 
> > Martin
> > 
> 
> Hi Martin,
> 
> Thanks for the patch and the interest in improving Britney.
> 
> I appreciate the idea, though I think we would be better served with a
> different implementation.  For example using a command-line option, so
> we do not need a separate config file for using such a feature.
> 
> Thanks,
> ~Niels
> 
> 
> 
> 

This is now supported via the cmd options --compute-migrations vs.
--no-compute-migrations.

Thanks,
~Niels

--- End Message ---
Reply to: