[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#875604: marked as done (stretch-pu: package asterisk/1:13.14.1~dfsg-2+deb9u2)



Your message dated Wed, 4 Oct 2017 15:00:21 +0200
with message-id <4b10784e-bd3f-a379-3d97-7e99c8713272@debian.org>
and subject line Re: Bug#875604: Acknowledgement (stretch-pu: package asterisk/1:13.14.1~dfsg-2+deb9u2)
has caused the Debian Bug report #875604,
regarding stretch-pu: package asterisk/1:13.14.1~dfsg-2+deb9u2
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
875604: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=875604
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message ---
Package: release.debian.org
Severity: normal
Tags: stretch
User: release.debian.org@packages.debian.org
Usertags: pu

Hi,

I'd like to upload the attached update to stretch fixing a bug with
transcoding in the deprecated, but still widely used chan_sip channel driver.

The fix is a cherry-picked upstream commit, already in sid and buster.
The reporter has verified that this commit fixes his issue.

debdiff against the security release is attached.

Best Regards,
Bernhard
diff -Nru asterisk-13.14.1~dfsg/debian/changelog asterisk-13.14.1~dfsg/debian/changelog
--- asterisk-13.14.1~dfsg/debian/changelog	2017-09-02 23:21:14.000000000 +0200
+++ asterisk-13.14.1~dfsg/debian/changelog	2017-09-12 13:09:19.000000000 +0200
@@ -1,3 +1,9 @@
+asterisk (1:13.14.1~dfsg-2+deb9u2) stretch; urgency=medium
+
+  * Fix one-way audio with chan_sip when transcoding (Closes: #875450)
+
+ -- Bernhard Schmidt <berni@debian.org>  Tue, 12 Sep 2017 13:09:19 +0200
+
 asterisk (1:13.14.1~dfsg-2+deb9u1) stretch-security; urgency=high
 
   * CVE-2017-14099 / AST-2017-005
diff -Nru asterisk-13.14.1~dfsg/debian/patches/875450-chan_sip-oneway-audio.patch asterisk-13.14.1~dfsg/debian/patches/875450-chan_sip-oneway-audio.patch
--- asterisk-13.14.1~dfsg/debian/patches/875450-chan_sip-oneway-audio.patch	1970-01-01 01:00:00.000000000 +0100
+++ asterisk-13.14.1~dfsg/debian/patches/875450-chan_sip-oneway-audio.patch	2017-09-12 13:09:19.000000000 +0200
@@ -0,0 +1,33 @@
+From: Vitezslav Novy <a1@vnovy.net>
+Date: Mon, 8 May 2017 20:40:47 +0200
+Subject: [PATCH] chan_sip: Change sip_get_codec() to return correct codec list
+Origin: upstream, https://github.com/asterisk/asterisk/commit/93b7f84c1ac61208607ec6f7360b594dee921a1b
+Bug: https://issues.asterisk.org/jira/browse/ASTERISK-26143
+Bug-Debian: https://bugs.debian.org/875450
+
+Return cahnnel nativeformats to fix bridge technology selection process.
+Same approach as in pjsip module.
+
+ASTERISK-26143
+Reported-by: Henning Holtschneider
+
+Change-Id: I64e863753954d6ad67a9e722df2ebc328705ad48
+---
+ channels/chan_sip.c | 4 +---
+ 1 file changed, 1 insertion(+), 3 deletions(-)
+
+diff --git a/channels/chan_sip.c b/channels/chan_sip.c
+index e7c15bcbd0c..930dc0f6756 100644
+--- a/channels/chan_sip.c
++++ b/channels/chan_sip.c
+@@ -33588,9 +33588,7 @@ static int sip_set_rtp_peer(struct ast_channel *chan, struct ast_rtp_instance *i
+ 
+ static void sip_get_codec(struct ast_channel *chan, struct ast_format_cap *result)
+ {
+-	struct sip_pvt *p = ast_channel_tech_pvt(chan);
+-
+-	ast_format_cap_append_from_cap(result, !ast_format_cap_count(p->peercaps) ? p->caps : p->peercaps, AST_MEDIA_TYPE_UNKNOWN);
++	ast_format_cap_append_from_cap(result, ast_channel_nativeformats(chan), AST_MEDIA_TYPE_UNKNOWN);
+ }
+ 
+ static struct ast_rtp_glue sip_rtp_glue = {
diff -Nru asterisk-13.14.1~dfsg/debian/patches/series asterisk-13.14.1~dfsg/debian/patches/series
--- asterisk-13.14.1~dfsg/debian/patches/series	2017-09-02 23:21:14.000000000 +0200
+++ asterisk-13.14.1~dfsg/debian/patches/series	2017-09-12 13:09:19.000000000 +0200
@@ -43,6 +43,9 @@
 859911-pjsip-set-rtp-source-address.patch
 859911-pjsip-set-rtp-source-address-part2.patch
 
+# Bug#875450 - chan_sip: One way audio when transcoding
+875450-chan_sip-oneway-audio.patch
+
 AST-2017-004.patch
 AST-2017-005-13.13.diff
 AST-2017-006-13.diff

--- End Message ---
--- Begin Message ---
Hi,
> Control: tags -1 + confirmed
> 
> On Sat, 2017-09-23 at 18:33 +0200, Bernhard Schmidt wrote:
>> Hi,
>>
>> Sorry to bug you again, but I would like to include this fix in an
>> upcoming security upload for asterisk. Would it be possible to
>> approve this asap, as I'm going on vacation tomorrow?
>>
> 
> Please feel free to upload.

Thanks a lot for your quick response.

The patch has been included in the last security upload
(1:13.14.1~dfsg-2+deb9u2), I'm closing this pu-request.

Bernhard

--- End Message ---

Reply to: