[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#847921: marked as done (jessie-pu: package libmateweather/1.8.0-2+deb8u1)

Your message dated Sat, 14 Jan 2017 12:37:03 +0000
with message-id <1484397423.1091.25.camel@adam-barratt.org.uk>
and subject line Closing requests included in today's point release
has caused the Debian Bug report #847921,
regarding jessie-pu: package libmateweather/1.8.0-2+deb8u1
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
847921: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=847921
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: release.debian.org
Severity: normal
Tags: jessie
User: release.debian.org@packages.debian.org
Usertags: pu


The weather data provider service weather.noaa.gov is a discontinued service. This update
switches libmateweather over to using aviationweather.gov. In Debian jessie, this fixes
the MATE weather report applet. Currently, the applet displays no data at all.

light+love,
Mike

-- System Information:
Debian Release: 8.6
  APT prefers stable
  APT policy: (990, 'stable'), (500, 'stable-updates'), (500, 'proposed-updates')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.7.0-0.bpo.1-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

diff -Nru libmateweather-1.8.0/debian/changelog libmateweather-1.8.0/debian/changelog
--- libmateweather-1.8.0/debian/changelog	2014-04-30 15:41:08.000000000 +0200
+++ libmateweather-1.8.0/debian/changelog	2016-12-12 12:22:55.000000000 +0100
@@ -1,3 +1,13 @@
+libmateweather (1.8.0-2+deb8u1) jessie-proposed-updates; urgency=medium
+
+  * debian/patches:
+    + Add 0001_metar-switch-to-aviationweather-gov.patch. The site
+      weather.noaa.gov is discontinued. (Closes: #846900).
+  * debian/copyright:
+    + Add missing Comment: field names.
+
+ -- Mike Gabriel <sunweaver@debian.org>  Mon, 12 Dec 2016 11:04:45 +0100
+
 libmateweather (1.8.0-2) unstable; urgency=low
 
   * debian/control:
diff -Nru libmateweather-1.8.0/debian/copyright libmateweather-1.8.0/debian/copyright
--- libmateweather-1.8.0/debian/copyright	2014-03-13 16:16:47.000000000 +0100
+++ libmateweather-1.8.0/debian/copyright	2016-12-12 11:25:48.000000000 +0100
@@ -57,6 +57,7 @@
            1999-2004, Siarhiej V. Udalcoŭ
            THE PACKAGE'S COPYRIGHT HOLDER
 License: GPL-2+ or LGPL-2.1+
+Comment:
  Apply appropriate license as either found in COPYING
  file or in COPYING.GPL file.
 
@@ -77,6 +78,7 @@
            2010, Rosetta Contributors and Canonical Ltd.
            THE PACKAGE'S COPYRIGHT HOLDER
 License: GPL-2+ or LGPL-2.1+
+Comment:
  Apply appropriate license as either found in COPYING
  file or in COPYING.GPL file.
 
@@ -109,6 +111,7 @@
        configure.ac
 Copyright: *No copyright*
 License: GPL-2+ or LGPL-2.1+
+Comment:
  Apply appropriate license as either found in COPYING
  file or in COPYING.GPL file.
 
diff -Nru libmateweather-1.8.0/debian/patches/0001_metar-switch-to-aviationweather-gov.patch libmateweather-1.8.0/debian/patches/0001_metar-switch-to-aviationweather-gov.patch
--- libmateweather-1.8.0/debian/patches/0001_metar-switch-to-aviationweather-gov.patch	1970-01-01 01:00:00.000000000 +0100
+++ libmateweather-1.8.0/debian/patches/0001_metar-switch-to-aviationweather-gov.patch	2016-12-12 11:16:29.000000000 +0100
@@ -0,0 +1,53 @@
+Author: monsta <monsta@inbox.ru>
+Description: metar: switch to aviationweather.gov (weather.noaa.gov is discontinued)
+
+--- a/libmateweather/weather-iwin.c
++++ b/libmateweather/weather-iwin.c
+@@ -462,7 +462,7 @@
+     zone = g_ascii_strdown (loc->zone, -1);
+     state = g_strndup (zone, 2);
+ 
+-    url = g_strdup_printf ("http://weather.noaa.gov/pub/data/forecasts/zone/%s/%s.txt";, state, zone);
++    url = g_strdup_printf ("http://tgftp.nws.noaa.gov/data/forecasts/zone/%s/%s.txt";, state, zone);
+ 
+     g_free (zone);
+     g_free (state);
+--- a/libmateweather/weather-metar.c
++++ b/libmateweather/weather-metar.c
+@@ -510,7 +510,7 @@
+ 
+     loc = info->location;
+ 
+-    searchkey = g_strdup_printf ("\n%s", loc->code);
++    searchkey = g_strdup_printf ("<raw_text>%s", loc->code);
+     p = strstr (msg->response_body->data, searchkey);
+     g_free (searchkey);
+     if (p) {
+@@ -522,8 +522,8 @@
+ 	    metar = g_strdup (p);
+ 	success = metar_parse (metar, info);
+ 	g_free (metar);
+-    } else if (!strstr (msg->response_body->data, "National Weather Service")) {
+-	/* The response doesn't even seem to have come from NWS...
++    } else if (!strstr (msg->response_body->data, "aviationweather.gov")) {
++	/* The response doesn't even seem to have come from NOAA...
+ 	 * most likely it is a wifi hotspot login page. Call that a
+ 	 * network error.
+ 	 */
+@@ -550,8 +550,14 @@
+     }
+ 
+     msg = soup_form_request_new (
+-	"GET", "http://weather.noaa.gov/mgetmetar.php";,
+-	"cccc", loc->code,
++	"GET", "https://www.aviationweather.gov/adds/dataserver_current/httpparam";,
++	"dataSource", "metars",
++	"requestType", "retrieve",
++	"format", "xml",
++	"hoursBeforeNow", "3",
++	"mostRecent", "true",
++	"fields", "raw_text",
++	"stationString", loc->code,
+ 	NULL);
+     soup_session_queue_message (info->session, msg, metar_finish, info);
+ 
diff -Nru libmateweather-1.8.0/debian/patches/series libmateweather-1.8.0/debian/patches/series
--- libmateweather-1.8.0/debian/patches/series	1970-01-01 01:00:00.000000000 +0100
+++ libmateweather-1.8.0/debian/patches/series	2016-12-12 11:02:00.000000000 +0100
@@ -0,0 +1 @@
+0001_metar-switch-to-aviationweather-gov.patch

--- End Message ---
--- Begin Message --- 
Version: 8.7

Hi,

Each of these bugs refers to an update that was included in today's 8.7
point release.

Regards,

Adam

--- End Message ---
Reply to: