Bug#847273: jessie-pu: package mapserver/6.4.1-5

["Adam D. Barratt" <adam@adam-barratt.org.uk>]

On Fri, 2017-01-06 at 23:23 +0000, Adam D. Barratt wrote:
> Control: tags -1 + pending
> 
> On Thu, 2017-01-05 at 21:27 +0100, Sebastiaan Couwenberg wrote:
> > On 01/05/2017 09:04 PM, Adam D. Barratt wrote:
> > > On Tue, 2016-12-06 at 22:00 +0100, Sebastiaan Couwenberg wrote:
> > >> Sorry for the outdated debdiff, for p-u the distribution has been
> > >> changed to stable.
> > > 
> > > Please go ahead.
> > 
> > Thanks!
> 
> Flagged for acceptance.

The upload subsequently FTBFS on all architectures on the buildds.

The relevant portion of the logs appears to be:

<quote>
/«PKGBUILDDIR»/mapscript/php/error.c:58:21: note: in expansion of macro 'php_error'
   php_error_object *php_error;
                     ^
In file included from /usr/include/php5/main/php.h:40:0,
                 from /«PKGBUILDDIR»/mapscript/php/php_mapscript.h:35,
                 from /«PKGBUILDDIR»/mapscript/php/error.c:32:
/usr/include/php5/Zend/zend_API.h:583:4: error: called object 'zend_error' is not a function or function pointer
    zend_error(E_ERROR, "String size overflow"); \
    ^
/usr/include/php5/Zend/zend_API.h:627:39: note: in expansion of macro 'ZVAL_STRING'
 #define RETVAL_STRING(s, duplicate)   ZVAL_STRING(return_value, s, duplicate)
                                       ^
/«PKGBUILDDIR»/mapscript/php/php_mapscript_util.h:186:9: note: in expansion of macro 'RETVAL_STRING'
         RETVAL_STRING( (value ? value:"") , 1);    \
         ^
/«PKGBUILDDIR»/mapscript/php/error.c:72:10: note: in expansion of macro 'IF_GET_STRING'
     else IF_GET_STRING("message", php_error->error->message)
          ^
In file included from /«PKGBUILDDIR»/mapscript/php/php_mapscript.h:35:0,
                 from /«PKGBUILDDIR»/mapscript/php/error.c:32:
/usr/include/php5/main/php.h:293:19: note: declared here
 #define php_error zend_error
                   ^
/«PKGBUILDDIR»/mapscript/php/error.c:58:21: note: in expansion of macro 'php_error'
   php_error_object *php_error;
                     ^
/«PKGBUILDDIR»/mapscript/php/error.c: In function 'zim_errorObj___set':
/usr/include/php5/main/php.h:293:19: warning: variable 'zend_error' set but not used [-Wunused-but-set-variable]
 #define php_error zend_error
                   ^
/«PKGBUILDDIR»/mapscript/php/error.c:85:21: note: in expansion of macro 'php_error'
   php_error_object *php_error;
                     ^
mapscript/php/CMakeFiles/php_mapscript.dir/build.make:195: recipe for target 'mapscript/php/CMakeFiles/php_mapscript.dir/error.c.o' failed
make[4]: *** [mapscript/php/CMakeFiles/php_mapscript.dir/error.c.o] Error 1
</quote>

I'm not entirely sure how you managed to build the amd64 packages
without this issue occurring, but please look into this ASAP. As things
stand, we won't be including mapserver in 8.7.

Regards,

Adam