Your message dated Sat, 09 Dec 2017 10:47:53 +0000 with message-id <1512816473.1994.32.camel@adam-barratt.org.uk> and subject line Closing bugs for updates included in jessie point release has caused the Debian Bug report #852958, regarding jessie-pu: package libxtst/2:1.2.2-1+deb8u1 to be marked as done. This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact owner@bugs.debian.org immediately.) -- 852958: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=852958 Debian Bug Tracking System Contact owner@bugs.debian.org with problems
--- Begin Message ---
- To: Debian Bug Tracking System <submit@bugs.debian.org>
- Subject: jessie-pu: package libxtst/2:1.2.2-1+deb8u1
- From: Julien Cristau <jcristau@debian.org>
- Date: Sat, 28 Jan 2017 15:55:44 +0100
- Message-id: <20170128145544.bnla7f5ud6iitted@betterave.cristau.org>
Package: release.debian.org Severity: normal Tags: jessie User: release.debian.org@packages.debian.org Usertags: pu And another one. Cheers, Julien diff -u libxtst-1.2.2/debian/changelog libxtst-1.2.2/debian/changelog --- libxtst-1.2.2/debian/changelog +++ libxtst-1.2.2/debian/changelog @@ -1,3 +1,11 @@ +libxtst (2:1.2.2-1+deb8u1) jessie; urgency=medium + + * Insufficient validation of data from the X server can cause out of + boundary memory access or endless loops. Addresses CVE-2016-7951 and + CVE-2016-7952. + + -- Julien Cristau <jcristau@debian.org> Sat, 28 Jan 2017 15:53:24 +0100 + libxtst (2:1.2.2-1) unstable; urgency=low * New upstream release. only in patch2: unchanged: --- libxtst-1.2.2.orig/src/XRecord.c +++ libxtst-1.2.2/src/XRecord.c @@ -760,15 +760,23 @@ switch (rep->category) { case XRecordFromServer: if (rep->elementHeader&XRecordFromServerTime) { + if (current_index + 4 > rep->length << 2) + return Error; EXTRACT_CARD32(rep->clientSwapped, reply->buf+current_index, data->server_time); current_index += 4; } + if (current_index + 1 > rep->length << 2) + return Error; switch (reply->buf[current_index]) { case X_Reply: /* reply */ + if (current_index + 8 > rep->length << 2) + return Error; EXTRACT_CARD32(rep->clientSwapped, reply->buf+current_index+4, datum_bytes); + if (datum_bytes < 0 || datum_bytes > ((INT_MAX >> 2) - 8)) + return Error; datum_bytes = (datum_bytes+8) << 2; break; default: /* error or event */ @@ -777,52 +785,73 @@ break; case XRecordFromClient: if (rep->elementHeader&XRecordFromClientTime) { + if (current_index + 4 > rep->length << 2) + return Error; EXTRACT_CARD32(rep->clientSwapped, reply->buf+current_index, data->server_time); current_index += 4; } if (rep->elementHeader&XRecordFromClientSequence) { + if (current_index + 4 > rep->length << 2) + return Error; EXTRACT_CARD32(rep->clientSwapped, reply->buf+current_index, data->client_seq); current_index += 4; } + if (current_index + 4 > rep->length<<2) + return Error; if (reply->buf[current_index+2] == 0 && reply->buf[current_index+3] == 0) /* needn't swap 0 */ { /* BIG-REQUESTS */ + if (current_index + 8 > rep->length << 2) + return Error; EXTRACT_CARD32(rep->clientSwapped, reply->buf+current_index+4, datum_bytes); } else { EXTRACT_CARD16(rep->clientSwapped, reply->buf+current_index+2, datum_bytes); } + if (datum_bytes < 0 || datum_bytes > INT_MAX >> 2) + return Error; datum_bytes <<= 2; break; case XRecordClientStarted: + if (current_index + 8 > rep->length << 2) + return Error; EXTRACT_CARD16(rep->clientSwapped, reply->buf+current_index+6, datum_bytes); datum_bytes = (datum_bytes+2) << 2; break; case XRecordClientDied: if (rep->elementHeader&XRecordFromClientSequence) { + if (current_index + 4 > rep->length << 2) + return Error; EXTRACT_CARD32(rep->clientSwapped, reply->buf+current_index, data->client_seq); current_index += 4; - } - /* fall through */ + } else if (current_index < rep->length << 2) + return Error; + datum_bytes = 0; + break; case XRecordStartOfData: case XRecordEndOfData: + if (current_index < rep->length << 2) + return Error; datum_bytes = 0; + break; } if (datum_bytes > 0) { - if (current_index + datum_bytes > rep->length << 2) + if (INT_MAX - datum_bytes < (rep->length << 2) - current_index) { fprintf(stderr, "XRecord: %lu-byte reply claims %d-byte element (seq %lu)\n", - (long)rep->length << 2, current_index + datum_bytes, + (unsigned long)rep->length << 2, current_index + datum_bytes, dpy->last_request_read); + return Error; + } /* * This assignment (and indeed the whole buffer sharing * scheme) assumes arbitrary 4-byte boundaries are @@ -872,6 +901,12 @@ UnlockDisplay(dpy); SyncHandle(); return 0; + } + + if (rep.length > INT_MAX >> 2) { + UnlockDisplay(dpy); + SyncHandle(); + return 0; } if (rep.length > 0) {Attachment: signature.asc
Description: PGP signature
--- End Message ---
--- Begin Message ---
- To: 815728-done@bugs.debian.org, 840643-done@bugs.debian.org, 852849-done@bugs.debian.org, 852947-done@bugs.debian.org, 852949-done@bugs.debian.org, 852952-done@bugs.debian.org, 852958-done@bugs.debian.org, 852961-done@bugs.debian.org, 852965-done@bugs.debian.org, 852966-done@bugs.debian.org, 856240-done@bugs.debian.org, 861541-done@bugs.debian.org, 862363-done@bugs.debian.org, 862961-done@bugs.debian.org, 863093-done@bugs.debian.org, 867817-done@bugs.debian.org, 868337-done@bugs.debian.org, 869991-done@bugs.debian.org, 870178-done@bugs.debian.org, 870376-done@bugs.debian.org, 872056-done@bugs.debian.org, 872442-done@bugs.debian.org, 873053-done@bugs.debian.org, 873310-done@bugs.debian.org, 873466-done@bugs.debian.org, 873481-done@bugs.debian.org, 873877-done@bugs.debian.org, 876019-done@bugs.debian.org, 876313-done@bugs.debian.org, 876630-done@bugs.debian.org, 876638-done@bugs.debian.org, 877045-done@bugs.debian.org, 879630-done@bugs.debian.org, 880123-done@bugs.debian.org, 880630-done@bugs.debian.org, 880861-done@bugs.debian.org, 880895-done@bugs.debian.org, 881306-done@bugs.debian.org, 882061-done@bugs.debian.org, 882132-done@bugs.debian.org, 882242-done@bugs.debian.org, 882503-done@bugs.debian.org, 882802-done@bugs.debian.org, 882960-done@bugs.debian.org, 882961-done@bugs.debian.org, 883177-done@bugs.debian.org, 883292-done@bugs.debian.org
- Subject: Closing bugs for updates included in jessie point release
- From: "Adam D. Barratt" <adam@adam-barratt.org.uk>
- Date: Sat, 09 Dec 2017 10:47:53 +0000
- Message-id: <1512816473.1994.32.camel@adam-barratt.org.uk>
Version: 8.10 Hi, Each of the updates referenced in these bugs was included in this morning's jessie point release. Thanks! Regards, Adam
--- End Message ---