Control: tag -1 moreinfo
Hi,
Santiago Garcia Mantinan <manty@debian.org> (2017-06-27):
> When updating a production machine to Stretch I found that the check
> for vlan interfaces was wrong and thus some of the vlans were not
> being created.
>
> I have worked on a fix for this which is on -14 version of the
> package, I have uploaded that already to unstable, but I'd like this
> to be parth of the next point release, here is the diff for the fix:
>
> --- bridge-utils.sh-1.5-13 2017-06-26 23:42:52.791730487 +0200
> +++ bridge-utils.sh-1.5-14 2017-06-26 23:42:10.215270353 +0200
> @@ -58,11 +58,11 @@
> create_vlan_port()
> {
> # port doesn't yet exist
> -if ! grep -q "$port" /proc/net/dev
> +if ! grep -q "$port:" /proc/net/dev
> then
> dev="${port%.*}"
> # port is a vlan and the device exists?
> - if [ "$port" != "$dev" ] && grep -q "$dev" /proc/net/dev
> + if [ "$port" != "$dev" ] && grep -q "$dev:" /proc/net/dev
> then
> if [ -f /proc/sys/net/ipv6/conf/$dev/disable_ipv6 ]
> then
> @@ -77,7 +77,7 @@
> destroy_vlan_port()
> {
> # port exists
> -if grep -q "$port" /proc/net/dev
> +if grep -q "$port:" /proc/net/dev
> then
> dev="${port%.*}"
> # port is a vlan
>
> I hope we can get this into the next stable release.
Ah, it's a bit unfortunate that we don't have a bug report for the issue
you're fixing, but that's obviously fixed in unstable by now… Also, you
attached a kind of patch which doesn't even mention which file is being
patched (debian/bridge-utils.sh), and we really prefer seeing a full
source debdiff from the version in stable.
Please send one with the 1.5-13+deb9u1 version number, targetting the
stretch distribution.
Feel free to confirm, but: AFAIU the patch, the idea is to be stricter
by making sure one no longer matches the interface (e.g. eth0) when
searching for a vlan (e.g. vlan 23 could be set up on eth0.23?).
KiBi.
Attachment:
signature.asc
Description: Digital signature