[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#864000: unblock: debian-goodies/0.69.1



Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: unblock

Please unblock package debian-goodies version 0.69.1.

Laurent Bigonville discovered a syntax error in check-enhancements,
one of debian-goodies' scripts. It shows up in most use cases of that
script and hence makes that script unusable in the way it's usually
used (by checking enhancements for all installed packages).

The other change is a fix which is in Debian Experimental since 22nd
of April (without any related bug reports) and was the result of a
comment by a release team member after reviewing the changes for 0.69,
but wasn't worth an upload of its own.

Full debdiff:

diff -Nru debian-goodies-0.69/check-enhancements debian-goodies-0.69.1/check-enhancements
--- debian-goodies-0.69/check-enhancements	2016-08-06 14:46:24.000000000 +0200
+++ debian-goodies-0.69.1/check-enhancements	2017-06-03 00:46:22.000000000 +0200
@@ -62,7 +62,7 @@
     case $? in
        0) if test $OPT_VERBOSE != 0; then echo -e "Package <<$1>> could be Enhanced by:"; fi
        ;;
-       1) continue
+       1) return
        ;;
        *) echo "${SELF}: Internal Error!"
           exit 1
diff -Nru debian-goodies-0.69/checkrestart debian-goodies-0.69.1/checkrestart
--- debian-goodies-0.69/checkrestart	2017-02-20 02:28:58.000000000 +0100
+++ debian-goodies-0.69.1/checkrestart	2017-02-28 00:23:41.000000000 +0100
@@ -131,6 +131,7 @@
             if line.startswith("#"):
                 continue
             blacklist.append(re.compile(line.strip()))
+        blacklistFile.close()
 
 # Start checking
 
diff -Nru debian-goodies-0.69/debian/changelog debian-goodies-0.69.1/debian/changelog
--- debian-goodies-0.69/debian/changelog	2017-02-20 02:37:42.000000000 +0100
+++ debian-goodies-0.69.1/debian/changelog	2017-06-03 00:56:48.000000000 +0200
@@ -1,3 +1,13 @@
+debian-goodies (0.69.1) unstable; urgency=high
+
+  * Fix missing close statement in checkrestart. (c.f. #855554)
+    Thanks Emilio Pozuelo Monfort!
+  * Fix syntax error in check-enhancements when querying a package which
+    isn't enhanced by any other package or when querying all installed
+    packages. (Closes: #863944) Thanks Laurent Bigonville!
+
+ -- Axel Beckert <abe@debian.org>  Sat, 03 Jun 2017 00:56:48 +0200
+
 debian-goodies (0.69) unstable; urgency=low
 
   * checkrestart: Fix regression with -b/--blacklist from python3

So please...

unblock debian-goodies/0.69.1

-- System Information:
Debian Release: 9.0
  APT prefers unstable
  APT policy: (990, 'unstable'), (600, 'testing'), (500, 'unstable-debug'), (500, 'buildd-unstable'), (110, 'experimental'), (1, 'experimental-debug'), (1, 'buildd-experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 4.9.0-1-amd64 (SMP w/8 CPU cores)
Locale: LANG=C.UTF-8, LC_CTYPE=C.UTF-8 (charmap=UTF-8), LANGUAGE=C.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: sysvinit (via /sbin/init)


Reply to: