[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#863573: marked as done (unblock: diamond/4.0.515-4)

Your message dated Mon, 29 May 2017 18:45:27 +0100
with message-id <b41fb1347e89f3ebdc0cba5f4ac105a6@debian.org>
and subject line Re: Bug#863573: unblock: diamond/4.0.515-4
has caused the Debian Bug report #863573,
regarding unblock: diamond/4.0.515-4
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
863573: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=863573
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: unblock

Please unblock package diamond

This upload improves (even if only slightly, as a proper solution is still being
worked on by upstream) the stop/restart time of diamond, by setting the systemd
killmode to mixed.

A source debdiff is attached

unblock diamond/4.0.515-4

-- System Information:
Debian Release: stretch/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (1, 'experimental')
Architecture: amd64
 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.2.0-1-amd64 (SMP w/8 CPU cores)
Locale: LANG=en_US.utf8, LC_CTYPE=en_US.utf8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

diff -Nru diamond-4.0.515/debian/changelog diamond-4.0.515/debian/changelog
--- diamond-4.0.515/debian/changelog	2017-01-22 17:28:37.000000000 -0500
+++ diamond-4.0.515/debian/changelog	2017-05-28 15:48:29.000000000 -0400
@@ -1,3 +1,10 @@
+diamond (4.0.515-4) unstable; urgency=medium
+
+  * debian/diamond.service
+    - set KillMode to `mixed`; Closes: #854842
+
+ -- Sandro Tosi <morph@debian.org>  Sun, 28 May 2017 15:48:29 -0400
+
 diamond (4.0.515-3) unstable; urgency=medium
 
   * debian/control
diff -Nru diamond-4.0.515/debian/diamond.service diamond-4.0.515/debian/diamond.service
--- diamond-4.0.515/debian/diamond.service	2016-02-16 09:29:38.000000000 -0500
+++ diamond-4.0.515/debian/diamond.service	2017-05-28 15:48:15.000000000 -0400
@@ -4,6 +4,7 @@
 [Service]
 ExecStart=/usr/bin/python /usr/bin/diamond --log-stdout --foreground
 Restart=on-abort
+KillMode=mixed
 
 [Install]
 WantedBy=multi-user.target

--- End Message ---
--- Begin Message --- 
On 2017-05-29 15:43, Sandro Tosi wrote:
On Mon, May 29, 2017 at 8:20 AM, Jonathan Wiltshire <jmw@debian.org> wrote: 
Control: tag -1 moreinfo

On Sun, May 28, 2017 at 03:58:13PM -0400, Sandro Tosi wrote:
This upload improves (even if only slightly, as a proper solution is still being worked on by upstream) the stop/restart time of diamond, by setting the systemd 
killmode to mixed.
I'm not sure how comfortable I am about this. Is the change to KillMode 
upstream advice?


sorry for not reporting it first, there is a long discussion with
upstream at https://github.com/python-diamond/Diamond/issues/595 -
their initial solution was to change the internal process management
logic and then use KillMode=process but paravoid had better result
with `mixed` without changing any code (since that procs mgmt change
still isnt 100% completed)
Ok, I'll take the workaround for now but it would be nice to fix this properly for buster. Thanks for the additional information. 

Unblocked and aged to 5.

--
Jonathan Wiltshire                                      jmw@debian.org
Debian Developer                         http://people.debian.org/~jmw

4096R: 0xD3524C51 / 0A55 B7C5 1223 3942 86EC  74C3 5394 479D D352 4C51

<directhex> i have six years of solaris sysadmin experience, from
            8->10. i am well qualified to say it is made from bonghits
			layered on top of bonghits

--- End Message ---
Reply to: