Bug#862541: marked as done (Pre-approval request, unblock: caffe/1.0.0-2)
Your message dated Sat, 27 May 2017 11:31:53 +0200
with message-id <20170527093152.GA316@ugent.be>
and subject line Re: Bug#862541: Pre-approval request, unblock: caffe/1.0.0-2
has caused the Debian Bug report #862541,
regarding Pre-approval request, unblock: caffe/1.0.0-2
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)
--
862541: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=862541
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message ---
Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: unblock
I'm working on bug #862528 for adding a missing file back,
and the fix will be shipped in 1.0.0-2 (i.e. not uploaded yet).
However the caffe package in testing is 1.0.0~rc4-1 ,
and I wish stretch to ship the 1.0.0 version [1] instead
of an upstream RC version.
I wonder whether this update can be approved. Thanks.
[1] upstream 1.0.0 was released mid-April, behind the full freeze.
--- End Message ---
--- Begin Message ---
Hi,
On Thu, May 18, 2017 at 04:04:26PM +0000, Lumin wrote:
> The difference between the 1.0.0~rc4 version and the 1.0.0 version
> is 162 git commits. I went through these git commits, and
> these commits are about:
>
> 1 documentation update / fix
> 2 code grooming
> 3 bug fix
> 4 add tests
> 5 support cudnn v6 (does not affect this package)
> 6 update docker scripts (does not affect this package)
>
> i.e. There is no major code / feature change from the 1.0.0~rc4 tag
> -> 1.0.0 tag.
> 212 files changed, 3866 insertions(+), 2046 deletions(-)
This is certainly not suitable at this point. Sorry.
> Apart from the upstream stable release, I will add one more patch
> to the packaging directory, which was already approved and merged
> by upstream:
>
> https://github.com/BVLC/caffe/commit/91b09280f5233cafc62954c98ce8bc4c204e7475
>
> The patch will change a ambiguous static library name, and hence
> fixing the bug mentioned previously won't introduce more trouble.
[...]
> If not, can I upload 1.0.0~rc4-2 simply with the patch above
> applied and the fix for the bug mentioned above?
I'm not going to approve this one either. It's unclear which issues are
supposed to be fixed by this change, and what issues could be introduced by
it.
So I'm closing this bug.
Cheers,
Ivo
--- End Message ---
Reply to: