[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#863444: marked as done (unblock: apt-dater/1.0.3-4)

Your message dated Sat, 27 May 2017 05:53:00 +0000
with message-id <c0e460e1-3e54-0ac5-8c88-a3be9bf8974c@thykier.net>
and subject line Re: Bug#863444: unblock: apt-dater/1.0.3-4
has caused the Debian Bug report #863444,
regarding unblock: apt-dater/1.0.3-4
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
863444: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=863444
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: unblock

Please unblock package apt-dater

This update adds one upstream patch to fix the broken Tcl filters in the UI.
They are failing because of incorrect return values.

diff -Naur '--exclude=.svn' 1.0.3-3/debian/changelog 1.0.3-4/debian/changelog
--- 1.0.3-3/debian/changelog    2016-11-22 11:33:34.715749952 +0100
+++ 1.0.3-4/debian/changelog    2017-05-26 16:00:16.415094385 +0200
@@ -1,3 +1,9 @@
+apt-dater (1.0.3-4) unstable; urgency=medium
+
+  * Add upstream patch 03-broken-tcl-filters to fix broken Tcl filters.
+
+ -- Patrick Matthäi <pmatthaei@debian.org>  Fri, 26 May 2017 15:54:42 +0200
+
 apt-dater (1.0.3-3) unstable; urgency=medium

   * Replace patch 01-grep-syntax-error with 02-fix-default-err-pattern from
diff -Naur '--exclude=.svn' 1.0.3-3/debian/patches/03-broken-tcl-filters.diff 1.0.3-4/debian/patches/03-broken-tcl-filters.diff
--- 1.0.3-3/debian/patches/03-broken-tcl-filters.diff   1970-01-01 01:00:00.000000000 +0100
+++ 1.0.3-4/debian/patches/03-broken-tcl-filters.diff   2017-05-26 16:00:16.411094403 +0200
@@ -0,0 +1,21 @@
+# Upstream fix for Tcl filters never matching due to broken return code
+# handling.
+# URL: https://github.com/DE-IBH/apt-dater/commit/c6c41e8fe32b6c80ed6629f0b88e3a429a85a779
+
+diff --git a/src/ui.c b/src/ui.c
+index edf92e2..037340c 100644
+--- a/src/ui.c
++++ b/src/ui.c
+@@ -2813,10 +2813,10 @@ void applyFilter(GList *hosts) {
+       case TCL_OK:
+       case TCL_RETURN:
+           filtered = atoi(Tcl_GetStringResult(tcl_interp)) > 0;
+-          ;;
++          break;
+       default:
+           filtered = FALSE;
+-          ;;
++          break;
+     }
+
+     if(filtered != n->filtered) {
diff -Naur '--exclude=.svn' 1.0.3-3/debian/patches/series 1.0.3-4/debian/patches/series
--- 1.0.3-3/debian/patches/series       2016-11-22 11:33:34.715749952 +0100
+++ 1.0.3-4/debian/patches/series       2017-05-26 16:00:16.411094403 +0200
@@ -1 +1,2 @@
 02-fix-default-err-pattern.diff
+03-broken-tcl-filters.diff

unblock apt-dater/1.0.3-4

-- System Information:
Debian Release: 8.8
  APT prefers stable-updates
  APT policy: (500, 'stable-updates'), (500, 'stable')
Architecture: amd64 (x86_64)

Kernel: Linux 3.16.0-4-amd64 (SMP w/2 CPU cores)
Locale: LANG=de_DE.UTF-8, LC_CTYPE=de_DE.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

--- End Message ---
--- Begin Message --- 
Patrick Matthäi:
> Package: release.debian.org
> Severity: normal
> User: release.debian.org@packages.debian.org
> Usertags: unblock
> 
> Please unblock package apt-dater
> 
> This update adds one upstream patch to fix the broken Tcl filters in the UI.
> They are failing because of incorrect return values.
> 
> [...]
> 
> unblock apt-dater/1.0.3-4
> 
> [...]

Unblocked, thanks.

~Niels

--- End Message ---
Reply to: