[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#862384: marked as done (unblock: gitlab/8.13.11+dfsg1-7)

Your message dated Mon, 22 May 2017 18:36:00 +0000
with message-id <51789b79-d452-eb42-41ef-c15b2f6b065b@thykier.net>
and subject line Re: unblock: gitlab/8.13.11+dfsg1-7
has caused the Debian Bug report #862384,
regarding unblock: gitlab/8.13.11+dfsg1-7
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
862384: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=862384
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: unblock

Please unblock package gitlab

This fixes grave bug #862329

debdif attached

unblock gitlab/8.13.11+dfsg1-7

-- System Information:
Debian Release: 9.0
  APT prefers unstable
  APT policy: (500, 'unstable'), (500, 'testing'), (1, 'experimental')
Architecture: amd64
 (x86_64)

Kernel: Linux 4.9.0-3-amd64 (SMP w/4 CPU cores)
Locale: LANG=ml_IN.UTF-8, LC_CTYPE=ml_IN.UTF-8 (charmap=UTF-8)
Init: systemd (via /run/systemd/system)

diff -Nru gitlab-8.13.11+dfsg1/debian/changelog gitlab-8.13.11+dfsg1/debian/changelog
--- gitlab-8.13.11+dfsg1/debian/changelog	2017-04-27 11:23:43.000000000 +0530
+++ gitlab-8.13.11+dfsg1/debian/changelog	2017-05-12 10:12:55.000000000 +0530
@@ -1,3 +1,19 @@
+gitlab (8.13.11+dfsg1-7) unstable; urgency=medium
+
+  * Correctly bind dbconfig-common configuration file to gitlab package
+    (and not to $gitlab_user) in debian/config
+  * Revert change in debian/postinst from previous upload which incorrectly
+    binds dbconfig-common configuration file to $gitlab_user package
+
+ -- Pirate Praveen <praveen@debian.org>  Fri, 12 May 2017 10:12:55 +0530
+
+gitlab (8.13.11+dfsg1-6) unstable; urgency=medium
+
+  * Remove hard coded gitlab user in postinst (Closes: #862329)
+  * Remove dbconfig-common config files on purge
+
+ -- Pirate Praveen <praveen@debian.org>  Thu, 11 May 2017 22:29:06 +0530
+
 gitlab (8.13.11+dfsg1-5) unstable; urgency=medium
 
   * Fix letsencrypt email handling in config
diff -Nru gitlab-8.13.11+dfsg1/debian/config gitlab-8.13.11+dfsg1/debian/config
--- gitlab-8.13.11+dfsg1/debian/config	2017-04-27 11:23:43.000000000 +0530
+++ gitlab-8.13.11+dfsg1/debian/config	2017-05-12 10:12:55.000000000 +0530
@@ -62,6 +62,6 @@
    dbc_dbtypes="pgsql"
    dbc_dbname="gitlab_production"
    dbc_dbuser="$gitlab_user"
-
-   dbc_go $gitlab_user "$@"
+   
+   dbc_go gitlab "$@"
 fi
diff -Nru gitlab-8.13.11+dfsg1/debian/postinst gitlab-8.13.11+dfsg1/debian/postinst
--- gitlab-8.13.11+dfsg1/debian/postinst	2017-04-27 11:23:43.000000000 +0530
+++ gitlab-8.13.11+dfsg1/debian/postinst	2017-05-12 10:12:55.000000000 +0530
@@ -315,6 +315,7 @@
         echo "Reloading nginx configuration..."
         invoke-rc.d nginx reload
       fi
+    
     dbc_go gitlab "$@"
     db_stop
 
diff -Nru gitlab-8.13.11+dfsg1/debian/postrm gitlab-8.13.11+dfsg1/debian/postrm
--- gitlab-8.13.11+dfsg1/debian/postrm	2017-04-27 11:23:43.000000000 +0530
+++ gitlab-8.13.11+dfsg1/debian/postrm	2017-05-12 10:12:55.000000000 +0530
@@ -90,6 +90,7 @@
     fi
 
     nginx_site="/etc/nginx/sites-available/${GITLAB_HOST}"
+    dbconfig_config="/etc/dbconfig-common/gitlab.conf"
 
     if [ -f ${nginx_site} ]; then echo "Found nginx site configuration at ${nginx_site}..."; fi
 
@@ -103,10 +104,11 @@
 	rm -f ${gitlab_yml}$ext
 	rm -f ${gitlab_tmpfiles}$ext
 	rm -f ${gitlab_shell_config}$ext
+        rm -f ${dbconfig_config}$ext
     done
  
     for i in ${nginx_site} ${gitlab_debian_conf} ${gitlab_yml} \
-${gitlab_tmpfiles} ${gitlab_shell_config}; do
+${gitlab_tmpfiles} ${gitlab_shell_config} ${dbconfig_config}; do
       # remove the configuration file itself
         safely_remove $i
       # and finally clear it out from the ucf database

Attachment: signature.asc
Description: OpenPGP digital signature


--- End Message ---
--- Begin Message --- 
On Fri, 12 May 2017 10:26:37 +0530 Pirate Praveen <praveen@debian.org>
wrote:
> Package: release.debian.org
> Severity: normal
> User: release.debian.org@packages.debian.org
> Usertags: unblock
> 
> Please unblock package gitlab
> 
> This fixes grave bug #862329
> 
> debdif attached
> 
> unblock gitlab/8.13.11+dfsg1-7
> 
>[...]

Unblocked, thanks.

~Niels

--- End Message ---
Reply to: