Bug#862220: unblock: at-spi2-core/2.22.0-6
Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: unblock
Hello,
Upstream of at-spi has released some serious fixes for at-spi2-core,
which I have uploaded as at-spi2-core 2.22.0-6, and attached to this
mail.
git-329ef2c4ebcb3aec6dcfcac15357fd583a60c969 is reported to help fixing
https://bugzilla.gnome.org/show_bug.cgi?id=767074
Orca would sometimes hang or crash when closing an application, thus
leaving blind users without access to the computer, and have to restart
Orca blindly. It seems there are still some cases where the crash
happens, but only after upgrading at-spi2-atk to version 2.24, which we
do not have in Debian yet.
git-eba079f3e72e61e6b55d81727ab50c85d505d296 fixes crashes in Orca too
when getting the Position property fails.
These would probably help with the grave orca Bug#862008
Samuel
unblock at-spi2-core/2.22.0-6
-- System Information:
Debian Release: 9.0
APT prefers testing
APT policy: (990, 'testing'), (500, 'unstable-debug'), (500, 'testing-debug'), (500, 'buildd-unstable'), (500, 'unstable'), (500, 'stable'), (500, 'oldstable'), (1, 'experimental-debug'), (1, 'buildd-experimental'), (1, 'experimental')
Architecture: amd64
(x86_64)
Foreign Architectures: i386
Kernel: Linux 4.11.0 (SMP w/4 CPU cores)
Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
--
Samuel
Battery 1: charging, 90%, charging at zero rate - will never fully charge.
-+- acpi - et pourtant, ca monte -+-
diff -Nru at-spi2-core-2.22.0/debian/changelog at-spi2-core-2.22.0/debian/changelog
--- at-spi2-core-2.22.0/debian/changelog 2016-12-27 19:14:48.000000000 +0100
+++ at-spi2-core-2.22.0/debian/changelog 2017-05-09 21:44:08.000000000 +0200
@@ -1,3 +1,13 @@
+at-spi2-core (2.22.0-6) unstable; urgency=medium
+
+ * patches/git-329ef2c4ebcb3aec6dcfcac15357fd583a60c969:
+ clear root accessible's ref to the app, fixes Orca sometimes hanging when
+ apps are quit.
+ * patches/git-eba079f3e72e61e6b55d81727ab50c85d505d296:
+ atspi_table_cell_get_position: don't crash on error
+
+ -- Samuel Thibault <sthibault@debian.org> Tue, 09 May 2017 21:44:08 +0200
+
at-spi2-core (2.22.0-5) unstable; urgency=medium
* patches/register-client-early: Replace by upstream proposed fix:
diff -Nru at-spi2-core-2.22.0/debian/patches/git-329ef2c4ebcb3aec6dcfcac15357fd583a60c969 at-spi2-core-2.22.0/debian/patches/git-329ef2c4ebcb3aec6dcfcac15357fd583a60c969
--- at-spi2-core-2.22.0/debian/patches/git-329ef2c4ebcb3aec6dcfcac15357fd583a60c969 1970-01-01 01:00:00.000000000 +0100
+++ at-spi2-core-2.22.0/debian/patches/git-329ef2c4ebcb3aec6dcfcac15357fd583a60c969 2017-05-09 21:44:08.000000000 +0200
@@ -0,0 +1,20 @@
+commit 329ef2c4ebcb3aec6dcfcac15357fd583a60c969
+Author: Mike Gorse <mgorse@suse.com>
+Date: Tue Jan 24 18:10:52 2017 -0600
+
+ atspi_application_dispose: clear root accessible's ref to the app
+
+ Hoping that this might fix https://bugzilla.gnome.org/show_bug.cgi?id=767074
+
+diff --git a/atspi/atspi-application.c b/atspi/atspi-application.c
+index 65cabdc..f7dd225 100644
+--- a/atspi/atspi-application.c
++++ b/atspi/atspi-application.c
+@@ -58,6 +58,7 @@ atspi_application_dispose (GObject *object)
+
+ if (application->root)
+ {
++ g_clear_object (&application->root->parent.app);
+ g_object_unref (application->root);
+ application->root = NULL;
+ }
diff -Nru at-spi2-core-2.22.0/debian/patches/git-eba079f3e72e61e6b55d81727ab50c85d505d296 at-spi2-core-2.22.0/debian/patches/git-eba079f3e72e61e6b55d81727ab50c85d505d296
--- at-spi2-core-2.22.0/debian/patches/git-eba079f3e72e61e6b55d81727ab50c85d505d296 1970-01-01 01:00:00.000000000 +0100
+++ at-spi2-core-2.22.0/debian/patches/git-eba079f3e72e61e6b55d81727ab50c85d505d296 2017-05-09 21:42:44.000000000 +0200
@@ -0,0 +1,24 @@
+commit eba079f3e72e61e6b55d81727ab50c85d505d296
+Author: Mike Gorse <mgorse@suse.com>
+Date: Mon Mar 27 12:57:35 2017 -0500
+
+ atspi_table_cell_get_position: don't crash on error
+
+diff --git a/atspi/atspi-table-cell.c b/atspi/atspi-table-cell.c
+index c18e6dc..1df1fa9 100644
+--- a/atspi/atspi-table-cell.c
++++ b/atspi/atspi-table-cell.c
+@@ -163,9 +163,12 @@ atspi_table_cell_get_position (AtspiTableCell *obj,
+ g_return_val_if_fail (obj != NULL, -1);
+
+ reply = _atspi_dbus_call_partial (obj, "org.freedesktop.DBus.Properties",
+- "Get", NULL, "ss",
++ "Get", error, "ss",
+ atspi_interface_table_cell, "Position");
+
++ if (!reply)
++ return -1;
++
+ dbus_message_iter_init (reply, &iter);
+
+ /* TODO: Return error here */
diff -Nru at-spi2-core-2.22.0/debian/patches/series at-spi2-core-2.22.0/debian/patches/series
--- at-spi2-core-2.22.0/debian/patches/series 2016-12-27 17:27:38.000000000 +0100
+++ at-spi2-core-2.22.0/debian/patches/series 2017-05-09 21:44:08.000000000 +0200
@@ -1,3 +1,5 @@
at-spi-by-default
revert-register-late
register-client-not-too-early
+git-329ef2c4ebcb3aec6dcfcac15357fd583a60c969
+git-eba079f3e72e61e6b55d81727ab50c85d505d296
Reply to: