[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#861985: marked as done (unblock: variety/0.6.3-5 (pre-upload approval))

Your message dated Mon, 08 May 2017 16:32:07 +0000
with message-id <E1d7lZv-0004fG-Jp@respighi.debian.org>
and subject line unblock variety
has caused the Debian Bug report #861985,
regarding unblock: variety/0.6.3-5 (pre-upload approval)
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
861985: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=861985
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: unblock

Hi Release Team,

I've prepared variety 0.6.3-5 with two changes: the first is fixing a bug that
caused wallpaper selection panels to eat up 100% CPU when open, and the second
is updating the package's extended description to match the list of supported
wallpaper sources as of Variety 0.6.3.

The relevant debdiff is attached.

unblock variety/0.6.3-5

Best,
James

-- System Information:
Debian Release: 9.0
  APT prefers testing
  APT policy: (700, 'testing'), (500, 'unstable-debug'), (500, 'testing-
debug'), (500, 'unstable'), (101, 'experimental')
Architecture: amd64
 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.9.0-2-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_CA.UTF-8, LC_CTYPE=en_CA.UTF-8 (charmap=UTF-8)

diff -Nru variety-0.6.3/debian/changelog variety-0.6.3/debian/changelog
--- variety-0.6.3/debian/changelog	2017-04-27 22:49:27.000000000 -0700
+++ variety-0.6.3/debian/changelog	2017-05-06 16:43:32.000000000 -0700
@@ -1,3 +1,15 @@
+variety (0.6.3-5) unstable; urgency=medium
+
+  * Add fix-autoscroll-high-cpu.patch backported from upstream Bzr revision
+    592 (https://bazaar.launchpad.net/~variety/variety/trunk/revision/592)
+    This fixes an issue where the Wallpaper Selector and History panels
+    drain entire CPU cores when open. (LP: #1494992)
+  * Fix list of supported sites in package extended description: Wallbase.cc
+    support was removed in 0.6.3, while Wallhaven.cc was never mentioned even
+    though it is supported.
+
+ -- James Lu <bitflip3@gmail.com>  Sat, 06 May 2017 16:43:32 -0700
+
 variety (0.6.3-4) unstable; urgency=medium
 
   * Upload to unstable.
diff -Nru variety-0.6.3/debian/control variety-0.6.3/debian/control
--- variety-0.6.3/debian/control	2017-04-27 22:49:27.000000000 -0700
+++ variety-0.6.3/debian/control	2017-05-06 16:40:03.000000000 -0700
@@ -45,5 +45,5 @@
 Description: Wallpaper changer, downloader and manager
  Variety is an open-source wallpaper changer, downloader, and manager for
  Linux. It supports a variety of sources for wallpapers, including local
- files, online services such as Flickr, Wallbase.cc, NASA Astronomy Picture of
- the Day, Desktoppr.co, and media RSS feeds (Picasa, deviantART, etc.).
+ files, online services such as Flickr, Wallhaven.cc, NASA Astronomy Picture
+ of the Day, Desktoppr.co, and media RSS feeds (Picasa, deviantART, etc.).
diff -Nru variety-0.6.3/debian/patches/fix-autoscroll-high-cpu.patch variety-0.6.3/debian/patches/fix-autoscroll-high-cpu.patch
--- variety-0.6.3/debian/patches/fix-autoscroll-high-cpu.patch	1969-12-31 16:00:00.000000000 -0800
+++ variety-0.6.3/debian/patches/fix-autoscroll-high-cpu.patch	2017-05-06 16:32:20.000000000 -0700
@@ -0,0 +1,30 @@
+From: James Lu <james@overdrivenetworks.com>
+Subject: Fix autoscroll in wallpaper selector & history panels using 100% CPU
+ .
+ Previously, the autoscroll event was never cleared when the user moved the
+ mouse away from the Thumbnails panel. This caused the
+ self.autoscroll_event.wait(10) call in _autoscroll_thread() to always
+ instantly succeed, and created an infinite loop eating up CPU.
+Origin: upstream, https://bazaar.launchpad.net/~variety/variety/trunk/revision/592
+Bug: https://bugs.launchpad.net/variety/+bug/1494992
+Last-Update: 2017-05-06
+
+---
+ variety/ThumbsWindow.py | 1 +
+ 1 file changed, 1 insertion(+)
+
+diff --git a/variety/ThumbsWindow.py b/variety/ThumbsWindow.py
+index 6cd730c..48ebc43 100644
+--- a/variety/ThumbsWindow.py
++++ b/variety/ThumbsWindow.py
+@@ -79,6 +79,7 @@ class ThumbsWindow(Gtk.Window):
+             self.mouse_in = False
+             self.mouse_position = None
+             self.previous_speed = 0
++            self.autoscroll_event.clear()
+
+         eventbox = Gtk.EventBox()
+         eventbox.set_visible(True)
+--
+2.11.0
+
diff -Nru variety-0.6.3/debian/patches/series variety-0.6.3/debian/patches/series
--- variety-0.6.3/debian/patches/series	2017-04-27 22:49:27.000000000 -0700
+++ variety-0.6.3/debian/patches/series	2017-05-06 16:30:06.000000000 -0700
@@ -1,3 +1,4 @@
+fix-autoscroll-high-cpu.patch
 disable-panoramio.patch
 menu-position-varargs.patch
 remove-timebombs.patch

--- End Message ---
--- Begin Message --- 
Unblocked variety.

--- End Message ---
Reply to: