[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#861725: marked as done (unblock: nagstamon/2.0.1-5)

Your message dated Sun, 07 May 2017 21:05:00 +0000
with message-id <87c98b6a-7400-7224-1efb-1f703b9c11e3@thykier.net>
and subject line Re: Bug#861725: unblock: nagstamon/2.0.1-5
has caused the Debian Bug report #861725,
regarding unblock: nagstamon/2.0.1-5
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
861725: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=861725
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: unblock

Please unblock package nagstamon

Hi there,

nagstamon/2.0.1-4, which just got uploaded to unstable fixes #861152, which is
release critical and #774002, which just adds a Recommends for convenience - I
hope this doesn't prevent the unblock.

Thank you.

Attached nagstamon_2.0.1-4.debdiff

unblock nagstamon/2.0.1-4

-- System Information:
Debian Release: 8.7
  APT prefers stable-updates
  APT policy: (700, 'stable-updates'), (700, 'stable'), (60, 'testing')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.9.0-0.bpo.2-amd64 (SMP w/8 CPU cores)
Locale: LANG=en_US.utf8, LC_CTYPE=en_US.utf8 (charmap=UTF-8)

diff -Nru nagstamon-2.0.1/debian/changelog nagstamon-2.0.1/debian/changelog
--- nagstamon-2.0.1/debian/changelog	2017-01-12 11:27:30.000000000 +0100
+++ nagstamon-2.0.1/debian/changelog	2017-05-03 09:55:17.000000000 +0200
@@ -1,3 +1,18 @@
+nagstamon (2.0.1-4) unstable; urgency=medium
+
+  * Add Recommends for python3-secretstorage to debian/control
+    Closes: #774002
+  * Fix code for disabling InsecureRequestWarning warnings
+    Closes: #861152
+
+ -- Moritz Schlarb <schlarbm@uni-mainz.de>  Fri, 28 Apr 2017 21:16:17 +0200
+
+nagstamon (2.0.1-1~bpo8+1) jessie-backports; urgency=medium
+
+  * jessie-backports rebuild
+
+ -- Christoph Martin <martin@uni-mainz.de>  Tue, 24 Jan 2017 12:31:59 +0100
+
 nagstamon (2.0.1-1) unstable; urgency=medium
 
   [ Moritz Schlarb ]
diff -Nru nagstamon-2.0.1/debian/control nagstamon-2.0.1/debian/control
--- nagstamon-2.0.1/debian/control	2017-01-12 11:27:30.000000000 +0100
+++ nagstamon-2.0.1/debian/control	2017-04-28 10:34:47.000000000 +0200
@@ -16,6 +16,7 @@
 Depends: ${python3:Depends}, ${misc:Depends}, python3-pkg-resources, python3-bs4,
  python3-pyqt5, python3-pyqt5.qtsvg, python3-pyqt5.qtmultimedia, libqt5multimedia5-plugins,
  python3-requests, python3-psutil, python3-dbus.mainloop.pyqt5
+Recommends: python3-secretstorage
 Description: Nagios status monitor which takes place in systray or on desktop
  Nagstamon is a Nagios status monitor which takes place in systray or 
  on desktop (GNOME, KDE) as floating statusbar to inform you in
diff -Nru nagstamon-2.0.1/debian/patches/disable-InsecureRequestWarning-warnings.patch nagstamon-2.0.1/debian/patches/disable-InsecureRequestWarning-warnings.patch
--- nagstamon-2.0.1/debian/patches/disable-InsecureRequestWarning-warnings.patch	1970-01-01 01:00:00.000000000 +0100
+++ nagstamon-2.0.1/debian/patches/disable-InsecureRequestWarning-warnings.patch	2017-04-28 21:18:12.000000000 +0200
@@ -0,0 +1,17 @@
+Description: Really disable InsecureRequestWarning warnings
+Author: Moritz Schlarb <schlarbm@uni-mainz.de>
+Bug-Debian: https://bugs.debian.org/861152
+
+diff --git a/Nagstamon/Servers/Generic.py b/Nagstamon/Servers/Generic.py
+index dd9dcb1..825e209 100644
+--- a/Nagstamon/Servers/Generic.py
++++ b/Nagstamon/Servers/Generic.py
+@@ -20,7 +20,7 @@
+ import requests
+ # disable annoying InsecureRequestWarning warnings
+ try:
+-    requests.packages.urllib3.disable_warnings()
++    requests.packages.urllib3.disable_warnings(requests.packages.urllib3.exceptions.InsecureRequestWarning)
+ except:
+     # older requests version might not have the packages submodule
+     # for example the one in Ubuntu 14.04
diff -Nru nagstamon-2.0.1/debian/patches/series nagstamon-2.0.1/debian/patches/series
--- nagstamon-2.0.1/debian/patches/series	2017-01-12 11:27:30.000000000 +0100
+++ nagstamon-2.0.1/debian/patches/series	2017-04-28 21:15:14.000000000 +0200
@@ -1,3 +1,4 @@
+disable-InsecureRequestWarning-warnings.patch
 check-for-new-version.patch
 no-QtCore-in-setup-py.patch
 spelling-error-in-manpage.patch
diff -Nru nagstamon-2.0.1/debian/README.debian nagstamon-2.0.1/debian/README.debian
--- nagstamon-2.0.1/debian/README.debian	1970-01-01 01:00:00.000000000 +0100
+++ nagstamon-2.0.1/debian/README.debian	2017-04-28 21:23:25.000000000 +0200
@@ -0,0 +1,17 @@
+Nagstamon for Debian
+--------------------
+
+Please note that not to verify server certificates is a deliberate decision
+made by upstream (although there is an open issue to make it configurable
+per server) that is shared by the current package maintainers.
+The rationale for this is that monitoring servers are typically not
+intended for broad public access but for a limited group of technically
+trained users. (#861152)
+
+If you see "ImportError: No module named secretstorage" while starting:
+This non-critical message will occur when the recommended package
+python3-secretstorage is not installed. Nagstamon will work regardless,
+but please be aware that your server credentials will be stored
+in plaintext in the config files. (#774002)
+
+ -- Moritz Schlarb <schlarbm@uni-mainz.de>  Fri, 28 Apr 2017 21:06:17 +0200

--- End Message ---
--- Begin Message --- 
Moritz Schlarb:
> Control: retitle -1 unblock: nagstamon/2.0.1-5
> 
> Hi everyone,
> 
> I changed the patch to kind of the reverse: It now explicitly does not
> call disable_warnings.
> 
> Regards,
> Moritz
> 
> Attached nagstamon_2.0.1-5.debdiff
> 
> unblock nagstamon/2.0.1-5
> 
> [...]

Unblocked, thanks.

~Niels

--- End Message ---
Reply to: