[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#861867: marked as done (unblock: debsums/2.2.2)



Your message dated Sun, 07 May 2017 19:05:00 +0000
with message-id <17b5b315-74ab-8220-9cb8-7ac40eed43e8@thykier.net>
and subject line Re: Bug#861867: unblock: debsums/2.2.2
has caused the Debian Bug report #861867,
regarding unblock: debsums/2.2.2
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
861867: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=861867
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message ---
Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: unblock

Please unblock package debsums 2.2.1.

It mitigates an issue with false positives in piuparts. See
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=689508#67 and the
following comments.

Andreas Beckmann verified with a previously known false positive that
the patch works as expected, see
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=689508#103

debdiff | diffstat against 2.2 from Debian Testing:

 debian/changelog   |   16 +++++++
 debsums            |    9 +++-
 man/debsums.1      |    3 +
 man/po/de.po       |  117 +++++++++++++++++++++++++++++-----------------------
 man/po/debsums.pot |  115 ++++++++++++++++++++++++++++-----------------------
 man/po/es.po       |  116 ++++++++++++++++++++++++++++------------------------
 man/po/fr.po       |  117 +++++++++++++++++++++++++++++-----------------------
 man/po/pt.po       |  116 ++++++++++++++++++++++++++++------------------------
 man/po/pt_BR.po    |  118 +++++++++++++++++++++++++++++------------------------
 man/po/ru.po       |  117 +++++++++++++++++++++++++++++-----------------------
 man/po/sv.po       |  117 +++++++++++++++++++++++++++++-----------------------
 11 files changed, 543 insertions(+), 418 deletions(-)

All the files under man/po/ are generated files and most changes in
there are updated line numbers.

debdiff against 2.2 from Debian Testing (without regenerated po files):

diff -Nru debsums-2.2/debian/changelog debsums-2.2.1/debian/changelog
--- debsums-2.2/debian/changelog	2017-01-21 21:37:12.000000000 +0100
+++ debsums-2.2.1/debian/changelog	2017-05-03 02:49:52.000000000 +0200
@@ -1,3 +1,19 @@
+debsums (2.2.1) unstable; urgency=low
+
+  * Release umodified as 2.2.1 and upload to unstable. Thanks to Andreas
+    Beckmann for testing the release candidate!
+
+ -- Axel Beckert <abe@debian.org>  Wed, 03 May 2017 02:49:52 +0200
+
+debsums (2.2.1~rc1) experimental; urgency=low
+
+  * Ignore obsolete conffiles by default (c.f. #689508). Based on patch by
+    Andreas Beckmann, but with option to disable the ignoring of obsolete
+    conffiles.
+  * Regenerate po-files.
+
+ -- Axel Beckert <abe@debian.org>  Sun, 30 Apr 2017 18:14:35 +0200
+
 debsums (2.2) unstable; urgency=medium
 
   [ Andreas Beckmann ]
diff -Nru debsums-2.2/debsums debsums-2.2.1/debsums
--- debsums-2.2/debsums	2017-01-21 19:51:36.000000000 +0100
+++ debsums-2.2.1/debsums	2017-05-03 02:47:48.000000000 +0200
@@ -78,6 +78,7 @@
                               is configured
      --no-prelink             report changed ELF files even if prelink is
                               configured
+     --no-ignore-obsolete     don't ignore obsolete conffiles.
      --help                   print this help, then exit
      --version                print version number, then exit
 EOT
@@ -98,6 +99,7 @@
     'locale-purge!'	=> \my $localepurge,
     'prelink!'		=> \my $prelink,
     'ignore-permissions' => \my $ignore_permissions,
+    'ignore-obsolete!'  => \my $ignore_obsolete,
     g			=> sub { $gen_opt = 'missing' },
     help		=> sub { print $help; exit },
     version		=> sub { print version_info(); exit },
@@ -206,6 +208,9 @@
     ($prelink) = grep -x, map +("$_.bin", $_), '/usr/sbin/prelink';
 }
 
+# default is to use ignore obsolete conffiles, see #689508
+$ignore_obsolete = 1 unless defined $ignore_obsolete;
+
 $silent++ if $changed;
 
 my @debpath = '.';
@@ -262,7 +267,9 @@
             $package_name{$field{"Package"}} = $field{"binary:Package"};
         }
         $installed{$field{"binary:Package"}}{Conffiles} = {
-            map m!^\s*/(\S+)\s+([\da-f]+)!, split /\n/, $field{Conffiles}
+            map m!^\s*/(\S+)\s+([\da-f]+)!,
+                grep { not ($ignore_obsolete and / obsolete$/) }
+                split /\n/, $field{Conffiles}
         } if $field{Conffiles};
 
         for (split /,\s*/, $field{Replaces})
diff -Nru debsums-2.2/man/debsums.1 debsums-2.2.1/man/debsums.1
--- debsums-2.2/man/debsums.1	2016-05-09 17:04:38.000000000 +0200
+++ debsums-2.2.1/man/debsums.1	2017-05-03 02:47:48.000000000 +0200
@@ -105,6 +105,9 @@
 .BR \-\-ignore\-permissions
 Treat permission errors as warnings when running as non-root.
 .TP
+.BR \-\-no\-ignore\-obsolete
+Disable the ignoring of obsolete conffiles.
+.TP
 .B \-\-help
 .PD 0
 .TP

Full debdiff attached, too.

So please...

unblock debsums/2.2.1

-- System Information:
Debian Release: 9.0
  APT prefers unstable
  APT policy: (990, 'unstable'), (600, 'testing'), (500, 'unstable-debug'), (500, 'buildd-unstable'), (110, 'experimental'), (1, 'experimental-debug'), (1, 'buildd-experimental')
Architecture: amd64
 (x86_64)

Kernel: Linux 4.9.0-1-amd64 (SMP w/8 CPU cores)
Locale: LANG=C.UTF-8, LC_CTYPE=C.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: sysvinit (via /sbin/init)

Attachment: debsums_2.2_2.2.1.dsc.full-debdiff.gz
Description: application/gzip


--- End Message ---
--- Begin Message ---
Axel Beckert:
> Control: retitle -1 unblock: debsums/2.2.2
> Control: tag -1 - moreinfo
> 
> Hi,
> 
> [...]
> 
> Can you please test 2.2.2 again as you did with 2.2.1~rc1? TIA!
> 
> Debdiff between 2.2 (currently in testing) and 2.2.2 (just uploaded)
> without diff of the regenerated PO files (full debdiff attached):
> 

Unblocked debsums/2.2.2.

A few typos spotted in this review:

> diff -Nru debsums-2.2/debian/changelog debsums-2.2.2/debian/changelog
> --- debsums-2.2/debian/changelog	2017-01-21 21:37:12.000000000 +0100
> +++ debsums-2.2.2/debian/changelog	2017-05-07 16:05:58.000000000 +0200
> @@ -1,3 +1,32 @@
> [...]
> +debsums (2.2.1) unstable; urgency=low
> +
> +  * Release umodified as 2.2.1 and upload to unstable. Thanks to Andreas
               ^^^^^^^^^

unmodified

> [...]
> diff -Nru debsums-2.2/debsums debsums-2.2.2/debsums
> --- debsums-2.2/debsums	2017-01-21 19:51:36.000000000 +0100
> +++ debsums-2.2.2/debsums	2017-05-07 13:38:04.000000000 +0200
> [...]
> @@ -440,6 +444,8 @@
>          }
>          my $fp = $root . '/' . join('/', @parts) . '/' . $token;
>          if ($seen{$fp}) {
> +            # better die now with a clear error message then later
> +            # with a sysopen fails
>              die "$self: Error: symlink loop detected in path '$path'. ",
>                  "Please file a bug again $package.\n";
                                      ^^^^^

Against

> [...]
> 
> 		Regards, Axel
> 

Thanks,
~Niels

--- End Message ---

Reply to: