Bug#861817: unblock: slim/1.3.6-5.1
Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: unblock
Dear Release Team,
Please unblock package slim
The version in unstable fixes a critical bug that caused slim to be
periodically re-started when run under systemd, rendering the users'
desktops unusable. For more details, please see #861474.
Full source debdiff attached.
Thanks,
Apollon
unblock slim/1.3.6-5.1
diff -Nru slim-1.3.6/debian/changelog slim-1.3.6/debian/changelog
--- slim-1.3.6/debian/changelog 2017-04-23 19:14:21.000000000 +0300
+++ slim-1.3.6/debian/changelog 2017-05-02 16:48:36.000000000 +0300
@@ -1,3 +1,16 @@
+slim (1.3.6-5.1) unstable; urgency=medium
+
+ * Non-maintainer upload.
+ * slim.service: Drop BusName=, fixing endless (re-)start loop under systemd.
+ Thanks Aggelos Avgerinos <evaggelos.avgerinos@gmail.com> for testing.
+ (Closes: #861474)
+ * slim.service: Drop Conflicts=plymouth-quit.service and
+ OnFailure=plymouth-quit.service, as slim does not stop plymouth by itself.
+ Retain After=plymouth-quit.service for correct ordering though, which
+ should be sufficient to solve #860465.
+
+ -- Apollon Oikonomopoulos <apoikos@debian.org> Tue, 02 May 2017 16:48:36 +0300
+
slim (1.3.6-5) unstable; urgency=medium
* Fix bugged Debian-Lines theme. (Closes: #776693)
diff -Nru slim-1.3.6/debian/patches/fix-missing-plymouth-handling.patch slim-1.3.6/debian/patches/fix-missing-plymouth-handling.patch
--- slim-1.3.6/debian/patches/fix-missing-plymouth-handling.patch 2017-04-23 18:38:28.000000000 +0300
+++ slim-1.3.6/debian/patches/fix-missing-plymouth-handling.patch 2017-05-02 16:48:36.000000000 +0300
@@ -1,24 +1,16 @@
-Description: Replace plymouth-quit.service since slim will quit plymouth by itself
+Description: Order slim.service after plymouth-quit.service
+ See the discussion in https://bugs.debian.org/782456
Author: Mateusz Łukasik <mati75@linuxmint.pl>
Bug-Debian: https://bugs.debian.org/860465
-Last-Update: 2017-04-23
+Last-Update: 2017-05-03
--- a/slim.service
+++ b/slim.service
-@@ -2,7 +2,16 @@
+@@ -1,6 +1,6 @@
+ [Unit]
Description=SLiM Simple Login Manager
- After=systemd-user-sessions.service
+-After=systemd-user-sessions.service
++After=systemd-user-sessions.service plymouth-quit.service
-+# replaces plymouth-quit since slim quits plymouth on its own
-+Conflicts=plymouth-quit.service
-+After=plymouth-quit.service
-+
-+# slim takes responsibility for stopping plymouth, so if it fails
-+# for any reason, make sure plymouth still stops
-+OnFailure=plymouth-quit.service
-+
[Service]
ExecStartPre=/bin/sh -c '[ "$(cat /etc/X11/default-display-manager 2>/dev/null)" = "/usr/bin/slim" ]'
- ExecStart=/usr/bin/slim -nodaemon
- Restart=always
-+BusName=org.freedesktop.DisplayManager
Reply to: