Bug#860988: unblock: python-pyftpdlib/1.5.1-4
Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: unblock
Please unblock package python-pyftpdlib
The new version does not change any code of the binary package, but
just disables some automatic tests, that failed occasionaly.
Upstream explainded that those tests are not yet stable, so they
should not be part of the automatic test during package build.
Also, I fixed the maintainer field.
diff -Nru python-pyftpdlib-1.5.1/debian/changelog python-pyftpdlib-1.5.1/debian/changelog
--- python-pyftpdlib-1.5.1/debian/changelog 2016-12-25 21:40:48.000000000 +0100
+++ python-pyftpdlib-1.5.1/debian/changelog 2017-04-23 00:45:44.000000000 +0200
@@ -1,3 +1,10 @@
+python-pyftpdlib (1.5.1-4) unstable; urgency=medium
+
+ * Disable automatic tests, that are known to be unstable (Closes: #856335)
+ * Remove Janos Guljas as maintainer (Closes: #849728)
+
+ -- W. Martin Borgert <debacle@debian.org> Sat, 22 Apr 2017 22:45:44 +0000
+
python-pyftpdlib (1.5.1-3) unstable; urgency=medium
* Set TRAVIS=1 to skip one unit test, marked by upstream as
diff -Nru python-pyftpdlib-1.5.1/debian/control python-pyftpdlib-1.5.1/debian/control
--- python-pyftpdlib-1.5.1/debian/control 2016-10-18 10:42:51.000000000 +0200
+++ python-pyftpdlib-1.5.1/debian/control 2017-01-25 01:34:53.000000000 +0100
@@ -1,9 +1,8 @@
Source: python-pyftpdlib
Section: python
Priority: optional
-Maintainer: Janos Guljas <janos@debian.org>
-Uploaders: Debian Python Modules Team <python-modules-team@lists.alioth.debian.org>,
- W. Martin Borgert <debacle@debian.org>
+Maintainer: Debian Python Modules Team <python-modules-team@lists.alioth.debian.org>
+Uploaders: W. Martin Borgert <debacle@debian.org>
Build-Depends: debhelper (>= 9),
python-all (>= 2.6.6-3~),
python-mock,
diff -Nru python-pyftpdlib-1.5.1/debian/patches/disable_unstable_tests.patch python-pyftpdlib-1.5.1/debian/patches/disable_unstable_tests.patch
--- python-pyftpdlib-1.5.1/debian/patches/disable_unstable_tests.patch 1970-01-01 01:00:00.000000000 +0100
+++ python-pyftpdlib-1.5.1/debian/patches/disable_unstable_tests.patch 2017-04-23 00:21:58.000000000 +0200
@@ -0,0 +1,22 @@
+Description: Disable automatic tests, that are know to be unstable
+Author: W. Martin Borgert <debacle@debian.org>
+Origin: vendor
+Bug: https://github.com/giampaolo/pyftpdlib/issues/420
+Bug-Debian: https://bugs.debian.org/856335
+Last-Update: 2017-04-23
+---
+This patch header follows DEP-3: http://dep.debian.net/deps/dep3/
+--- a/pyftpdlib/test/runner.py
++++ b/pyftpdlib/test/runner.py
+@@ -17,8 +17,10 @@
+
+
+ def main():
++ excludefiles = os.environ.get("EXCLUDETESTS", "").split()
+ testmodules = [os.path.splitext(x)[0] for x in os.listdir(HERE)
+- if x.endswith('.py') and x.startswith('test_')]
++ if x.endswith('.py') and x.startswith('test_')
++ and x not in excludefiles]
+ configure_logging()
+ remove_test_files()
+ suite = unittest.TestSuite()
diff -Nru python-pyftpdlib-1.5.1/debian/patches/series python-pyftpdlib-1.5.1/debian/patches/series
--- python-pyftpdlib-1.5.1/debian/patches/series 2016-10-12 02:03:03.000000000 +0200
+++ python-pyftpdlib-1.5.1/debian/patches/series 2017-04-22 23:25:34.000000000 +0200
@@ -1 +1,2 @@
+disable_unstable_tests.patch
sslv3_deprecated.patch
diff -Nru python-pyftpdlib-1.5.1/debian/rules python-pyftpdlib-1.5.1/debian/rules
--- python-pyftpdlib-1.5.1/debian/rules 2016-12-25 21:35:28.000000000 +0100
+++ python-pyftpdlib-1.5.1/debian/rules 2017-04-22 23:22:38.000000000 +0200
@@ -7,7 +7,9 @@
override_dh_auto_test:
ifeq "$(filter nocheck,$(DEB_BUILD_OPTIONS))" ""
+ EXCLUDETESTS="test_functional.py test_functional_ssl.py" \
PYTHONPATH=. TRAVIS=1 python pyftpdlib/test/runner.py
+ EXCLUDETESTS="test_functional.py test_functional_ssl.py" \
PYTHONPATH=. TRAVIS=1 python3 pyftpdlib/test/runner.py
endif
unblock python-pyftpdlib/1.5.1-4
Reply to: