[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#860773: unblock: pysal/1.13.0-4



Control: tags -1 - moreinfo

Hi Ivo,

On 04/22/2017 01:58 PM, Ivo De Decker wrote:
> On Wed, Apr 19, 2017 at 11:40:33PM +0200, Bas Couwenberg wrote:
>> Please unblock package pysal
>>
>> It "fixes" #860694 by ignoring test failure on i386 where it's normally
>> not built (the source only builds arch:all packages).
> 
> Same question as in #860772:
> 
> Do you expect the build (including the tests) to work on all other
> architectures? If so, this fix is fine.

Same answer as in #860772. Yes, I expect the build (and tests) to work
on all other architectures, but I've not explicitly tested that.

The rounding issue on i386 may be applicable to other 32bit systems.

> If it only works on amd64, it might be better to ignore failures on all other
> architectures instead of only ignoring it on i386.

I prefer the blacklist over whitelist approach for tests, so I'd like to
keep the package as it is now.

Kind Regards,

Bas

-- 
 GPG Key ID: 4096R/6750F10AE88D4AF1
Fingerprint: 8182 DE41 7056 408D 6146  50D1 6750 F10A E88D 4AF1


Reply to: