Bug#858163: unblock: gitlab/8.13.11+dfsg-6

[Niels Thykier <niels@thykier.net>]

Pirate Praveen:
> Control: tags -1 -moreinfo
> 
> On Saturday 15 April 2017 01:24 AM, Niels Thykier wrote:
>> Sorry for the delay in getting back to you.
> 
> Thanks for the detailed review.
> 


Hi,

Thanks for working on improving Debian. :)

I noticed the following in the postrm (gitlab/8.13.11+dfsg1-3)

"""
+      if [ "${RET}" = "true" ]; then
+        if [ -d ${gitlab_data_dir} ]; then
+          for i in shared [...] Gemfile.lock; do
+            if [ -e ${gitlab_data_dir}/$i ]; then
                   rm -rf ${gitlab_data_dir}/$i;
             fi
+          done
+        fi

"""

Apparently "[ -d ${foo} ]" returns 0 even if foo is unset.  Fortunately,
there are no "standard" directories in the list of dirs being removed,
but I would prefer if the next upload had an explicit check for
"${gitlab_data_dir}" being non-empty.  Just to be future-proof.


>[...]
> 
> In addition to the changes mentioned above, it also fixes the rc bug #858725
> 

Thanks for that.

I will unblock with an ageing of 5 days to give other people a chance to
review it and provide comments before it migrates.  Again, this is not
my strongest suit.

Thanks,
~Niels