[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#858836: marked as done (unblock: h5py/2.7.0~rc3-2 or h5py/2.7.0-1 (pre-approval))

Your message dated Tue, 11 Apr 2017 14:14:00 +0000
with message-id <1de058d4-789c-d1b0-d85b-077d72a6c9c6@thykier.net>
and subject line Re: Bug#858836: unblock: h5py/2.7.0-1
has caused the Debian Bug report #858836,
regarding unblock: h5py/2.7.0~rc3-2 or h5py/2.7.0-1 (pre-approval)
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
858836: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=858836
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: unblock

Please unblock package h5py

Whilst improving the DEP-8 tests of h5py to cover all supported Python
versions, I discovered that the -dbg packages were missing an install
dependency on Numpy (#858727). Without this fix, using python-h5py-dbg
or python3-h5py-dbg would result in an ImportError.

I have prepared an update providing the more comprehensive DEP-8 tests
and solving the issue with the missing numpy-dbg install dependencies.
The corresponding debdiff is attached with this email. I would like to
request your approval for pushing this update to unstable and letting it
migrate to Stretch.

On a closing note, upstream recently released h5py version 2.7.0. This
version does not differ much from 2.7.0~rc3, and providing it would
allow us to drop the last two patches from the patch queue that had to
be cherry-picked in order to get rc3 to work. Therefore, perhaps
shipping 2.7.0 instead of rc3 would be better from a maintenance
perspective.

Best regards,
Ghis

unblock h5py/2.7.0~rc3-2

-- System Information:
Debian Release: 9.0
  APT prefers unstable
  APT policy: (500, 'unstable'), (500, 'testing'), (1, 'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 4.9.0-2-amd64 (SMP w/8 CPU cores)
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

diff -Nru h5py-2.7.0~rc3/debian/changelog h5py-2.7.0~rc3/debian/changelog
--- h5py-2.7.0~rc3/debian/changelog	2017-01-25 14:13:35.000000000 +0000
+++ h5py-2.7.0~rc3/debian/changelog	2017-03-25 15:55:00.000000000 +0000
@@ -1,3 +1,10 @@
+h5py (2.7.0~rc3-2) unstable; urgency=medium
+
+  * Run DEP-8 tests for all supported Python versions
+  * Add missing i-deps on python{,3}-numpy-dbg (Closes: #858727)
+
+ -- Ghislain Antony Vaillant <ghisvail@gmail.com>  Sat, 25 Mar 2017 15:55:00 +0000
+
 h5py (2.7.0~rc3-1) unstable; urgency=medium
 
   * New upstream release (Closes: #851162)
diff -Nru h5py-2.7.0~rc3/debian/control h5py-2.7.0~rc3/debian/control
--- h5py-2.7.0~rc3/debian/control	2017-01-25 14:13:35.000000000 +0000
+++ h5py-2.7.0~rc3/debian/control	2017-03-25 15:55:00.000000000 +0000
@@ -69,7 +69,8 @@
 Depends: ${misc:Depends},
          ${python:Depends},
          ${shlibs:Depends},
-         python-h5py (= ${binary:Version})
+         python-h5py (= ${binary:Version}),
+         python-numpy-dbg
 Description: debug extension for h5py (Python 2)
  HDF5 for Python (h5py) is a general-purpose Python interface to the
  Hierarchical Data Format library, version 5. HDF5 is a versatile, mature
@@ -125,7 +126,8 @@
 Depends: ${misc:Depends},
          ${python3:Depends},
          ${shlibs:Depends},
-         python3-h5py (= ${binary:Version})
+         python3-h5py (= ${binary:Version}),
+         python3-numpy-dbg
 Description: debug extension for h5py (Python 3)
  HDF5 for Python (h5py) is a general-purpose Python interface to the
  Hierarchical Data Format library, version 5. HDF5 is a versatile, mature
diff -Nru h5py-2.7.0~rc3/debian/tests/control h5py-2.7.0~rc3/debian/tests/control
--- h5py-2.7.0~rc3/debian/tests/control	2017-01-25 14:13:35.000000000 +0000
+++ h5py-2.7.0~rc3/debian/tests/control	2017-03-25 15:55:00.000000000 +0000
@@ -1,9 +1,27 @@
-Test-Command: cd $AUTOPKGTEST_TMP
- ; python -c "import h5py; h5py.run_tests()"
-Depends: python-h5py
+Test-Command: set -e
+ ; for py in $(pyversions -r 2>/dev/null)
+ ; do cd "$AUTOPKGTEST_TMP"
+ ; echo "Testing with $py:"
+ ; $py -c "import h5py; h5py.run_tests()"
+ ; echo "Testing with $py-dbg:"
+ ; $py-dbg -c "import h5py; h5py.run_tests()"
+ ; done
+Depends: python-all,
+         python-all-dbg,
+         python-h5py,
+         python-h5py-dbg
 Restrictions: allow-stderr
 
-Test-Command: cd $AUTOPKGTEST_TMP
- ; python3 -c "import h5py; h5py.run_tests()"
-Depends: python3-h5py
+Test-Command: set -e
+ ; for py in $(py3versions -r 2>/dev/null)
+ ; do cd "$AUTOPKGTEST_TMP"
+ ; echo "Testing with $py:"
+ ; $py -c "import h5py; h5py.run_tests()"
+ ; echo "Testing with $py-dbg:"
+ ; $py-dbg -c "import h5py; h5py.run_tests()"
+ ; done
+Depends: python3-all,
+         python3-all-dbg,
+         python3-h5py,
+         python3-h5py-dbg
 Restrictions: allow-stderr

--- End Message ---
--- Begin Message --- 
Ghislain Vaillant:
> control: tags -1 - moreinfo
> 
> On 08/04/17 15:57, Niels Thykier wrote:
>> Please remove the moreinfo tag once the upload is complete and has been
>> built on all relevant release architectures.
> 
> Uploaded to unstable.
> 
> Thanks,
> Ghis

Unblocked, thanks.

~Niels

--- End Message ---
Reply to: