[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#858831: marked as done (unblock: qpxtool/0.7.2-4.1)

Your message dated Wed, 05 Apr 2017 17:29:00 +0000
with message-id <f0914a2b-6af5-fd57-4503-0d238f360f21@thykier.net>
and subject line Re: unblock: qpxtool/0.7.2-4.1
has caused the Debian Bug report #858831,
regarding unblock: qpxtool/0.7.2-4.1
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
858831: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=858831
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: release.debian.org
Severity: normal
Tags: patch
User: release.debian.org@packages.debian.org
Usertags: unblock

Hi!

qpxtool_0.7.2-4.1 contains a small patch which fixes the
signedness of char attributes inside the wr_mode struct.

This fixes the FTBFS of qpxtool on architectures where
char is unsigned by default.

unblock qpxtool/0.7.2-4.1

-- System Information:
Debian Release: 9.0
  APT prefers buildd-unstable
  APT policy: (500, 'buildd-unstable'), (500, 'unstable'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.10.0-trunk-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

diff -Nru qpxtool-0.7.2/debian/changelog qpxtool-0.7.2/debian/changelog
--- qpxtool-0.7.2/debian/changelog	2014-04-12 22:19:40.000000000 +0200
+++ qpxtool-0.7.2/debian/changelog	2017-02-27 14:04:55.000000000 +0100
@@ -1,3 +1,11 @@
+qpxtool (0.7.2-4.1) unstable; urgency=medium
+
+  * Non-maintainer upload.
+  * Add patch 07-fix-wr-mode-declarations.patch:
+    - Fix declaration of char attributes in wr_mode. (Closes: #856231)
+
+ -- John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>  Mon, 27 Feb 2017 14:04:55 +0100
+
 qpxtool (0.7.2-4) unstable; urgency=medium
 
   * Update debian/rules: delete option --parallel from dh command because it
diff -Nru qpxtool-0.7.2/debian/patches/07-fix-wr-mode-declarations.patch qpxtool-0.7.2/debian/patches/07-fix-wr-mode-declarations.patch
--- qpxtool-0.7.2/debian/patches/07-fix-wr-mode-declarations.patch	1970-01-01 01:00:00.000000000 +0100
+++ qpxtool-0.7.2/debian/patches/07-fix-wr-mode-declarations.patch	2017-02-27 14:04:53.000000000 +0100
@@ -0,0 +1,17 @@
+Description: Fix declarations of unsigned char in wr_mode
+Author: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
+Last-Update: 2017-02-27
+
+--- qpxtool-0.7.2.orig/lib/qpxtransport/include/qpx_mmc_defs.h
++++ qpxtool-0.7.2/lib/qpxtransport/include/qpx_mmc_defs.h
+@@ -581,8 +581,8 @@ static const	dev_desc _devtbl[]= {
+ #define WTYPE_LJ		4
+ 
+ typedef struct {
+-	char wtype;
+-	char dtype;
++	signed char wtype;
++	signed char dtype;
+ 	uint32_t	id;
+ 	char		name[32];
+ } wr_mode;
diff -Nru qpxtool-0.7.2/debian/patches/series qpxtool-0.7.2/debian/patches/series
--- qpxtool-0.7.2/debian/patches/series	2014-04-12 22:19:40.000000000 +0200
+++ qpxtool-0.7.2/debian/patches/series	2017-02-27 14:04:55.000000000 +0100
@@ -4,3 +4,4 @@
 04-fix-build-with-libpng15.patch
 05-add-hardening-flags-in-compiler-options.patch
 06-make-port-for-hurd-i386.patch
+07-fix-wr-mode-declarations.patch

--- End Message ---
--- Begin Message --- 
On Mon, 27 Mar 2017 14:13:33 +0200 John Paul Adrian Glaubitz
<glaubitz@physik.fu-berlin.de> wrote:
> Package: release.debian.org
> Severity: normal
> Tags: patch
> User: release.debian.org@packages.debian.org
> Usertags: unblock
> 
> Hi!
> 
> qpxtool_0.7.2-4.1 contains a small patch which fixes the
> signedness of char attributes inside the wr_mode struct.
> 
> This fixes the FTBFS of qpxtool on architectures where
> char is unsigned by default.
> 
> unblock qpxtool/0.7.2-4.1
> 
> [...]

Already migrated.

Thanks,
~Niels

--- End Message ---
Reply to: