[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#859565: marked as done (unblock: execnet/1.4.1-3.1)

Your message dated Wed, 05 Apr 2017 06:17:00 +0000
with message-id <f48466c6-b02e-ffdc-e541-064987fb23fb@thykier.net>
and subject line Re: Bug#859565: unblock: execnet/1.4.1-3.1
has caused the Debian Bug report #859565,
regarding unblock: execnet/1.4.1-3.1
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
859565: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=859565
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: unblock

Please unblock package execnet

In #854494 and #858189, Santiago Vila reported that 2 tests are often failing
in a non-deterministic way, resulting in FTBFS. As the package has been left
without any fix for nearly 2 months, and to avoid AUTORM of this package in 13
days (but more importantly for me, AUTORM of some key packages of OpenStack
like Nova), I have NMU the package removing these 2 tests.

Debdiff attached.

Please unblock execnet/1.4.1-3.1
Cheers,

Thomas Goirand (zigo)

diff -Nru execnet-1.4.1/debian/changelog execnet-1.4.1/debian/changelog
--- execnet-1.4.1/debian/changelog	2017-01-22 15:05:01.000000000 +0000
+++ execnet-1.4.1/debian/changelog	2017-04-04 20:30:05.000000000 +0000
@@ -1,3 +1,10 @@
+execnet (1.4.1-3.1) unstable; urgency=medium
+
+  * Non-maintainer upload.
+  * Disable tests that are often failing (Closes: #854494, #858189).
+
+ -- Thomas Goirand <zigo@debian.org>  Tue, 04 Apr 2017 20:30:05 +0000
+
 execnet (1.4.1-3) unstable; urgency=medium
 
   * add test_gateway-fix-race-condition.patch (Closes: #840823 [thanks
diff -Nru execnet-1.4.1/debian/patches/remove-broken-tests.patch execnet-1.4.1/debian/patches/remove-broken-tests.patch
--- execnet-1.4.1/debian/patches/remove-broken-tests.patch	1970-01-01 00:00:00.000000000 +0000
+++ execnet-1.4.1/debian/patches/remove-broken-tests.patch	2017-04-04 20:30:05.000000000 +0000
@@ -0,0 +1,58 @@
+Description: Remove broken tests
+ As per the bug reports, the 2 tests disabled by this patch are flaky,
+ and produce random FTBFS.
+Author: Thomas Goirand <zigo@debian.org>
+Bug-Debian: https://bugs.debian.org/854494
+Bug-Debian: https://bugs.debian.org/858189
+Forwarded: no
+Last-Update: 2017-04-04
+
+--- execnet-1.4.1.orig/testing/test_gateway.py
++++ execnet-1.4.1/testing/test_gateway.py
+@@ -237,20 +237,6 @@ class TestPopenGateway:
+         assert rinfo.cwd == py.std.os.getcwd()
+         assert rinfo.version_info == py.std.sys.version_info
+ 
+-    def test_waitclose_on_remote_killed(self, makegateway):
+-        gw = makegateway('popen')
+-        channel = gw.remote_exec("""
+-            import os
+-            import time
+-            channel.send(os.getpid())
+-            time.sleep(100)
+-        """)
+-        remotepid = channel.receive()
+-        py.process.kill(remotepid)
+-        py.test.raises(EOFError, "channel.waitclose(TESTTIMEOUT)")
+-        py.test.raises(IOError, channel.send, None)
+-        py.test.raises(EOFError, channel.receive)
+-
+     def test_receive_on_remote_sysexit(self, gw):
+         channel = gw.remote_exec("""
+             raise SystemExit()
+--- execnet-1.4.1.orig/testing/test_xspec.py
++++ execnet-1.4.1/testing/test_xspec.py
+@@ -118,23 +118,6 @@ class TestMakegateway:
+         assert rinfo.cwd == os.getcwd()
+         assert rinfo.version_info == sys.version_info
+ 
+-    @pytest.mark.skipif("not hasattr(os, 'nice')")
+-    def test_popen_nice(self, makegateway):
+-        gw = makegateway("popen")
+-
+-        def getnice(channel):
+-            import os
+-            if hasattr(os, 'nice'):
+-                channel.send(os.nice(0))
+-            else:
+-                channel.send(None)
+-        remotenice = gw.remote_exec(getnice).receive()
+-        gw.exit()
+-        if remotenice is not None:
+-            gw = makegateway("popen//nice=5")
+-            remotenice2 = gw.remote_exec(getnice).receive()
+-            assert remotenice2 == remotenice + 5
+-
+     def test_popen_env(self, makegateway):
+         gw = makegateway("popen//env:NAME123=123")
+         ch = gw.remote_exec("""
diff -Nru execnet-1.4.1/debian/patches/series execnet-1.4.1/debian/patches/series
--- execnet-1.4.1/debian/patches/series	2017-01-22 14:41:30.000000000 +0000
+++ execnet-1.4.1/debian/patches/series	2017-04-04 20:30:05.000000000 +0000
@@ -1,3 +1,4 @@
 test_gateway-fix-race-condition.patch
 remove-privacy-breach-google-adsense.patch
 conf.py-int-for-linkcheck_timeout.patch
+remove-broken-tests.patch

--- End Message ---
--- Begin Message --- 
Thomas Goirand:
> Package: release.debian.org
> Severity: normal
> User: release.debian.org@packages.debian.org
> Usertags: unblock
> 
> Please unblock package execnet
> 
> In #854494 and #858189, Santiago Vila reported that 2 tests are often failing
> in a non-deterministic way, resulting in FTBFS. As the package has been left
> without any fix for nearly 2 months, and to avoid AUTORM of this package in 13
> days (but more importantly for me, AUTORM of some key packages of OpenStack
> like Nova), I have NMU the package removing these 2 tests.
> 
> Debdiff attached.
> 
> Please unblock execnet/1.4.1-3.1
> Cheers,
> 
> Thomas Goirand (zigo)
> 

Unblocked, thanks.

~Niels

--- End Message ---
Reply to: