Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: unblock
Please unblock package boinc
unblock boinc/7.6.33+dfsg-11
I'm asking to unblock, mainly because of bugs: LP: #1115607, BTS: #857218, #859352
I had to do some testing for the spawn shell fix, and now it is really fixed
(I missed an use-case where users spawns them by the cmdline tool, but now it works correctly
and the patch is upstream)
diff (excluding changelog)
# fix broken symlink
--- a/debian/libboinc-app-dev.links
+++ b/debian/libboinc-app-dev.links
-usr/include/boinc/boinc_win.h usr/share/boinc-dev/lib/boinc_win.h
+usr/include/boinc/lib/boinc_win.h usr/share/boinc-dev/lib/boinc_win.h
# remove useless pie
--- a/debian/rules
+++ b/debian/rules
-export DEB_BUILD_MAINT_OPTIONS = hardening=+all,-pie
+export DEB_BUILD_MAINT_OPTIONS = hardening=+all
# fix new spawn from cmdline
--- a/clientgui/AdvancedFrame.cpp
+++ b/clientgui/AdvancedFrame.cpp
- wxGetApp().GetRootDirectory().mb_str(),
+ wxGetApp().GetDataDirectory().mb_str(),
# read current process name from arguments, to correctly spawn a new process
--- a/clientgui/BOINCGUIApp.cpp
+++ b/clientgui/BOINCGUIApp.cpp
+#else
+ char path[PATH_MAX];
+ memset(path,0,sizeof(path));
+ int ret = readlink("/proc/self/exe", path, PATH_MAX);
+ if ( ret >= 0) {
+ path[ret] = '\0'; // readlink does not null terminate
+ char* name = strrchr(path, '/') + 1;
+ m_strBOINCMGRExecutableName = name;
+ } else {
+ perror("readlink");
+ }
+#else
+ char path[PATH_MAX];
+ memset(path,0,sizeof(path));
+ int ret = readlink("/proc/self/exe", path, PATH_MAX);
+ if ( ret >= 0) {
+ path[ret] = '\0'; // readlink does not null terminate
+ char* name = strrchr(path, '/') + 1;
+ *name = '\0';
+ m_strBOINCMGRRootDirectory = path;
+ } else {
+ perror("readlink");
+ }
# add patch to patch queue
--- a/debian/patches/series
+++ b/debian/patches/series
+boinc-issue-1177.patch
the full debdiff is attached to this email, I just wanted to highlight the changes
(BTW since this has been not working for a long time, I don't foresee regression risks)
G.Attachment:
diff
Description: Binary data