[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#858915: unblock: logtool/1.2.8-9



Control: tags -1 - moreinfo
Control: retitle -1 unblock: logtool/1.2.8-10
thanks

On Thu, Mar 30, 2017 at 08:15:00PM +0000, Niels Thykier wrote:
>  1) Please undo the compat bump; it causes actions at a distance that
>     hard to reason about from a diff and as such we have it as a defacto
>     policy to reject that kind of change

Fair enough; uploaded -10 with that reverted.

>  2) src/Makefile makes an explicit reference to your build path
>     (/home).  Given it is autotools, I assume that file replaced during
>     build and therefore it will "just work(tm)".

Yes. The only reference to build path is in an explicit setting of
CFLAGS. It's not quite autotools, it uses autoconf but no automake; the
build system doesn't entirely clean up after itself, but I don't think
that's critical (the Makefile does get regenerated).

> Without the compat bump (and you signing off on the src/Makefile thing),
> I am happy to accept the change.

Thank you.

-- 
< ron> I mean, the main *practical* problem with C++, is there's like a dozen
       people in the world who think they really understand all of its rules,
       and pretty much all of them are just lying to themselves too.
 -- #debian-devel, OFTC, 2016-02-12


Reply to: