Bug#857577: unblock: dsniff/2.4b1+debian-24

[Niels Thykier <niels@thykier.net>]

Control: tags -1 moreinfo

On Sun, 12 Mar 2017 21:35:39 +0100 Marcos Fouces <mfouces@yahoo.es> wrote:
> Package: release.debian.org
> Severity: normal
> User: release.debian.org@packages.debian.org
> Usertags: unblock
> 
> Please unblock package dsniff in order to fix its five grave bugs
> 
> Dear release team,
> 

Hi,

> dsniff is to be removed from testing due to five grave bugs
> affecting several of its tools:
> 
> [...]
> 

These are fine.

> Also i would like to implement some minor changes:
> 
>  * Add -g compiler flag
> 	Avoid creating an empty dbgsym package.

I do not understand why "export CFLAGS += -g" solves this.  AFAICT, the
package is using dh in compat 10, so dh_auto_configure should set the
relevant flags before calling ./configure.



> [...]

>  * Add 33_sshcrypto_DES.patch
> 	Replacing all des_ methods and structs with DES_ equivalents.
> 	Already implemented in OpenBSD

Why is this done? The patch does not explain why this is a good idea (I
assume it is, but I am missing the "why").

>  * Polish, reorder and refresh patches.
> 	Just a cosmetic change.
> 
> Thanks for your time and effort to get release stretch!
> 
> You can see the full changes in the diff file attached.
> 
> Cheers, 
> Marcos
> 
> unblock dsniff/2.4b1+debian-24
> 
> [...]

Thanks,
~Niels