[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#856716: marked as done (unblock: systemtap/3.1-1)



Your message dated Sun, 12 Mar 2017 15:30:00 +0000
with message-id <4a0b472e-fdd6-b8fd-53b5-c26ff489b909@thykier.net>
and subject line Re: Bug#856716: unblock: systemtap/3.1-1
has caused the Debian Bug report #856716,
regarding unblock: systemtap/3.1-1
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
856716: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=856716
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message ---
Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: unblock


Dear Release Team,

This has ended up being quite late, but I request you to grant exception
for systemtap (3.1), which is currently in Experimental.

systemtap depends very closely on the Linux kernel's interfaces, which
if changed, make systemtap useless.

The current version of systemtap (3.0) in Debian Stretch is useless with
the kernel (4.9) shipped on it. Below is the stap log for a very simple
probe, that shows the interface changes.


rrs@chutzpah:~$ stap -e 'probe vfs.read {printf("read performed\n"); exit()}'In file included from /usr/share/systemtap/runtime/linux/runtime.h:209:0,
                 from /usr/share/systemtap/runtime/runtime.h:24,
                 from /tmp/stapfOCBtp/stap_a95e2c68fff3177d6a69bf2b0912f972_1531_src.c:25:
/usr/share/systemtap/runtime/linux/access_process_vm.h: In function ‘__access_process_vm_’:
/usr/share/systemtap/runtime/linux/access_process_vm.h:36:61: error: passing argument 6 of ‘get_user_pages_remote’ makes pointer from integer without a cast [-Werror=int-conversion]
       ret = get_user_pages_remote (tsk, mm, addr, 1, write, 1, &page, &vma);
                                                             ^
In file included from /usr/src/linux-headers-4.9.0-2-common/include/linux/pid_namespace.h:6:0,
                 from /usr/src/linux-headers-4.9.0-2-common/include/linux/ptrace.h:8,
                 from /usr/src/linux-headers-4.9.0-2-common/include/linux/ftrace.h:13,
                 from /usr/src/linux-headers-4.9.0-2-common/include/linux/kprobes.h:42,
                 from /usr/share/systemtap/runtime/linux/runtime.h:21,
                 from /usr/share/systemtap/runtime/runtime.h:24,
                 from /tmp/stapfOCBtp/stap_a95e2c68fff3177d6a69bf2b0912f972_1531_src.c:25:
/usr/src/linux-headers-4.9.0-2-common/include/linux/mm.h:1298:6: note: expected ‘struct page **’ but argument is of type ‘int’
 long get_user_pages_remote(struct task_struct *tsk, struct mm_struct *mm,
      ^~~~~~~~~~~~~~~~~~~~~
In file included from /usr/share/systemtap/runtime/linux/runtime.h:209:0,
                 from /usr/share/systemtap/runtime/runtime.h:24,
                 from /tmp/stapfOCBtp/stap_a95e2c68fff3177d6a69bf2b0912f972_1531_src.c:25:
/usr/share/systemtap/runtime/linux/access_process_vm.h:36:64: error: passing argument 7 of ‘get_user_pages_remote’ from incompatible pointer type [-Werror=incompatible-pointer-types]
/usr/share/systemtap/runtime/linux/access_process_vm.h:36:64: error: passing argument 7 of ‘get_user_pages_remote’ from incompatible pointer type [-Werror=incompatible-pointer-types]
       ret = get_user_pages_remote (tsk, mm, addr, 1, write, 1, &page, &vma);
                                                                ^
                                                                ^
In file included from /usr/src/linux-headers-4.9.0-2-common/include/linux/pid_namespace.h:6:0,
                 from /usr/src/linux-headers-4.9.0-2-common/include/linux/ptrace.h:8,
                 from /usr/src/linux-headers-4.9.0-2-common/include/linux/ftrace.h:13,
                 from /usr/src/linux-headers-4.9.0-2-common/include/linux/kprobes.h:42,
                 from /usr/share/systemtap/runtime/linux/runtime.h:21,
                 from /usr/share/systemtap/runtime/runtime.h:24,
                 from /tmp/stapfOCBtp/stap_a95e2c68fff3177d6a69bf2b0912f972_1531_src.c:25:
/usr/src/linux-headers-4.9.0-2-common/include/linux/mm.h:1298:6: note: expected ‘struct vm_area_struct **’ but argument is of type ‘struct page **’
 long get_user_pages_remote(struct task_struct *tsk, struct mm_struct *mm,
      ^~~~~~~~~~~~~~~~~~~~~
In file included from /usr/share/systemtap/runtime/linux/runtime.h:209:0,
                 from /usr/share/systemtap/runtime/runtime.h:24,
                 from /tmp/stapfOCBtp/stap_a95e2c68fff3177d6a69bf2b0912f972_1531_src.c:25:
/usr/share/systemtap/runtime/linux/access_process_vm.h:36:13: error: too many arguments to function ‘get_user_pages_remote’
       ret = get_user_pages_remote (tsk, mm, addr, 1, write, 1, &page, &vma);
             ^~~~~~~~~~~~~~~~~~~~~
In file included from /usr/src/linux-headers-4.9.0-2-common/include/linux/pid_namespace.h:6:0,
                 from /usr/src/linux-headers-4.9.0-2-common/include/linux/ptrace.h:8,
                 from /usr/src/linux-headers-4.9.0-2-common/include/linux/ftrace.h:13,
                 from /usr/src/linux-headers-4.9.0-2-common/include/linux/kprobes.h:42,
                 from /usr/share/systemtap/runtime/linux/runtime.h:21,
                 from /usr/share/systemtap/runtime/runtime.h:24,
                 from /tmp/stapfOCBtp/stap_a95e2c68fff3177d6a69bf2b0912f972_1531_src.c:25:
/usr/src/linux-headers-4.9.0-2-common/include/linux/mm.h:1298:6: note: declared here
 long get_user_pages_remote(struct task_struct *tsk, struct mm_struct *mm,
      ^~~~~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors
/usr/src/linux-headers-4.9.0-2-common/scripts/Makefile.build:298: recipe for target '/tmp/stapfOCBtp/stap_a95e2c68fff3177d6a69bf2b0912f972_1531_src.o' failed
make[3]: *** [/tmp/stapfOCBtp/stap_a95e2c68fff3177d6a69bf2b0912f972_1531_src.o] Error 1
/usr/src/linux-headers-4.9.0-2-common/Makefile:1507: recipe for target '_module_/tmp/stapfOCBtp' failed
make[2]: *** [_module_/tmp/stapfOCBtp] Error 2
Makefile:150: recipe for target 'sub-make' failed
make[1]: *** [sub-make] Error 2
Makefile:8: recipe for target 'all' failed
make: *** [all] Error 2
WARNING: kbuild exited with status: 2
Pass 4: compilation failed.  [man error::pass4]
Tip: /usr/share/doc/systemtap/README.Debian should help you get started.
15:00 ♒♒♒    ☹  => 1  



These issues are all fixed in the 3.1 release of systemtap, currently
accessible through Debian Experimental.


rrs@chutzpah:/var/tmp/Debian-Build/Result$ stap -e 'probe vfs.read {printf("read performed\n"); exit()}'
read performed
15:10 ♒♒♒   ☺    

rrs@chutzpah:/var/tmp/Debian-Build/Result$ dpkg -l | grep systemtap
ii  systemtap                                 3.1-2                                amd64        instrumentation system for Linux
ii  systemtap-common                          3.1-2                                all          instrumentation system for Linux (common component)
ii  systemtap-doc                             3.1-2                                all          documentation and examples for SystemTap
ii  systemtap-runtime                         3.1-2                                amd64        instrumentation system for Linux (runtime component)
15:10 ♒♒♒   ☺    

This bug report is in regard to asking for an exception for systemtap,
to allow a new release, at this time during freeze.

Please let me know, in this bug report, if it is okay. And accordingly,
then, I will push it to the Unstable archive.


-- System Information:
Debian Release: 9.0
  APT prefers unstable-debug
  APT policy: (990, 'unstable-debug'), (990, 'testing-debug'), (990, 'unstable'), (990, 'testing'), (101, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.10.1+ (SMP w/4 CPU cores)
Locale: LANG=en_IN.utf8, LC_CTYPE=en_IN.utf8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

--- End Message ---
--- Begin Message ---
Ritesh Raj Sarraf:
> Package: release.debian.org
> Severity: normal
> User: release.debian.org@packages.debian.org
> Usertags: unblock
> 
> 
> Dear Release Team,
> 
> This has ended up being quite late, but I request you to grant exception
> for systemtap (3.1), which is currently in Experimental.
> 
> systemtap depends very closely on the Linux kernel's interfaces, which
> if changed, make systemtap useless.
> 
> The current version of systemtap (3.0) in Debian Stretch is useless with
> the kernel (4.9) shipped on it. Below is the stap log for a very simple
> probe, that shows the interface changes.
> 
> [...]
> 

Unblocked, thanks.

~Niels

--- End Message ---

Reply to: