Bug#857400: unblock: python-bleach/2.0
Control: tags -1 confirmed moreinfo
On 10/03/17 20:49, Scott Kitterman wrote:
> Package: release.debian.org
> Severity: normal
> User: release.debian.org@packages.debian.org
> Usertags: unblock
>
> Please unblock package python-bleach
>
> python-bleach in testing is currently totally broken due to an uncoordinated
> pre-freeze (by a little bit) html5lib update. Unfortunately, that update
> contained substantial API changes. Upstream for python-bleach has just
> released a new version that is compatible with our html5lib version.
>
> It's (as you will see) a large diff. Realistically, I think we have only two
> choices; either remove the package from stretch or update to the new version.
> Any attempt to adapt the version we have in stretch to the new html5lib would
> be substantially as much change done by people less familiar with the code
> base. I don't see a middle, patch the old version, option that's at all
> realistic.
>
> I have not yet uploaded to Unstable because I'd like to get feedback from the
> release team first. My proposed debdiff is not strictly the minimal changes
> needed to resolve the RC bug. I'm also including packaging updates so the
> tests will still run and an agreed maintainer change.
>
> Either of those could, strictly speaking, be skipped and I could do this as an
> NMU, but I think changing the maintainer to DPMT will be better in case issues
> come up in stretch.
>
> The attached debdiff, modulo and UNRELEASED/unstable is what I propose
> uploading. I've attached the packaging diff separately for easier reviewing.
>
> Please let me know how you would like to approach this package.
I think you forgot to attach the upstream diff.
I have taken a look and while large, I think given the situation it's better to
accept this. There's only one rdep so the risk is low, particularly if the other
option you're considering is to remove this altogether. We can always do that
later if the update turns out to be a disaster.
FWIW I think the relevant diff is:
emilio@tatooine:~/tmp/tarballs$ diff python-bleach-1.4.2/bleach/
bleach-2.0/bleach/ | filterdiff -x '*tests/*' | diffstat
__init__.py | 459 +++++++++++----------------------------------------
callbacks.py | 19 +-
linkifier.py | 526 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
sanitizer.py | 415 +++++++++++++++++++++++++++++++++++-----------
utils.py | 23 ++
version.py | 6
6 files changed, 985 insertions(+), 463 deletions(-)
Have you tested the one rdep, django-html-sanitizer? If so, go ahead and remove
the moreinfo tag once this is accepted.
Cheers,
Emilio
Reply to: