[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#856684: marked as done (unblock: varnish/5.0.0-7)

Your message dated Sat, 04 Mar 2017 07:22:00 +0000
with message-id <31de6275-c55e-5f20-65cc-a55a41e6b1e5@thykier.net>
and subject line Re: Bug#856684: unblock: varnish/5.0.0-7
has caused the Debian Bug report #856684,
regarding unblock: varnish/5.0.0-7
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
856684: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=856684
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: unblock

Please unblock package varnish

The varnish package includes a script to reload the VCL set in
/etc/default/varnish, which the systemd unit does not use.  Running
"systemctl reload varnish" might not work at all, or load the wrong
configuration.  This version fixes this problem by dropping the
"reload" action from the systemd unit.

diff -Nru varnish-5.0.0/debian/changelog varnish-5.0.0/debian/changelog
--- varnish-5.0.0/debian/changelog	2016-12-20 22:04:01.000000000 +0100
+++ varnish-5.0.0/debian/changelog	2017-03-02 18:16:05.000000000 +0100
@@ -1,3 +1,9 @@
+varnish (5.0.0-7) unstable; urgency=medium
+
+  * Remove reload from varnish.service (Closes: #749272)
+
+ -- Stig Sandbeck Mathisen <ssm@debian.org>  Thu, 02 Mar 2017 18:16:05 +0100
+
 varnish (5.0.0-6) unstable; urgency=medium
 
   * Update reload-vcl for varnish 5.x
diff -Nru varnish-5.0.0/debian/tests/spec/varnish/use_spec.rb varnish-5.0.0/debian/tests/spec/varnish/use_spec.rb
--- varnish-5.0.0/debian/tests/spec/varnish/use_spec.rb	2016-12-20 22:04:01.000000000 +0100
+++ varnish-5.0.0/debian/tests/spec/varnish/use_spec.rb	2017-03-02 18:16:05.000000000 +0100
@@ -23,7 +23,7 @@
 end
 
 describe command('systemctl reload varnish') do
-  its(:exit_status) { should eq 0 }
-  its(:stderr) { should eq '' }
+  its(:exit_status) { should eq 3 }
+  its(:stderr) { is_expected.to include('Job type reload is not applicable for unit varnish.service.') }
   its(:stdout) { should eq('') }
 end
diff -Nru varnish-5.0.0/debian/varnish.service varnish-5.0.0/debian/varnish.service
--- varnish-5.0.0/debian/varnish.service	2016-12-20 22:04:01.000000000 +0100
+++ varnish-5.0.0/debian/varnish.service	2017-03-02 18:16:05.000000000 +0100
@@ -7,7 +7,6 @@
 LimitNOFILE=131072
 LimitMEMLOCK=82000
 ExecStart=/usr/sbin/varnishd -j unix,user=vcache -F -a :6081 -T localhost:6082 -f /etc/varnish/default.vcl -S /etc/varnish/secret -s malloc,256m
-ExecReload=/usr/share/varnish/reload-vcl
 ProtectSystem=full
 ProtectHome=true
 PrivateTmp=true

unblock varnish/5.0.0-7

-- System Information:
Debian Release: 9.0
  APT prefers stable-updates
  APT policy: (500, 'stable-updates'), (500, 'testing'), (500, 'stable'), (98, 'unstable')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.9.0-1-amd64 (SMP w/8 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

--- End Message ---
--- Begin Message --- 
Stig Sandbeck Mathisen:
> Package: release.debian.org
> Severity: normal
> User: release.debian.org@packages.debian.org
> Usertags: unblock
> 
> Please unblock package varnish
> 
> The varnish package includes a script to reload the VCL set in
> /etc/default/varnish, which the systemd unit does not use.  Running
> "systemctl reload varnish" might not work at all, or load the wrong
> configuration.  This version fixes this problem by dropping the
> "reload" action from the systemd unit.
> 
> [...]
> 
> unblock varnish/5.0.0-7
> 
> [...]
> 

Unblocked, thanks.

~Niels

--- End Message ---
Reply to: