[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#856608: marked as done (unblock: libcolor-library-perl/0.021-3)

Your message dated Thu, 02 Mar 2017 22:12:38 +0000
with message-id <E1cjYxi-00008S-MY@respighi.debian.org>
and subject line unblock libcolor-library-perl
has caused the Debian Bug report #856608,
regarding unblock: libcolor-library-perl/0.021-3
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
856608: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=856608
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: unblock

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

unblock libcolor-library-perl/0.021-3


Please unblock package libcolor-library-perl, version 0.021-3.

This upload fixes #856562: "libcolor-library-perl: debian patch breaks some package
functionality".

The only change is a fix to debian/patches/pod-fixes.patch; the
previous "fix" for the documentation unfortunately effectively
disabled a method of the class by including it in the documentation.
The fixed version moves the "=back" directives to the right place.

Full debdiff attached.


Thanks in advance,
gregor

-----BEGIN PGP SIGNATURE-----

iQKTBAEBCgB9FiEE0eExbpOnYKgQTYX6uzpoAYZJqgYFAli4le5fFIAAAAAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEQx
RTEzMTZFOTNBNzYwQTgxMDREODVGQUJCM0E2ODAxODY0OUFBMDYACgkQuzpoAYZJ
qgYaTA//X2VPmlUzNnhltrh3ru2yqYw7TDF+/14KNY7gJfh7EyOW8lGiNjkUA5mB
cGtgyl8aV4xau2MrxO8bLyu1h9l5CQ1DXUXwDGylBi5clwJ4qx61S1Pjv347+anm
UXr4lkgacMujGneo9TbkGJnqQMglgxDevFHXgMvNzrsSUDb+cU7eu+hF5PmPttDa
bYLSECoYW43pJfbLRDBL8F7+cBag0W8i5SO0VZEeTIGwXLXpaIyvljbvx8uIbSnk
sBHVM1LbFGrIxm7bfhKWHDiznExdREyJ2P/qI9sTfZ0YzVsjI5Ko47GYdMQ6NwkN
XNjdLUKhivv9Fse2efU11EwO9JsUr3eoLg9EgegHyT6QGnVcNCnclvtFMUJ8lEUV
RSTNyL657m3wXxi8lGqqERkfcNRnzt9EO0LYyhiCgsIDVQT1q9N64M/w5EhtdqaN
jvf8hfbOt+GXO29QoiGVTRdo+i9qjFl+uVykB3UDBLm58t9+pZqzGMAgnnmt15t8
8mSc/ihwkcLvhiFG8WgPIz1d5U5GFaQ0vdEXHdgeXPMa5U+WOk8cMIZGMhO6qED2
e+HdAF2mGWoEfy7fIq+SATKtqIasj1NLDdFMXXM1HWWmrhXI3hmo2cQ/Bs4lkRO/
iKDAdxff4Cm1+OR+cIaF7eGPdp5LGb+EG2xZuH460Os0ERNnnbk=
=Cr6y
-----END PGP SIGNATURE-----

diff -Nru libcolor-library-perl-0.021/debian/changelog libcolor-library-perl-0.021/debian/changelog
--- libcolor-library-perl-0.021/debian/changelog	2013-06-11 23:39:48.000000000 +0200
+++ libcolor-library-perl-0.021/debian/changelog	2017-03-02 22:50:05.000000000 +0100
@@ -1,3 +1,14 @@
+libcolor-library-perl (0.021-3) unstable; urgency=medium
+
+  * Update debian/patches/pod-fixes.patch.
+    Put the missing closing "=back" directives for the item lists in the right
+    places. The previous version not only showed code in the POD but more
+    importantly effectively masked the parse_rgb_color() method.
+    Thanks to Jeff Norden for the bug report and the patch.
+    (Closes: #856562)
+
+ -- gregor herrmann <gregoa@debian.org>  Thu, 02 Mar 2017 22:50:05 +0100
+
 libcolor-library-perl (0.021-2) unstable; urgency=low
 
   [ Salvatore Bonaccorso ]
diff -Nru libcolor-library-perl-0.021/debian/patches/pod-fixes.patch libcolor-library-perl-0.021/debian/patches/pod-fixes.patch
--- libcolor-library-perl-0.021/debian/patches/pod-fixes.patch	2013-06-11 23:39:48.000000000 +0200
+++ libcolor-library-perl-0.021/debian/patches/pod-fixes.patch	2017-03-02 22:50:05.000000000 +0100
@@ -3,19 +3,37 @@
 Bug: https://rt.cpan.org/Ticket/Display.html?id=86023
 Forwarded: https://rt.cpan.org/Ticket/Display.html?id=86023
 Author: gregor herrmann <gregoa@debian.org>
-Last-Update: 2013-06-09
+Last-Update: 2017-03-02
 
 --- a/lib/Color/Library/Color.pm
 +++ b/lib/Color/Library/Color.pm
-@@ -227,6 +227,8 @@
+@@ -134,6 +134,8 @@
+ 
+ You probably don't want/need to call this yourself
  
++=back
++
  =cut
  
+ # FUTURE Note that $value may be a numeric value, a hex value, or a 3 element r-g-b array
+@@ -168,8 +170,6 @@
+     return $self;
+ }
+ 
+-=back
+-
+ =head2 FUNCTIONS
+ 
+ =over 4
+@@ -225,6 +225,8 @@
+ 
+ Makes a best effort to convert a hex or numeric color value to its rgb representation
+ 
 +=back
 +
+ =cut
+ 
  # Partly taken from Imager/Color.pm
- sub parse_rgb_color {
-     return (@_) if @_ == 3 && ! grep /[^\d.+eE-]/, @_;
 --- a/lib/Color/Library/Dictionary.pm
 +++ b/lib/Color/Library/Dictionary.pm
 @@ -227,6 +227,8 @@

--- End Message ---
--- Begin Message --- 
Unblocked libcolor-library-perl.

--- End Message ---
Reply to: