[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#856327: marked as done (unblock: gexiv2/0.10.4-2)

Your message dated Tue, 28 Feb 2017 17:18:58 +0000
with message-id <E1cilQQ-0007wJ-Vi@respighi.debian.org>
and subject line unblock gexiv2
has caused the Debian Bug report #856327,
regarding unblock: gexiv2/0.10.4-2
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
856327: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=856327
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: unblock

Please unblock package gexiv2

The unstable version adds a patch that fixes an assertion.  The current testing
version can abort when processing certian images from Minolta cameras, and
cause shotwell to crash.

Debian bug: https://bugs.debian.org/856101
Gnome bug: https://bugzilla.gnome.org/776233
RedHat bug: https://bugzilla.redhat.com/1401706

debdiff is attached

unblock gexiv2/0.10.4-2

-- System Information:
Debian Release: 9.0
  APT prefers testing
  APT policy: (9000, 'testing')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.9.0-1-amd64 (SMP w/2 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

diff -Nru gexiv2-0.10.4/debian/changelog gexiv2-0.10.4/debian/changelog
--- gexiv2-0.10.4/debian/changelog	2016-10-06 09:39:18.000000000 -0500
+++ gexiv2-0.10.4/debian/changelog	2017-02-26 05:16:34.000000000 -0600
@@ -1,3 +1,11 @@
+gexiv2 (0.10.4-2) unstable; urgency=medium
+
+  * Add patch 0004-get_orientation-Fix-abort-on-Minolta-meta-data.patch.
+    Fixes an assertion when processing metadata from a not-rotated image
+    from Minolta cameras. (Closes: #856101)
+
+ -- Jason Crain <jason@inspiresomeone.us>  Sun, 26 Feb 2017 05:16:34 -0600
+
 gexiv2 (0.10.4-1) unstable; urgency=medium
 
   * New upstream version 0.10.4
diff -Nru gexiv2-0.10.4/debian/patches/0004-get_orientation-Fix-abort-on-Minolta-meta-data.patch gexiv2-0.10.4/debian/patches/0004-get_orientation-Fix-abort-on-Minolta-meta-data.patch
--- gexiv2-0.10.4/debian/patches/0004-get_orientation-Fix-abort-on-Minolta-meta-data.patch	1969-12-31 18:00:00.000000000 -0600
+++ gexiv2-0.10.4/debian/patches/0004-get_orientation-Fix-abort-on-Minolta-meta-data.patch	2017-02-26 05:16:34.000000000 -0600
@@ -0,0 +1,57 @@
+From: Jens Georg <mail@jensge.org>
+Date: Sun, 18 Dec 2016 17:02:42 +0100
+Subject: get_orientation: Fix abort on Minolta meta-data
+
+Properly handle rotation value 72 (not rotated)
+
+Origin: upstream, https://git.gnome.org/browse/gexiv2/commit/?id=6810c92d7b2978f97ac9750ddf8a6a62b44be4cc
+Bug: https://bugzilla.gnome.org/776233
+Bug-Redhat: https://bugzilla.redhat.com/1401706
+Bug-Debian: https://bugs.debian.org/856101
+Last-Update: 2017-02-23
+---
+ gexiv2/gexiv2-metadata.cpp | 17 +++++++++++------
+ 1 file changed, 11 insertions(+), 6 deletions(-)
+
+diff --git a/gexiv2/gexiv2-metadata.cpp b/gexiv2/gexiv2-metadata.cpp
+index 8aa4d45..7d1be08 100644
+--- a/gexiv2/gexiv2-metadata.cpp
++++ b/gexiv2/gexiv2-metadata.cpp
+@@ -395,26 +395,31 @@ GExiv2Orientation gexiv2_metadata_get_orientation (GExiv2Metadata *self) {
+         // Because some camera set a wrong standard exif orientation tag,
+         // We need to check makernote tags first!
+         if (gexiv2_metadata_has_exif_tag(self, "Exif.MinoltaCs7D.Rotation")) {
+-            switch (gexiv2_metadata_get_exif_tag_long(self, "Exif.MinoltaCs7D.Rotation")) {
++            long orientation = gexiv2_metadata_get_exif_tag_long(self, "Exif.MinoltaCs7D.Rotation");
++            switch (orientation) {
+                 case 76:
+                     return GEXIV2_ORIENTATION_ROT_90;
+-                
+                 case 82:
+                     return GEXIV2_ORIENTATION_ROT_270;
++                case 72:
++                    return GEXIV2_ORIENTATION_UNSPECIFIED;
+                 default:
+-                    g_assert_not_reached();
++                    g_debug ("Unknown Minolta rotation value %ld, ignoring", orientation);
+             }
+         }
+-        
++
+         if (gexiv2_metadata_has_exif_tag(self, "Exif.MinoltaCs5D.Rotation")) {
+-            switch (gexiv2_metadata_get_exif_tag_long(self, "Exif.MinoltaCs5D.Rotation")) {
++            long orientation = gexiv2_metadata_get_exif_tag_long(self, "Exif.MinoltaCs5D.Rotation");
++            switch (orientation) {
+                 case 76:
+                     return GEXIV2_ORIENTATION_ROT_90;
+                 
+                 case 82:
+                     return GEXIV2_ORIENTATION_ROT_270;
++                case 72:
++                    return GEXIV2_ORIENTATION_UNSPECIFIED;
+                 default:
+-                    g_assert_not_reached();
++                    g_debug ("Unknown Minolta rotation value %ld, ignoring", orientation);
+             }
+         }
+         
diff -Nru gexiv2-0.10.4/debian/patches/series gexiv2-0.10.4/debian/patches/series
--- gexiv2-0.10.4/debian/patches/series	2016-10-06 09:39:18.000000000 -0500
+++ gexiv2-0.10.4/debian/patches/series	2017-02-26 05:16:34.000000000 -0600
@@ -1,3 +1,4 @@
 exiv2_pc.patch
 fix-typelib-install-directory.patch
 always-install-vapi-file.patch
+0004-get_orientation-Fix-abort-on-Minolta-meta-data.patch

--- End Message ---
--- Begin Message --- 
Unblocked.

--- End Message ---
Reply to: