[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#855867: marked as done (unblock: mongrel2/1.11.0-6)

Your message dated Wed, 22 Feb 2017 20:40:00 +0000
with message-id <d5bc0f83-a7d7-574c-d0a5-685a6a5cbc12@thykier.net>
and subject line Re: Bug#855867: unblock: mongrel2/1.11.0-6
has caused the Debian Bug report #855867,
regarding unblock: mongrel2/1.11.0-6
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
855867: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=855867
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: unblock

Please unblock package mongrel2

The package contains a one-line fix for a bug which causes
mongrel2 to stop working after it received two HUP signals.

In earlier versions of mongrel2, reload_task() called reload_server(),
which sets RELOAD to 0. When the call to reload_server() was removed,
setting RELOAD was forgotten.

This is a trivial (identical) backport of the upstream fix available at
https://github.com/mongrel2/mongrel2/commit/1b788752f287aedd2a837e7304284f128957dd16

diff -Nru mongrel2-1.11.0/debian/changelog mongrel2-1.11.0/debian/changelog
--- mongrel2-1.11.0/debian/changelog	2016-12-21 17:54:59.000000000 +0100
+++ mongrel2-1.11.0/debian/changelog	2017-02-22 12:14:48.000000000 +0100
@@ -1,3 +1,12 @@
+mongrel2 (1.11.0-6) unstable; urgency=medium
+
+  * Cherry-pick upstream patch.
+    One can send HUP signals to mongrel2 to make it reopen the log
+    files. Due to a bug, after receiving two such signals, mongrel2
+    stopped working. This bug is fixed by the patch.
+
+ -- Jan Niehusmann <jan@debian.org>  Wed, 22 Feb 2017 12:14:48 +0100
+
 mongrel2 (1.11.0-5) unstable; urgency=medium
 
   * Sort output of $(wildcard ...) in subdirectory Makefiles
diff -Nru mongrel2-1.11.0/debian/patches/debian-changes mongrel2-1.11.0/debian/patches/debian-changes
--- mongrel2-1.11.0/debian/patches/debian-changes	2016-12-21 17:54:59.000000000 +0100
+++ mongrel2-1.11.0/debian/patches/debian-changes	2017-02-22 12:14:48.000000000 +0100
@@ -227,6 +227,16 @@
  #else
  #define IOBuf_sendfile sendfile
  #endif
+--- mongrel2-1.11.0.orig/src/mongrel2.c
++++ mongrel2-1.11.0/src/mongrel2.c
+@@ -382,6 +382,7 @@ void reload_task(void *data)
+             if(rotate_logs()) {
+                 log_err("Error rotating logs!");
+             }
++            RELOAD = 0;
+         } else {
+             log_info("Shutdown requested, goodbye.");
+             break;
 --- mongrel2-1.11.0.orig/src/task/context.c
 +++ mongrel2-1.11.0/src/task/context.c
 @@ -94,4 +94,3 @@ int swapcontext(ucontext_t *oucp, const

unblock mongrel2/1.11.0-6

--- End Message ---
--- Begin Message --- 
Jan Niehusmann:
> Package: release.debian.org
> Severity: normal
> User: release.debian.org@packages.debian.org
> Usertags: unblock
> 
> Please unblock package mongrel2
> 
> The package contains a one-line fix for a bug which causes
> mongrel2 to stop working after it received two HUP signals.
> 
> In earlier versions of mongrel2, reload_task() called reload_server(),
> which sets RELOAD to 0. When the call to reload_server() was removed,
> setting RELOAD was forgotten.
> 
> This is a trivial (identical) backport of the upstream fix available at
> https://github.com/mongrel2/mongrel2/commit/1b788752f287aedd2a837e7304284f128957dd16
> 
> [...]
> 
> unblock mongrel2/1.11.0-6
> 

Unblocked, thanks.

~Niels

--- End Message ---
Reply to: