[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#854981: unblock: le-dico-de-rene-cougnenc/1.3-2.3



Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: unblock

Please unblock package le-dico-de-rene-cougnenc

dico in testing segfaults immediately upon startup, which was
reported as #852659.

This upload fixes the crash by avoiding undefined behaviour by
moving an increment from an assignment to a separate line.

Also current -dbgsym packages contain no line number information.
Therefore in the Makefile the option -g is added to gcc.


bernhard@rechner:/tmp/dico$ debdiff le-dico-de-rene-cougnenc_1.3-2.2.dsc le-
dico-de-rene-cougnenc_1.3-2.3.dsc
diff -u le-dico-de-rene-cougnenc-1.3/debian/changelog le-dico-de-rene-
cougnenc-1.3/debian/changelog
--- le-dico-de-rene-cougnenc-1.3/debian/changelog
+++ le-dico-de-rene-cougnenc-1.3/debian/changelog
@@ -1,3 +1,11 @@
+le-dico-de-rene-cougnenc (1.3-2.3) unstable; urgency=medium
+
+  * Non-maintainer upload.
+  * Build with debug info to make dbgsym package usable.
+  * Avoid segfault by undefined behaviour. (Closes: #852659)
+
+ -- Bernhard Übelacker <bernhardu@mailbox.org>  Wed, 08 Feb 2017 22:03:54
+0100
+
 le-dico-de-rene-cougnenc (1.3-2.2) unstable; urgency=medium

   * Non-maintainer upload.
diff -u le-dico-de-rene-cougnenc-1.3/src/dico.c le-dico-de-rene-
cougnenc-1.3/src/dico.c
--- le-dico-de-rene-cougnenc-1.3/src/dico.c
+++ le-dico-de-rene-cougnenc-1.3/src/dico.c
@@ -1040,7 +1040,8 @@

     while (*str)
     {
-               *str = EquivalTable[ *str++ ] ;
+               *str = EquivalTable[ *str ] ;
+               str++;
     }

  return p ;
only in patch2:
unchanged:
--- le-dico-de-rene-cougnenc-1.3.orig/src/Makefile
+++ le-dico-de-rene-cougnenc-1.3/src/Makefile
@@ -2,8 +2,8 @@
 prefix = /usr

 dico: dico.c killposte.c
-       gcc dico.c -o dico
-       gcc killposte.c -o killposte
+       gcc -g dico.c -o dico
+       gcc -g killposte.c -o killposte

 clean:
        rm -fr *~ dico killposte *.1 manpage.links manpage.refs


unblock le-dico-de-rene-cougnenc/1.3-2.3

-- System Information:
Debian Release: 9.0
  APT prefers testing-debug
  APT policy: (500, 'testing-debug'), (500, 'testing')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.9.0-1-amd64 (SMP w/2 CPU cores)
Locale: LANG=de_DE.UTF-8, LC_CTYPE=de_DE.UTF-8 (charmap=UTF-8)

Reply to: