Bug#854812: jessie-pu: package gnome-settings-daemon/3.14.2-3
Package: release.debian.org
Severity: normal
Tags: jessie
User: release.debian.org@packages.debian.org
Usertags: pu
If taking a screenshot by pressing the PrintScr key the image file will be
stored in the pictures directory with a filename containing the current
timestamp with colons (i.e. "Screenshot from 2017-01-10 16:46:39.png").
This leads to problems with some filesystems (e.g. vfat, ntfs).
This was also already reported upstream in
https://bugzilla.gnome.org/show_bug.cgi?id=740520.
gnome-settings-daemon 3.22.1-1, the version currently in testing already
contains this fix from upstream (i.e. "Screenshot from 2017-01-10
16-46-39.png").
See package bug #850837 (https://bugs.debian.org/cgi-
bin/bugreport.cgi?bug=850837)
I have imported the upstream patch to debian/patches, updated the
changelog, built the package, tested it and attached the debdiff here
(and FWIW uploaded it to
https://mentors.debian.net/package/gnome-settings-daemon).
-- System Information:
Debian Release: 8.7
APT prefers stable-updates
APT policy: (700, 'stable-updates'), (700, 'stable'), (60, 'testing')
Architecture: amd64 (x86_64)
Kernel: Linux 3.16.0-4-amd64 (SMP w/8 CPU cores)
Locale: LANG=en_US.utf8, LC_CTYPE=en_US.utf8 (charmap=UTF-8)
diff -Nru gnome-settings-daemon-3.14.2/debian/changelog gnome-settings-daemon-3.14.2/debian/changelog
--- gnome-settings-daemon-3.14.2/debian/changelog 2015-03-13 22:36:01.000000000 +0100
+++ gnome-settings-daemon-3.14.2/debian/changelog 2017-02-08 10:31:32.000000000 +0100
@@ -1,3 +1,15 @@
+gnome-settings-daemon (3.14.2-3.1) UNRELEASED; urgency=medium
+
+ * Non-maintainer upload.
+ * screenshot-utils-dont-use-spaces-or-colons-in-file.patch:
+ Patch from upstream: https://bugzilla.gnome.org/show_bug.cgi?id=740520
+ Screenshots are often uploaded to web services or copied to (possibly
+ FAT) external drives.
+ Don't use characters that would be incompatible with those.
+ (Closes: #850837)
+
+ -- Moritz Schlarb <schlarbm@uni-mainz.de> Wed, 08 Feb 2017 10:19:30 +0100
+
gnome-settings-daemon (3.14.2-3) unstable; urgency=medium
* Team upload
diff -Nru gnome-settings-daemon-3.14.2/debian/patches/screenshot-utils-dont-use-spaces-or-colons-in-file.patch gnome-settings-daemon-3.14.2/debian/patches/screenshot-utils-dont-use-spaces-or-colons-in-file.patch
--- gnome-settings-daemon-3.14.2/debian/patches/screenshot-utils-dont-use-spaces-or-colons-in-file.patch 1970-01-01 01:00:00.000000000 +0100
+++ gnome-settings-daemon-3.14.2/debian/patches/screenshot-utils-dont-use-spaces-or-colons-in-file.patch 2017-02-08 10:14:59.000000000 +0100
@@ -0,0 +1,30 @@
+From 345001ae99b84dbcbeccc86e19d8efee20fec8b0 Mon Sep 17 00:00:00 2001
+From: Cosimo Cecchi <cosimoc@gnome.org>
+Date: Fri, 21 Nov 2014 17:47:23 -0800
+Subject: [PATCH] screenshot-utils: don't use spaces or colons in filenames
+
+Screenshots are often uploaded to web services or copied to (possibly
+FAT) external drives.
+Don't use characters that would be incompatible with those.
+See https://bugzilla.gnome.org/show_bug.cgi?id=698740
+
+https://bugzilla.gnome.org/show_bug.cgi?id=740520
+---
+ plugins/media-keys/gsd-screenshot-utils.c | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/plugins/media-keys/gsd-screenshot-utils.c b/plugins/media-keys/gsd-screenshot-utils.c
+index c59ee63..242115f 100644
+--- a/plugins/media-keys/gsd-screenshot-utils.c
++++ b/plugins/media-keys/gsd-screenshot-utils.c
+@@ -296,7 +296,7 @@ screenshot_build_filename (void)
+ GDateTime *d;
+
+ d = g_date_time_new_now_local ();
+- origin = g_date_time_format (d, "%Y-%m-%d %H:%M:%S");
++ origin = g_date_time_format (d, "%Y-%m-%d %H-%M-%S");
+ g_date_time_unref (d);
+
+ /* translators: this is the name of the file that gets made up
+--
+2.1.0
\ No newline at end of file
diff -Nru gnome-settings-daemon-3.14.2/debian/patches/series gnome-settings-daemon-3.14.2/debian/patches/series
--- gnome-settings-daemon-3.14.2/debian/patches/series 2015-03-09 10:49:15.000000000 +0100
+++ gnome-settings-daemon-3.14.2/debian/patches/series 2017-02-08 10:14:59.000000000 +0100
@@ -2,3 +2,4 @@
04_superP.patch
30_xrandr_dbus_init.patch
power-make-sure-to-set-an-error-when-GDBus-set_prope.patch
+screenshot-utils-dont-use-spaces-or-colons-in-file.patch
Reply to: