Bug#854379: marked as done (unblock: sssd/1.15.0-3)

To: Julien Cristau <jcristau@debian.org>
Subject: Bug#854379: marked as done (unblock: sssd/1.15.0-3)
From: owner@bugs.debian.org (Debian Bug Tracking System)
Date: Mon, 06 Feb 2017 19:33:07 +0000
Message-id: <[🔎] handler.854379.D854379.148640945814217.ackdone@bugs.debian.org>
References: <20170206193053.75lkiphmp72qkf2s@betterave.cristau.org> <[🔎] 148638872229.2649.2335436274587687197.reportbug@deckard.tyrell>

Your message dated Mon, 6 Feb 2017 20:30:53 +0100
with message-id <20170206193053.75lkiphmp72qkf2s@betterave.cristau.org>
and subject line Re: Bug#854379: unblock: sssd/1.15.0-3
has caused the Debian Bug report #854379,
regarding unblock: sssd/1.15.0-3
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
854379: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=854379
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems

--- Begin Message ---

To: Debian Bug Tracking System <submit@bugs.debian.org>
Subject: unblock: sssd/1.15.0-3
From: Timo Aaltonen <tjaalton@debian.org>
Date: Mon, 06 Feb 2017 15:45:22 +0200
Message-id: <[🔎] 148638872229.2649.2335436274587687197.reportbug@deckard.tyrell>

Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: unblock

Please unblock package sssd

-3 fixes a race condition in certain configurations where the nss responder is not spawned normally, which results in a timeout before logins work. The fix is to drop the new service/socket files that 1.15.0 introduced.

diff --git a/debian/changelog b/debian/changelog
index 28b5a95..4ac67c9 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,11 @@
+sssd (1.15.0-3) unstable; urgency=medium
+
+  * rules, install: Remove responder service and socket files for now, the
+    sockets weren't supposed to be enabled anyway and can cause issues.
+    (Closes: #854048)
+
+ -- Timo Aaltonen <tjaalton@debian.org>  Sat, 04 Feb 2017 18:34:06 +0200
+
 sssd (1.15.0-2) unstable; urgency=medium
 
   * import-daemon-opts.diff, sssd.default: Drop the patch modifying sssd
diff --git a/debian/rules b/debian/rules
index 21da8aa..f0945d3 100755
--- a/debian/rules
+++ b/debian/rules
@@ -74,6 +74,11 @@ override_dh_install:
        # match nn/nn/nnnn, replace with the date from changelog
        sed -i 's/[0-1][0-9]\/[0-3][0-9]\/[0-9][0-9][0-9][0-9]/${PKGDATE}/g' $(CURDIR)/debian/tmp/usr/share/man/man*/*
 
+       for responder in autofs ifp nss pac pam-priv pam ssh sudo; do \
+               rm -f $(CURDIR)/debian/tmp/lib/systemd/system/sssd-$$responder.service \
+                     $(CURDIR)/debian/tmp/lib/systemd/system/sssd-$$responder.socket; \
+       done
+
        dh_install --fail-missing
 
 override_dh_python2:
diff --git a/debian/sssd-ad-common.install b/debian/sssd-ad-common.install
index 6c34fc6..fdaaf91 100644
--- a/debian/sssd-ad-common.install
+++ b/debian/sssd-ad-common.install
@@ -1,3 +1,3 @@
-lib/systemd/system/sssd-pac.service
-lib/systemd/system/sssd-pac.socket
+#lib/systemd/system/sssd-pac.service
+#lib/systemd/system/sssd-pac.socket
 usr/lib/*/sssd/sssd_pac
diff --git a/debian/sssd-ad-common.postinst b/debian/sssd-ad-common.postinst
new file mode 100644
index 0000000..509bb6c
--- /dev/null
+++ b/debian/sssd-ad-common.postinst
@@ -0,0 +1,28 @@
+#!/bin/sh
+
+set -e
+
+case "$1" in
+    configure)
+        if dpkg --compare-versions "$2" lt-nl "1.15.0-3"; then
+            if [ -x "/usr/bin/deb-systemd-helper" ]; then
+                deb-systemd-helper purge sssd-pac.service >/dev/null
+                deb-systemd-helper unmask sssd-pac.service >/dev/null
+                deb-systemd-helper purge sssd-pac.socket >/dev/null
+                deb-systemd-helper unmask sssd-pac.socket >/dev/null
+            fi
+        fi
+    ;;
+
+    abort-upgrade|abort-remove|abort-deconfigure)
+    ;;
+
+    *)
+        echo "postinst called with unknown argument \`$1'" >&2
+        exit 1
+    ;;
+esac
+
+#DEBHELPER#
+
+exit 0
diff --git a/debian/sssd-common.install b/debian/sssd-common.install
index db46578..7ac7d89 100644
--- a/debian/sssd-common.install
+++ b/debian/sssd-common.install
@@ -1,17 +1,17 @@
 lib/systemd/system/sssd.service
 lib/systemd/system/sssd-secrets.service
 lib/systemd/system/sssd-secrets.socket
-lib/systemd/system/sssd-sudo.service
-lib/systemd/system/sssd-sudo.socket
-lib/systemd/system/sssd-ssh.service
-lib/systemd/system/sssd-ssh.socket
-lib/systemd/system/sssd-autofs.service
-lib/systemd/system/sssd-autofs.socket
-lib/systemd/system/sssd-pam.service
-lib/systemd/system/sssd-pam.socket
-lib/systemd/system/sssd-pam-priv.socket
-lib/systemd/system/sssd-nss.service
-lib/systemd/system/sssd-nss.socket
+#lib/systemd/system/sssd-sudo.service
+#lib/systemd/system/sssd-sudo.socket
+#lib/systemd/system/sssd-ssh.service
+#lib/systemd/system/sssd-ssh.socket
+#lib/systemd/system/sssd-autofs.service
+#lib/systemd/system/sssd-autofs.socket
+#lib/systemd/system/sssd-pam.service
+#lib/systemd/system/sssd-pam.socket
+#lib/systemd/system/sssd-pam-priv.socket
+#lib/systemd/system/sssd-nss.service
+#lib/systemd/system/sssd-nss.socket
 usr/bin/sss_ssh_authorizedkeys
 usr/bin/sss_ssh_knownhostsproxy
 usr/lib/*/cifs-utils/cifs_idmap_sss.so
diff --git a/debian/sssd-common.postinst b/debian/sssd-common.postinst
index 47d0884..4b2caec 100644
--- a/debian/sssd-common.postinst
+++ b/debian/sssd-common.postinst
@@ -50,6 +50,33 @@ case "$1" in
             chown root:root /etc/sssd/sssd.conf
             chmod 0600 /etc/sssd/sssd.conf
         fi
+
+        if dpkg --compare-versions "$2" lt-nl "1.15.0-3"; then
+            if [ -x "/usr/bin/deb-systemd-helper" ]; then
+                deb-systemd-helper purge sssd-autofs.service >/dev/null
+                deb-systemd-helper unmask sssd-autofs.service >/dev/null
+                deb-systemd-helper purge sssd-autofs.socket >/dev/null
+                deb-systemd-helper unmask sssd-autofs.socket >/dev/null
+                deb-systemd-helper purge sssd-nss.service >/dev/null
+                deb-systemd-helper unmask sssd-nss.service >/dev/null
+                deb-systemd-helper purge sssd-nss.socket >/dev/null
+                deb-systemd-helper unmask sssd-nss.socket >/dev/null
+                deb-systemd-helper purge sssd-pam.service >/dev/null
+                deb-systemd-helper unmask sssd-pam.service >/dev/null
+                deb-systemd-helper purge sssd-pam.socket >/dev/null
+                deb-systemd-helper unmask sssd-pam.socket >/dev/null
+                deb-systemd-helper purge sssd-pam-priv.socket >/dev/null
+                deb-systemd-helper unmask sssd-pam-priv.socket >/dev/null
+                deb-systemd-helper purge sssd-sudo.service >/dev/null
+                deb-systemd-helper unmask sssd-sudo.service >/dev/null
+                deb-systemd-helper purge sssd-sudo.socket >/dev/null
+                deb-systemd-helper unmask sssd-sudo.socket >/dev/null
+                deb-systemd-helper purge sssd-ssh.service >/dev/null
+                deb-systemd-helper unmask sssd-ssh.service >/dev/null
+                deb-systemd-helper purge sssd-ssh.socket >/dev/null
+                deb-systemd-helper unmask sssd-ssh.socket >/dev/null
+            fi
+        fi
     ;;
 
     abort-upgrade|abort-remove|abort-deconfigure)
diff --git a/debian/sssd-dbus.install b/debian/sssd-dbus.install
index 57b9066..0ef7673 100644
--- a/debian/sssd-dbus.install
+++ b/debian/sssd-dbus.install
@@ -1,5 +1,5 @@
 etc/dbus-1/system.d/org.freedesktop.sssd.infopipe.conf
-lib/systemd/system/sssd-ifp.service
+#lib/systemd/system/sssd-ifp.service
 usr/lib/*/sssd/sssd_ifp
 usr/share/dbus-1/system-services/org.freedesktop.sssd.infopipe.service
 usr/share/man/man5/sssd-ifp.5
diff --git a/debian/sssd-dbus.postinst b/debian/sssd-dbus.postinst
new file mode 100644
index 0000000..267655d
--- /dev/null
+++ b/debian/sssd-dbus.postinst
@@ -0,0 +1,26 @@
+#!/bin/sh
+
+set -e
+
+case "$1" in
+    configure)
+        if dpkg --compare-versions "$2" lt-nl "1.15.0-3"; then
+            if [ -x "/usr/bin/deb-systemd-helper" ]; then
+                deb-systemd-helper purge sssd-ifp.service >/dev/null
+                deb-systemd-helper unmask sssd-ifp.service >/dev/null
+            fi
+        fi
+    ;;
+
+    abort-upgrade|abort-remove|abort-deconfigure)
+    ;;
+
+    *)
+        echo "postinst called with unknown argument \`$1'" >&2
+        exit 1
+    ;;
+esac
+
+#DEBHELPER#
+
+exit 0


unblock sssd/1.15.0-3

--- End Message ---

--- Begin Message ---

To: Timo Aaltonen <tjaalton@debian.org>, 854379-done@bugs.debian.org

Subject: Re: Bug#854379: unblock: sssd/1.15.0-3

From: Julien Cristau <jcristau@debian.org>

Date: Mon, 6 Feb 2017 20:30:53 +0100

Message-id: <20170206193053.75lkiphmp72qkf2s@betterave.cristau.org>

In-reply-to: <[🔎] 148638872229.2649.2335436274587687197.reportbug@deckard.tyrell>

References: <[🔎] 148638872229.2649.2335436274587687197.reportbug@deckard.tyrell>
On Mon, Feb  6, 2017 at 15:45:22 +0200, Timo Aaltonen wrote:

> Package: release.debian.org
> Severity: normal
> User: release.debian.org@packages.debian.org
> Usertags: unblock
> 
> Please unblock package sssd
> 
> -3 fixes a race condition in certain configurations where the nss responder is not spawned normally, which results in a timeout before logins work. The fix is to drop the new service/socket files that 1.15.0 introduced.
> 
Unblocked this morning.

Cheers,
Julien
--- End Message ---

Reply to:

References:
- Bug#854379: unblock: sssd/1.15.0-3
  - From: Timo Aaltonen <tjaalton@debian.org>

Prev by Date: Bug#854374: release.debian.org: dbgsym packages for linux missing from stretch-debug
Next by Date: Bug#854406: unblock: pbuilder/0.228.4
Previous by thread: Bug#854379: unblock: sssd/1.15.0-3
Next by thread: Bug#854381: unblock: apt/1.4~rc1
Index(es):
- Date
- Thread