[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#854285: marked as done (unblock: ruby-rabl/0.13.0-2)

Your message dated Sun, 05 Feb 2017 21:23:00 +0000
with message-id <82013e0c-4a41-bc28-0344-23fee59bb266@thykier.net>
and subject line Re: Bug#854285: unblock: ruby-rabl/0.13.0-2
has caused the Debian Bug report #854285,
regarding unblock: ruby-rabl/0.13.0-2
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
854285: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=854285
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: unblock

Please unblock package ruby-rabl, version 0.13.0-2.

This version adds a patch from Gilles Filippini to fix FTBFS bug
#849315.
While globally patching BSON to expose the removed 'serialize'
method again might not be the nicest thing to do, I agree it's the
best thing to do for stretch. (Effect limited to users importing
ruby-rabl, very tiny change, no other packages appear to care about
the specifics.)

debdiff below.

Thanks,
-ch


unblock ruby-rabl/0.13.0-2



diff -Nru ruby-rabl-0.13.0/debian/changelog ruby-rabl-0.13.0/debian/changelog
--- ruby-rabl-0.13.0/debian/changelog	2016-08-24 10:43:46.000000000 +0000
+++ ruby-rabl-0.13.0/debian/changelog	2017-02-05 17:37:31.000000000 +0000
@@ -1,3 +1,13 @@
+ruby-rabl (0.13.0-2) unstable; urgency=medium
+
+  * Team upload.
+
+  [ Gilles Filippini ]
+  * def-bson-serialize.patch: reintroduce BSON.serialize method dropped
+    from ruby-bson since release 2.0.0 (Closes: #849315)
+
+ -- Christian Hofstaedtler <zeha@debian.org>  Sun, 05 Feb 2017 17:37:31 +0000
+
 ruby-rabl (0.13.0-1) unstable; urgency=medium
 
   * Imported Upstream version 0.13.0
diff -Nru ruby-rabl-0.13.0/debian/patches/def-bson-serialize.patch ruby-rabl-0.13.0/debian/patches/def-bson-serialize.patch
--- ruby-rabl-0.13.0/debian/patches/def-bson-serialize.patch	1970-01-01 00:00:00.000000000 +0000
+++ ruby-rabl-0.13.0/debian/patches/def-bson-serialize.patch	2017-02-05 17:37:31.000000000 +0000
@@ -0,0 +1,36 @@
+Description: From ruby-bson upstream changelog [1]:
+ 2.0.0
+ Backwards Incompatible Changes
+ ...
+ BSON.serialize is no longer the entry point to serialize a BSON
+ document into its raw bytes.
+ For Ruby runtimes that support ordered hashes, you may simply call
+ `to_bson` on the hash instance (Alternatively a `BSON::Document` is
+ also a hash:
+  { key: "value" }.to_bson
+  BSON::Document[:key, "value"].to_bson
+ For Ruby runtimes that do not support ordered hashes, then you must
+ instantiate an instance of a `BSON::Document` (which is a subclass of
+ hash) and call `to_bson` on that, since the BSON specification
+ guarantees order of the fields:
+  BSON::Document[:key, "value"].to_bson
+ .
+ [1] https://github.com/mongodb/bson-ruby/blob/master/CHANGELOG.md
+ .
+ This patch re-introduces BSON.serialize.
+Author: Gilles Filippini <pini@debian.org>
+Bug-Debian: https://bugs.debian.org/849315
+Index: ruby-rabl-0.13.0/lib/rabl/configuration.rb
+===================================================================
+--- ruby-rabl-0.13.0.orig/lib/rabl/configuration.rb
++++ ruby-rabl-0.13.0/lib/rabl/configuration.rb
+@@ -7,6 +7,9 @@ end
+ # We load the bson library if it is available.
+ begin
+   require 'bson'
++  def BSON.serialize data
++    data.to_bson
++  end
+   rescue LoadError
+ end
+ 
diff -Nru ruby-rabl-0.13.0/debian/patches/series ruby-rabl-0.13.0/debian/patches/series
--- ruby-rabl-0.13.0/debian/patches/series	1970-01-01 00:00:00.000000000 +0000
+++ ruby-rabl-0.13.0/debian/patches/series	2017-02-05 17:37:31.000000000 +0000
@@ -0,0 +1 @@
+def-bson-serialize.patch

--- End Message ---
--- Begin Message --- 
Christian Hofstaedtler:
> Package: release.debian.org
> Severity: normal
> User: release.debian.org@packages.debian.org
> Usertags: unblock
> 
> Please unblock package ruby-rabl, version 0.13.0-2.
> 
> This version adds a patch from Gilles Filippini to fix FTBFS bug
> #849315.
> While globally patching BSON to expose the removed 'serialize'
> method again might not be the nicest thing to do, I agree it's the
> best thing to do for stretch. (Effect limited to users importing
> ruby-rabl, very tiny change, no other packages appear to care about
> the specifics.)
> 
> debdiff below.
> 
> Thanks,
> -ch
> 
> 
> unblock ruby-rabl/0.13.0-2
> 
> [...]
> 

Unblocked, thanks.

~Niels

--- End Message ---
Reply to: