[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#854227: marked as done (unblock: python-cliapp/1.20160724-2)

Your message dated Sun, 05 Feb 2017 08:58:00 +0000
with message-id <e17fdd83-ae41-8077-a9f6-d313afa6b390@thykier.net>
and subject line Re: Bug#854227: unblock: python-cliapp/1.20160724-2
has caused the Debian Bug report #854227,
regarding unblock: python-cliapp/1.20160724-2
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
854227: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=854227
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: unblock

Please unblock package python-cliapp

1.20160724-1 fails to build from source because after it was
originally uploaded, pylint was upgraded, and now has new checks,
which fail the build. In 1.20160724-2 I have disabled build-time
tests. I decided to disable the tests rather than fixing the thing
that pylint now complains about, because I think it's a smaller, safer
change than making code changes at this stage of the release cycle.

Source debdiff:

diff -Nru python-cliapp-1.20160724/debian/changelog python-cliapp-1.20160724/debian/changelog
--- python-cliapp-1.20160724/debian/changelog	2016-07-24 20:54:18.000000000 +0200
+++ python-cliapp-1.20160724/debian/changelog	2017-02-05 09:19:14.000000000 +0100
@@ -1,3 +1,17 @@
+python-cliapp (1.20160724-2) unstable; urgency=medium
+
+  * Fix "FTBFS: Test failures" by disabling build-time checks
+    (Closes: #852882)
+      - when -1 was uploaded, the tests passed, but pylint is
+        now a newer version with new checks
+      - Debian is in a freeze, this is the minimal change to work
+        around the bug; the tests have passed in previuos uploads,
+        with an older pylint, so disabling them should be sufficiently
+        safe and less risky than hacking up code at the last second of
+        a release cycle
+
+ -- Lars Wirzenius <liw@liw.fi>  Sun, 05 Feb 2017 09:19:14 +0100
+
 python-cliapp (1.20160724-1) unstable; urgency=medium
 
   * Change debian/rules to run automated tests during build.
diff -Nru python-cliapp-1.20160724/debian/rules python-cliapp-1.20160724/debian/rules
--- python-cliapp-1.20160724/debian/rules	2016-07-24 20:41:27.000000000 +0200
+++ python-cliapp-1.20160724/debian/rules	2017-02-05 09:19:14.000000000 +0100
@@ -7,12 +7,6 @@
 	$(MAKE)
 	dh_auto_build --with=python2 --buildsystem=python_distutils
 
-override_dh_auto_test:
-	$(MAKE) clean check
-	# RE-build
-	$(MAKE)
-	dh_auto_build --with=python2 --buildsystem=python_distutils
-
 override_dh_auto_clean:
 	$(MAKE) clean
 	dh_auto_clean --with=python2 --buildsystem=python_distutils
[PREVIOUS COMMAND EXIT: 1]
~/.../cliapp $ 


unblock python-cliapp/1.20160724-2

-- System Information:
Debian Release: 9.0
  APT prefers testing
  APT policy: (500, 'testing'), (1, 'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 4.9.0-1-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

--- End Message ---
--- Begin Message --- 
Lars Wirzenius:
> Package: release.debian.org
> Severity: normal
> User: release.debian.org@packages.debian.org
> Usertags: unblock
> 
> Please unblock package python-cliapp
> 
> 1.20160724-1 fails to build from source because after it was
> originally uploaded, pylint was upgraded, and now has new checks,
> which fail the build. In 1.20160724-2 I have disabled build-time
> tests. I decided to disable the tests rather than fixing the thing
> that pylint now complains about, because I think it's a smaller, safer
> change than making code changes at this stage of the release cycle.
> 
> Source debdiff:
> 
> [...]

Unblocked, thanks.

~Niels

--- End Message ---
Reply to: