[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#852865: unblock: gnome-orca/3.22.2-2



Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: unblock

Hello,

The freeze is soon now, so I'm pre-asking for freeze unblock.

This is about Bug#852863: switching between pidgin and libreoffice
writer makes gnome-orca crash for some writer documents, and then the
blind user is left without any way to get information from his graphical
desktop. Upstream has commited a very simple fix, attached to this mail,
confirmed to fix the crash. Is it OK to upload?

unblock gnome-orca/3.22.2-2

-- System Information:
Debian Release: 9.0
  APT prefers testing
  APT policy: (990, 'testing'), (500, 'unstable-debug'), (500, 'testing-debug'), (500, 'buildd-unstable'), (500, 'unstable'), (500, 'stable'), (500, 'oldstable'), (1, 'experimental-debug'), (1, 'buildd-experimental'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.9.0 (SMP w/4 CPU cores)
Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

-- 
Samuel
<b> lisons de l'assembleur c
 -+- #sos - CrisC forever -+-
Index: changelog
===================================================================
--- changelog	(révision 51959)
+++ changelog	(copie de travail)
@@ -1,3 +1,10 @@
+gnome-orca (3.22.2-2) UNRELEASED; urgency=medium
+
+  * git-0da4c2ed3d4dedb2229e542ff47257f1d2ab1a50: cherry-pick upstream fix for
+    crash with Writer table (Closes: Bug#852863).
+
+ -- Samuel Thibault <sthibault@debian.org>  Sat, 28 Jan 2017 03:08:35 +0100
+
 gnome-orca (3.22.2-1) unstable; urgency=medium
 
   * New upstream release.
Index: patches/git-0da4c2ed3d4dedb2229e542ff47257f1d2ab1a50
===================================================================
--- patches/git-0da4c2ed3d4dedb2229e542ff47257f1d2ab1a50	(nonexistent)
+++ patches/git-0da4c2ed3d4dedb2229e542ff47257f1d2ab1a50	(copie de travail)
@@ -0,0 +1,23 @@
+commit 0da4c2ed3d4dedb2229e542ff47257f1d2ab1a50
+Author: Joanmarie Diggs <jdiggs@igalia.com>
+Date:   Thu Jan 5 04:07:51 2017 -0500
+
+    Fix crash with Writer table
+
+diff --git a/src/orca/scripts/apps/soffice/braille_generator.py b/src/orca/scripts/apps/soffice/braille_generator.py
+index 21c662e09..5cf81ab5d 100644
+--- a/src/orca/scripts/apps/soffice/braille_generator.py
++++ b/src/orca/scripts/apps/soffice/braille_generator.py
+@@ -93,8 +93,11 @@ class BrailleGenerator(braille_generator.BrailleGenerator):
+             result = super()._generateRealTableCell(obj, **args)
+         else:
+             result = []
++            formatType = args.get('formatType')
++            args['formatType'] = 'focused'
+             for child in obj:
+-                result.extend(self.generate(child))
++                result.extend(self.generate(child, **args))
++            args['formatType'] = formatType
+ 
+         if not self._script.utilities.isSpreadSheetCell(obj):
+             return result
Index: patches/series
===================================================================
--- patches/series	(nonexistent)
+++ patches/series	(copie de travail)
@@ -0,0 +1 @@
+git-0da4c2ed3d4dedb2229e542ff47257f1d2ab1a50

Reply to: