[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#809534: jessie-pu: package ttylog/0.26-1+deb8u1



Control: tags -1 + moreinfo

Hi,

On 2015-12-31 19:52, Robert James Clay wrote:
Please accept ttylog 0.26-1+deb8u1 for the next Jessie point release. It resolves an issue with the current version of ttylog in 'jessie' (0.25-1) of the truncating of the modem_device string during normal operation of the program. (Debian bug # 731086: ttylog: Unable to select serial device (with - d or --device option), closed with the upload of package version 0.26-1 in
June.)

I see that you've already uploaded a package for this. I'm afraid that I'm going to have to reject that upload. For future reference, this is why the preferred process is for the diff to be approved /before/ the upload, rather than the discussion occurring afterwards.

For the record, one reason for the rejection is the version number. The version of ttylog in unstable is 0.26-1 and your upload would introduce a higher version into stable, which would break the archive's version constraints (and is illogical in any case - for what you were attempting to do, 0.26-1~deb8u1 would have been a more appropriate version).

Secondly, the diff from current stable includes packaging changes which are generally not appropriate in a stable update, namely the debhelper compat and build-depends bump (particularly as that change has nothing to do with fixing the bug in question).

The rest of the diff looks okay from a quick view. If you'd like to prepare and test a package that reverts the debhelper changes and is versioned as 0.26-1~deb8u1, please attach a new debdiff to this bug and I'd be happy to look at reviewing that.

Regards,

Adam


Reply to: