Your message dated Sat, 10 Dec 2016 18:31:50 +0100 with message-id <20161210173150.GC8128@mraw.org> and subject line Re: Bug#847593: unblock: letsencrypt.sh/0.3.0-2 has caused the Debian Bug report #847593, regarding unblock: letsencrypt.sh/0.3.0-2 to be marked as done. This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact owner@bugs.debian.org immediately.) -- 847593: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=847593 Debian Bug Tracking System Contact owner@bugs.debian.org with problems
--- Begin Message ---
- To: Debian Bug Tracking System <submit@bugs.debian.org>
- Subject: unblock: letsencrypt.sh/0.3.0-2
- From: Mattia Rizzolo <mattia@debian.org>
- Date: Fri, 9 Dec 2016 18:26:45 +0100
- Message-id: <[🔎] 20161209172639.GA20804@mapreri.org>
Package: release.debian.org Severity: normal User: release.debian.org@packages.debian.org Usertags: unblock Please urgent package letsencrypt.sh. The current version contains a typo which causes a huge big failure in certain systems (somehow none of the systems I tested hit it, the bug was reported privately to me). The regression potential is clearly infinitesimal, and IMHO the 10-days delay for testing migration is really unwarrented. attached the debdiff against what's in testing. urgent letsencrypt.sh/0.3.0-2 -- regards, Mattia Rizzolo GPG Key: 66AE 2B4A FCCF 3F52 DA18 4D18 4B04 3FCD B944 4540 .''`. more about me: https://mapreri.org : :' : Launchpad user: https://launchpad.net/~mapreri `. `'` Debian QA page: https://qa.debian.org/developer.php?login=mattia `-diffstat for letsencrypt.sh-0.3.0 letsencrypt.sh-0.3.0 changelog | 6 ++++++ patches/Make-the-upgrade-path-from-ACCOUNT_KEY-_JSON-to-the-new-A.patch | 4 ++-- 2 files changed, 8 insertions(+), 2 deletions(-) diff -Nru letsencrypt.sh-0.3.0/debian/changelog letsencrypt.sh-0.3.0/debian/changelog --- letsencrypt.sh-0.3.0/debian/changelog 2016-12-02 00:05:38.000000000 +0100 +++ letsencrypt.sh-0.3.0/debian/changelog 2016-12-09 18:02:21.000000000 +0100 @@ -1,3 +1,9 @@ +letsencrypt.sh (0.3.0-2) unstable; urgency=high + + * Fix syntax error that could cause "unbound variable" errors in some cases. + + -- Mattia Rizzolo <mattia@debian.org> Fri, 09 Dec 2016 18:01:53 +0100 + letsencrypt.sh (0.3.0-1) unstable; urgency=medium * Import new upstream release 0.3.0. diff -Nru letsencrypt.sh-0.3.0/debian/patches/Make-the-upgrade-path-from-ACCOUNT_KEY-_JSON-to-the-new-A.patch letsencrypt.sh-0.3.0/debian/patches/Make-the-upgrade-path-from-ACCOUNT_KEY-_JSON-to-the-new-A.patch --- letsencrypt.sh-0.3.0/debian/patches/Make-the-upgrade-path-from-ACCOUNT_KEY-_JSON-to-the-new-A.patch 2016-11-30 20:44:48.000000000 +0100 +++ letsencrypt.sh-0.3.0/debian/patches/Make-the-upgrade-path-from-ACCOUNT_KEY-_JSON-to-the-new-A.patch 2016-12-09 18:00:57.000000000 +0100 @@ -12,7 +12,7 @@ 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/letsencrypt.sh b/letsencrypt.sh -index 58c0329..f673dbb 100755 +index 58c0329..651148b 100755 --- a/letsencrypt.sh +++ b/letsencrypt.sh @@ -167,17 +167,19 @@ load_config() { @@ -36,7 +36,7 @@ - mv "${BASEDIR}/private_key.json" "${ACCOUNT_KEY_JSON}" + if [[ -f "${ACCOUNT_KEY_JSON:-"${BASEDIR}/private_key.json"}" ]] && [[ ! -f "${new_ACCOUNT_KEY_JSON}" ]]; then + echo "! Moving private_key.json to ${new_ACCOUNT_KEY_JSON}" -+ mv -v "{$ACCOUNT_KEY_JSON:-"${BASEDIR}/private_key.json"}" "${new_ACCOUNT_KEY_JSON}" ++ mv -v "${ACCOUNT_KEY_JSON:-"${BASEDIR}/private_key.json"}" "${new_ACCOUNT_KEY_JSON}" fi + ACCOUNT_KEY="${new_ACCOUNT_KEY}" + ACCOUNT_KEY_JSON="${new_ACCOUNT_KEY_JSON}"Attachment: signature.asc
Description: PGP signature
--- End Message ---
--- Begin Message ---
- To: Mattia Rizzolo <mattia@debian.org>, 847593-done@bugs.debian.org
- Subject: Re: Bug#847593: unblock: letsencrypt.sh/0.3.0-2
- From: Cyril Brulebois <kibi@debian.org>
- Date: Sat, 10 Dec 2016 18:31:50 +0100
- Message-id: <20161210173150.GC8128@mraw.org>
- In-reply-to: <[🔎] 20161209172639.GA20804@mapreri.org>
- References: <[🔎] 20161209172639.GA20804@mapreri.org>
Mattia Rizzolo <mattia@debian.org> (2016-12-09): > Please urgent package letsencrypt.sh. > > The current version contains a typo which causes a huge big failure in > certain systems (somehow none of the systems I tested hit it, the bug > was reported privately to me). > > The regression potential is clearly infinitesimal, and IMHO the 10-days > delay for testing migration is really unwarrented. > > attached the debdiff against what's in testing. > > urgent letsencrypt.sh/0.3.0-2 Looks good to me, done that, thanks. KiBi.Attachment: signature.asc
Description: Digital signature
--- End Message ---