Bug#846141: hint-tester always converts its input to lowercase, meaning you can't use it on package versions with uppercase characters

[Iain Lane <laney@debian.org>]

Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: britney

Ahoy,

I noticed when using hint-tester on Ubuntu.

  britney> easy […] dreamchess/0.2.1-RC2-2build1 […]
  Version mismatch, dreamchess 0.2.1-rc2-2build1 != 0.2.1-RC2-2build1

The latter is the right version, but my input has been downcased by
britney.

Apparently[0] uppercase characters are legal in package versions (and
even if they weren't this would be a strange place to surface the
violation). Is there a reason for calling lower() here? Attached a patch
which just removes that - and makes the hint work for me.

Cheers,

-- 
Iain Lane                                  [ iain@orangesquash.org.uk ]
Debian Developer                                   [ laney@debian.org ]
Ubuntu Developer                                   [ laney@ubuntu.com ]
[0] https://www.debian.org/doc/debian-policy/ch-controlfields.html#s-f-Version

>From 77fe127e62303a5c6cc1088eeed457995c5b15ef Mon Sep 17 00:00:00 2001
From: Iain Lane <iain.lane@canonical.com>
Date: Mon, 28 Nov 2016 16:10:00 +0000
Subject: [PATCH] hint-tester: Don't lowercase the input

Doing this means that you can't use the hint tester for packages with
uppercase characters in the version, e.g.

  Version mismatch, dreamchess 0.2.1-rc2-2build1 != 0.2.1-RC2-2build1
---
 britney.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/britney.py b/britney.py
index 6d8361a..2b38926 100755
--- a/britney.py
+++ b/britney.py
@@ -2840,7 +2840,7 @@ class Britney(object):
         while True:
             # read the command from the command line
             try:
-                user_input = input('britney> ').lower().split()
+                user_input = input('britney> ').split()
             except EOFError:
                 print("")
                 break
-- 
2.9.3