Bug#845443: jessie-pu: package nss-pam-ldapd/0.9.4-3+deb8u2

[Salvatore Bonaccorso <carnil@debian.org>]

Package: release.debian.org
Severity: normal
Tags: jessie
User: release.debian.org@packages.debian.org
Usertags: pu

Hi Stable release managers,

X-Debbugs-CC to Arthur de Jong and Ferenc Wágner.

nss-pam-ldapd's nslcd under the conditions as described in #814881
might fail to restart. nslcd restart which is stop+start with systemd,
is racy, and might lead to nslcd not running after a restart. Ferenc
has posted his analysis in https://bugs.debian.org/814881#39
confirming that the debdiff fixes the issue.

The proposed debian/changelog is

+nss-pam-ldapd (0.9.4-3+deb8u2) stable; urgency=medium
+
+  * Non-maintainer upload.
+  * have init script stop action only return when nslcd has actually stopped
+    (Closes: #814881)
+
+ -- Salvatore Bonaccorso <carnil@debian.org>  Wed, 09 Nov 2016 13:48:14 +0100

and attached is the propsed debdiff.

Would it be acceptable to include in for the next jessie point
release?

Regards,
Salvatore

diff -Nru nss-pam-ldapd-0.9.4/debian/changelog nss-pam-ldapd-0.9.4/debian/changelog
--- nss-pam-ldapd-0.9.4/debian/changelog	2016-01-19 21:17:44.000000000 +0100
+++ nss-pam-ldapd-0.9.4/debian/changelog	2016-11-09 13:48:14.000000000 +0100
@@ -1,3 +1,11 @@
+nss-pam-ldapd (0.9.4-3+deb8u2) stable; urgency=medium
+
+  * Non-maintainer upload.
+  * have init script stop action only return when nslcd has actually stopped
+    (Closes: #814881)
+
+ -- Salvatore Bonaccorso <carnil@debian.org>  Wed, 09 Nov 2016 13:48:14 +0100
+
 nss-pam-ldapd (0.9.4-3+deb8u1) stable; urgency=low
 
   * fix-issues-withdaemonising.patch, avoid-signal-race.patch: patches to
diff -Nru nss-pam-ldapd-0.9.4/debian/nslcd.init nss-pam-ldapd-0.9.4/debian/nslcd.init
--- nss-pam-ldapd-0.9.4/debian/nslcd.init	2016-01-19 19:50:51.000000000 +0100
+++ nss-pam-ldapd-0.9.4/debian/nslcd.init	2016-11-09 13:48:14.000000000 +0100
@@ -96,7 +96,7 @@
   if [ "$K5START_START" = "yes" ]
   then
     log_daemon_msg "Stopping $K5START_DESC" "k5start"
-    start-stop-daemon --stop --oknodo --pidfile $K5START_PIDFILE
+    start-stop-daemon --stop --oknodo --retry 10 --pidfile $K5START_PIDFILE
     log_end_msg $?
     # remove any left behind files
     [ -n "$K5START_PIDFILE" ] && rm -f $K5START_PIDFILE
@@ -129,7 +129,7 @@
 stop)
   # stop nslcd
   log_daemon_msg "Stopping $NSLCD_DESC" "$NSLCD_NAME"
-  start-stop-daemon --stop --oknodo \
+  start-stop-daemon --stop --oknodo --retry 10 \
                     --pidfile $NSLCD_PIDFILE \
                     --name "$NSLCD_NAME"
   log_end_msg $?