[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#843701: jessie-pu: package boinc/7.4.23+dfsg-1



Package: release.debian.org
User: release.debian.org@packages.debian.org
Usertags: pu
Tags: jessie
Severity: normal

Boinc has a functionality problem in stable, the fix is already backported and I did upload
a new version in unstable a few hours ago
(just to make it backportable with older kernels)

the diff is simple:
+  [ Tom Downes ]
+  * Fix OOM_ADJ handling with a backportable approach
+    (Closes: #843663)

^^ a typo in a variable name was preventing OOM_ADJ from being correctly set in the init script


+  [ Mike Brennan <debian@u4ear.com> ]
+  * Fix xhost syntax. (Closes: #841665)
^^ this is a potential security issue that still affects stable, so I would like to also address it.

diff -Nru boinc-7.4.23+dfsg/debian/boinc-client.init boinc-7.4.23+dfsg/debian/boinc-client.init
--- boinc-7.4.23+dfsg/debian/boinc-client.init  2014-10-17 17:10:09.000000000 +0200
+++ boinc-7.4.23+dfsg/debian/boinc-client.init  2016-11-08 19:39:13.000000000 +0100
@@ -29,6 +29,7 @@
BOINC_DIR=/var/lib/boinc-client
BOINC_CLIENT=/usr/bin/boinc
BOINC_OOM_ADJ=15
+BOINC_OOM_SCORE_ADJ=1000

#VALGRIND_OPTIONS="-v --log-file=/tmp/valgrind_boinc.log "
VALGRIND_OPTIONS=""
@@ -106,7 +107,7 @@
else
if [ -n "$DISPLAY" -a -x /usr/bin/xhost ]; then
# grant the boinc client to perform GPU computing
-       xhost local:boinc || echo -n "xhost error ignored, GPU computing may not be possible"
+       xhost +si:localuser:$BOINC_USER || echo -n "xhost error ignored, GPU computing may not be possible"
fi
if [ -n "$VALGRIND_OPTIONS" ]; then
start-stop-daemon --start --quiet --background --pidfile $PIDFILE \
@@ -206,10 +207,13 @@
fi
fi
for BPID in ${pid} ${children}; do
-      if [ -w /proc/${BPID}/oom_adj ]; then
-        echo ${BOINC_OOM_AD} > /proc/${BPID}/oom_adj 2>/dev/null || true
+      # Fallback to old oom_adj if oom_score_adj doesn't exist
+      if [ -w /proc/${BPID}/oom_score_adj ]; then
+        echo ${BOINC_OOM_SCORE_ADJ} > /proc/${BPID}/oom_score_adj 2>/dev/null || true
+      elif [ -w /proc/${BPID}/oom_adj ]; then
+        echo ${BOINC_OOM_ADJ} > /proc/${BPID}/oom_adj 2>/dev/null || true
else
-        echo "Could not write to /proc/${BPID}/oom_adj"
+        echo "Could not adjust oom_score of task"
fi
done
fi


thanks,

Gianfranco

Attachment: debdiff
Description: Binary data


Reply to: