[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#839907: jessie-pu: package metar/20061030.1-2+b3

On 2016-10-06 11:24, Adam D. Barratt wrote:
Control: tags -1 + moreinfo

On 2016-10-06 10:58, Daniel Lange wrote:
The NOAA weather service changed the URL for their service so metar fails
as reported (and fixed) in #833655 for unstable/testing.
The package is only usable with an URL-override by setting the METAURL
environment variable as is.

The backport of the minimum set of changes from 20061030.1-2.2 is a bit lengthy as this includes debhelper -> dh / quilt to get the patches to apply
cleanly and stay with what we have in testing / unstable.

What's the problem with applying the patches against the existing
jessie package? Build sytem changes generally aren't appropriate for
updates in stable.

Looking at the existing rules file, I'm assuming the answer is that the existing package in jessie doesn't use a patch system.

However, unless I'm missing something, the sum total of the real changes in your diff are a URL change in a #define and one line of change to some POD. I'm afraid there's no way that justifies a 3,300 line diff that changes source format, debhelper compat version and rewrites the rules file entirely. I'd honestly prefer that the changes were applied directly to the source files and therefore pulled in via the .diff.gz, if that's the alternative. (Some packages do that and ship the files in debian/patches in the source package, so that it's clear what the individual patches are, even if they're not applied by the build process.)

It's possible another member of the team will disagree with me, of course, but I'm afraid I'm not prepared to accept the proposed diff.



Reply to: