On Sat, Oct 01, 2016 at 06:05:43PM (+0100), Adam D. Barratt wrote: > Control: tags -1 + moreinfo > > On Sat, 2016-10-01 at 18:22 +0200, Sebastien Badia wrote: > > Asused is a tool to check IPv4 allocations and assignments > > as stored in the RIPE database. > > > > The actual version of asused in Debian/stable (3.72-11) doesn't > > works due to a upstream change on the RIPE database. > > > > The issue was correctred in Debian/testing (3.72-12), see for references > > the corresponding bug https://bugs.debian.org/799919 and the patch > > https://anonscm.debian.org/cgit/collab- > > maint/asused.git/patch/id=472d9b76587005d808766e6f2818ad00bd5d05b6 > > That patch changes nothing to do with RIPE, it only updates some patch > metadata. > > > This jessie-p-u build fine in jessie, package is ready for an upload > > here https://marcellin.sebian.fr/debian/ > > > > You see any issues to no accept asused_3.72-12+deb8u7 as a jessie-p-u? > > I certainly see issues with that version number. Firstly, it's higher > than the package version in unstable, and secondly I have no idea why > you would use "deb8u7" for the first update in jessie - that would be > 3.72-11+deb8u1. "3.72-12+deb8u7" would be the seventh update in jessie > to the package 3.72-12 (which isn't even in jessie). > > In any case, before we can agree an upload, we would need to see - as in > attached to this bug log, not merely on an external resource - a source > debdiff against the version of the package currently in jessie, > built /and tested/ on jessie. > > Regards, > > Adam Hello Adam, Pff really sorry for the waste time… I was too fast on this one… Just fixed the version number, and re-builded/uploaded to mentors.d.n https://mentors.debian.net/debian/pool/main/a/asused/asused_3.72-11+deb8u1.dsc (build and tested in a clean env on Debian jessie). The debdiff against 3.72-11 version in jessie is now attached. Thanks for your time and explanation, and sorry again… :) Regards, Seb
diff -Nru asused-3.72/debian/changelog asused-3.72/debian/changelog
--- asused-3.72/debian/changelog 2014-01-28 23:26:47.000000000 +0100
+++ asused-3.72/debian/changelog 2016-10-02 01:29:40.000000000 +0200
@@ -1,3 +1,10 @@
+asused (3.72-11+deb8u1) stable-proposed-updates; urgency=medium
+
+ * Use created fields instead of changed (Closes: #799919)
+ Thanks Matthias!
+
+ -- Sebastien Badia <seb@sebian.fr> Sun, 02 Oct 2016 01:28:19 +0200
+
asused (3.72-11) unstable; urgency=low
* New maintainer (closes: #612901)
diff -Nru asused-3.72/debian/patches/07_changed_fields_are_gone.patch asused-3.72/debian/patches/07_changed_fields_are_gone.patch
--- asused-3.72/debian/patches/07_changed_fields_are_gone.patch 1970-01-01 01:00:00.000000000 +0100
+++ asused-3.72/debian/patches/07_changed_fields_are_gone.patch 2016-10-02 01:27:48.000000000 +0200
@@ -0,0 +1,64 @@
+Description: asused stopped working because changed fields are missing in newer objects
+Author: Matthias Cramer <cramer@iway.ch>
+Origin: other, https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=799919;msg=5;filename=in.pm.patch;att=1
+Bug-Debian: https://bugs.debian.org/799919
+Forwarded: no
+Reviewed-By: Sebastien Badia <seb@sebian.fr>
+Last-Update: 2016-03-01
+
+--- asused-3.72.orig/Net/RIPEWhois/in/in.pm
++++ asused-3.72/Net/RIPEWhois/in/in.pm
+@@ -355,6 +355,10 @@ sub getIn {
+ # Changed
+ push(@{$in{'ch'}}, $value);
+ }
++ elsif($inetnum && $attr eq 'cr') {
++ # Created
++ push(@{$in{'cr'}}, $value);
++ }
+ elsif($inetnum && $attr eq 'so') {
+ # Source
+ $in{'so'} = $value;
+@@ -373,14 +377,14 @@ sub getIn {
+ # Get creation date for valid inetnum object
+ if($inetnum) {
+ # Validate date
+- my $date = $self->creationDate(@{$in{'ch'}});
++ my $date = $self->creationDate(@{$in{'cr'}});
+
+ if($date) {
+ $in{'created'} = $date;
+ }
+ else {
+ $self->error($INVALID_DATE,
+- ("Invalid date in " . join('; ', @{$in{'ch'}})));
++ ("Invalid date in " . join('; ', @{$in{'cr'}})));
+
+ push(@{$in{'warning'}}, ($self->error())[1]);
+ }
+@@ -560,7 +564,7 @@ sub creationDate {
+ my @dateList;
+ #don't trust the date from db
+ foreach my $dateStr (@ch) {
+- if($dateStr =~ /(\d+)$/) {
++ if($dateStr =~ /([\d\-]+)(T.*)?$/) {
+ my $date = $1;
+ return unless ($date = checkYYYYmmDD($date)) ; #look if it is valid date
+ push(@dateList, $date); #make list of valid dates
+@@ -583,6 +587,8 @@ sub checkYYYYmmDD {
+ my($yy, $mm, $dd, $utc, $yyActual, $mmActual, $ddActual, $date);
+ my($sec, $min, $hour, $wday, $yday, $isdst); # Temp vars
+
++ $yyyyMMdd =~ s/\-//g;
++
+ #YYYYMMDD
+ if($yyyyMMdd =~ /^(\d{4})(\d{2})(\d{2})$/) {
+ $yy = $1 - 1900;
+@@ -655,6 +661,7 @@ sub initHashValues {
+ $dest->{'ac'} = []; # list of admin-c values
+ $dest->{'tc'} = []; # list of tech-c values
+ $dest->{'ch'} = []; # list of changed values
++ $dest->{'cr'} = []; # list of created values
+ $dest->{'so'} = ''; # source
+ $dest->{'ml'} = []; # list of mnt-lower
+ $dest->{'na'} = ''; # netname
diff -Nru asused-3.72/debian/patches/series asused-3.72/debian/patches/series
--- asused-3.72/debian/patches/series 2014-01-25 16:31:51.000000000 +0100
+++ asused-3.72/debian/patches/series 2016-10-02 01:28:11.000000000 +0200
@@ -4,3 +4,4 @@
04_drop_network_tests.patch
05_fix_priv_range.patch
06_asused_pod.patch
+07_changed_fields_are_gone.patch
Attachment:
signature.asc
Description: PGP signature