stable-updates fix for Bug#826563: perl: Apparent regression in TryCatch
On Mon, Jun 06, 2016 at 08:54:23PM +0100, Dominic Hargreaves wrote:
> Thanks Niko for analysis. The sequence of events went like this:
>
> 1) a commit (which fixed a segfault, but broke compatibility) was
> committed to the upstream development branch
> 2) upstream testing detected the issue in Devel::Declare, and a new
> version was released to CPAN fixing the problem.
> 3) the fix was backported to maint-5.20, and in the process of that
> backporting, the knowledge that there was a known issue was lost.
>
> The general feeling on IRC was that point release updates should indeed
> avoid breaking old versions of libraries on CPAN, and that a known
> issue should have been included in the perldelta. This will be added
> to the release managers guide in future.
>
> In hindsight, it's obvious that Debian's testing of this update wasn't
> sufficient either. Such breaking changes in perl stable updates are,
> I believe, exceedingly rare, but equally we had not attempted a wholesale,
> or near-wholesale update in Debian stable before, and the breakage
> wasn't reported in any real-world testing using the stable update
> installed from source. In future, we should perform similar automated
> testing against jessie-proposed-updates as we do in experimental when
> a new major version of perl is introduced.
>
> My plan is:
>
> 1) submit a new version of libdevel-declare-perl for immediate
> inclusion in stable-updates.
> 2) kick off a test rebuild of packages using perl to catch any issues
> in this update (at least those which we can catch by package builds
> and test suites).
> 3) document this in the perl maintenance notes on the wiki for future
> reference
>
> I should be able to do at least the first two of these this evening.
I've prepared an updated package of libdevel-declare-perl, which builds
and tests out fine with both perl 5.20.2-3+deb8u4 and 5.20.2-3+deb8u5.
A debdiff for stable is attached. Release team, are you happy for me
to upload (is the distribution correct for stable-updates)?
Thanks,
Dominic.
diff -Nru libdevel-declare-perl-0.006017/debian/changelog libdevel-declare-perl-0.006017/debian/changelog
--- libdevel-declare-perl-0.006017/debian/changelog 2014-10-08 21:24:17.000000000 +0100
+++ libdevel-declare-perl-0.006017/debian/changelog 2016-06-07 00:30:57.000000000 +0100
@@ -1,3 +1,10 @@
+libdevel-declare-perl (0.006017-1+deb8u1) jessie; urgency=high
+
+ * Team upload.
+ * Fix breakage caused by change in perl stable update (Closes: #826563)
+
+ -- Dominic Hargreaves <dom@earth.li> Tue, 07 Jun 2016 00:30:47 +0100
+
libdevel-declare-perl (0.006017-1) unstable; urgency=medium
[ Salvatore Bonaccorso ]
diff -Nru libdevel-declare-perl-0.006017/debian/patches/0001-dont-use-sub_inwhat-RT-102918.patch libdevel-declare-perl-0.006017/debian/patches/0001-dont-use-sub_inwhat-RT-102918.patch
--- libdevel-declare-perl-0.006017/debian/patches/0001-dont-use-sub_inwhat-RT-102918.patch 1970-01-01 01:00:00.000000000 +0100
+++ libdevel-declare-perl-0.006017/debian/patches/0001-dont-use-sub_inwhat-RT-102918.patch 2016-06-07 00:08:52.000000000 +0100
@@ -0,0 +1,25 @@
+From 7fc37409865dab1d5bbd358c57be8ce5c8b00a8b Mon Sep 17 00:00:00 2001
+From: Matthew Horsfall <WolfSage@cpan.org>
+Date: Mon, 23 Mar 2015 15:27:48 -0400
+Subject: [PATCH] dont use sub_inwhat (RT#102918)
+
+---
+ stolen_chunk_of_toke.c | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/stolen_chunk_of_toke.c b/stolen_chunk_of_toke.c
+index c667eaa..b9e5037 100644
+--- a/stolen_chunk_of_toke.c
++++ b/stolen_chunk_of_toke.c
+@@ -342,7 +342,7 @@ S_skipspace(pTHX_ register char *s, int incline)
+ * of the buffer, we're not reading from a source filter, and
+ * we're in normal lexing mode
+ */
+- if (s < PL_bufend || !PL_rsfp || PL_sublex_info.sub_inwhat ||
++ if (s < PL_bufend || !PL_rsfp || PL_lex_inwhat ||
+ PL_lex_state == LEX_FORMLINE)
+ return s;
+
+--
+2.1.4
+
diff -Nru libdevel-declare-perl-0.006017/debian/patches/series libdevel-declare-perl-0.006017/debian/patches/series
--- libdevel-declare-perl-0.006017/debian/patches/series 1970-01-01 01:00:00.000000000 +0100
+++ libdevel-declare-perl-0.006017/debian/patches/series 2016-06-07 00:11:41.000000000 +0100
@@ -0,0 +1 @@
+0001-dont-use-sub_inwhat-RT-102918.patch
Reply to: