[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#823517: jessie-pu: package nbd/1:3.8-4+deb8u3



Package: release.debian.org
Severity: normal
Tags: jessie
User: release.debian.org@packages.debian.org
Usertags: pu

Hi,

There is a forward-compatibility bug in nbd-client <= 3.9, in that it
incorrectly merges two flags fields when sending flags to the kernel.
The result of this bug is that all exports exported by nbd-server >= 3.9
and connected to by nbd-client <= 3.9 are all marked as read-only on the
client side.

I would like to update the package in Jessie to remedy the issue, so
that upon the release of Stretch, clients running Jessie can still talk
to servers running Stretch.

diff -u nbd-3.8/debian/changelog nbd-3.8/debian/changelog
--- nbd-3.8/debian/changelog
+++ nbd-3.8/debian/changelog
@@ -1,3 +1,11 @@
+nbd (1:3.8-4+deb8u3) jessie; urgency=medium
+
+  * nbd-client.c: stop mixing global flags into the flags field that
+    gets sent to the kernel, so that connecting to nbd-server >= 3.9
+    does not cause every export to be (incorrectly) marked as read-only.
+
+ -- Wouter Verhelst <wouter@debian.org>  Thu, 05 May 2016 16:26:48 +0200
+
 nbd (1:3.8-4+deb8u2) jessie; urgency=low
 
   * Cherry-pick two commits from 3.10 to fix authfile parsing.
only in patch2:
unchanged:
--- nbd-3.8.orig/nbd-client.c
+++ nbd-3.8/nbd-client.c
@@ -320,7 +320,7 @@
 	} else {
 		if(read(sock, &tmp, sizeof(tmp)) < 0)
 			err("Failed/4: %m\n");
-		*flags |= (uint32_t)ntohs(tmp);
+		*flags = (uint32_t)ntohs(tmp);
 	}
 
 	if (read(sock, &buf, 124) < 0)

-- System Information:
Debian Release: stretch/sid
  APT prefers unstable-debug
  APT policy: (500, 'unstable-debug'), (500, 'unreleased'), (500, 'unstable'), (500, 'testing'), (500, 'stable'), (500, 'oldstable'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386, m68k, arm64

Kernel: Linux 4.5.0-2-amd64 (SMP w/8 CPU cores)
Locale: LANG=nl_BE.UTF-8, LC_CTYPE=nl_BE.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)


Reply to: