[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#805214: marked as done (jessie-pu: package libhtml-scrubber-perl/0.11-1)

Your message dated Sat, 23 Jan 2016 13:57:15 +0000
with message-id <1453557435.1835.52.camel@adam-barratt.org.uk>
and subject line 8.3 point release cleanup
has caused the Debian Bug report #805214,
regarding jessie-pu: package libhtml-scrubber-perl/0.11-1
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
805214: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=805214
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: release.debian.org
Severity: normal
Tags: jessie
User: release.debian.org@packages.debian.org
Usertags: pu

Please consider the attached debdiff for a stable update.

Changes:
 libhtml-scrubber-perl (0.11-1+deb8u1) jessie; urgency=medium
 .
   * [SECURITY] CVE-2015-5667: Backport upstream patch fixing
     a cross-site scripting vulnerability in comments.
     (Closes: #803943)

-- System Information:
Debian Release: stretch/sid
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: amd64 (x86_64)

Kernel: Linux 4.2.0-1-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=fi_FI.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

diff -Nru libhtml-scrubber-perl-0.11/debian/changelog libhtml-scrubber-perl-0.11/debian/changelog
--- libhtml-scrubber-perl-0.11/debian/changelog	2013-10-22 20:19:05.000000000 +0300
+++ libhtml-scrubber-perl-0.11/debian/changelog	2015-11-15 22:32:52.000000000 +0200
@@ -1,3 +1,11 @@
+libhtml-scrubber-perl (0.11-1+deb8u1) jessie; urgency=medium
+
+  * [SECURITY] CVE-2015-5667: Backport upstream patch fixing
+    a cross-site scripting vulnerability in comments.
+    (Closes: #803943)
+
+ -- Niko Tyni <ntyni@debian.org>  Sun, 15 Nov 2015 21:07:33 +0200
+
 libhtml-scrubber-perl (0.11-1) unstable; urgency=low
 
   * Team upload.
diff -Nru libhtml-scrubber-perl-0.11/debian/patches/0001-Test-and-fix-for-JVN53973084.patch libhtml-scrubber-perl-0.11/debian/patches/0001-Test-and-fix-for-JVN53973084.patch
--- libhtml-scrubber-perl-0.11/debian/patches/0001-Test-and-fix-for-JVN53973084.patch	1970-01-01 02:00:00.000000000 +0200
+++ libhtml-scrubber-perl-0.11/debian/patches/0001-Test-and-fix-for-JVN53973084.patch	2015-11-15 22:32:52.000000000 +0200
@@ -0,0 +1,65 @@
+From 3f871371cf40baf37981bc829036d4a444e20124 Mon Sep 17 00:00:00 2001
+From: Nigel Metheringham <nigelm@cpan.org>
+Date: Sat, 10 Oct 2015 15:01:14 +0100
+Subject: [PATCH] Test and fix for JVN53973084
+
+Malformed tags can pass through as comments.
+Thus comments are now only passed through if
+they are well formed - currently defined as
+matching a regular expression.
+
+Origin: backport, https://github.com/nigelm/html-scrubber/commit/e1978cc37867e85c06a84a4651745235010cd6cd
+Bug-Debian: https://bugs.debian.org/803943
+---
+ lib/HTML/Scrubber.pm |  6 +++++-
+ t/jvn53973084.t      | 21 +++++++++++++++++++++
+ 2 files changed, 26 insertions(+), 1 deletion(-)
+ create mode 100644 t/jvn53973084.t
+
+diff --git a/lib/HTML/Scrubber.pm b/lib/HTML/Scrubber.pm
+index e8ee4ba..e7c1d42 100644
+--- a/lib/HTML/Scrubber.pm
++++ b/lib/HTML/Scrubber.pm
+@@ -284,7 +284,11 @@ sub _scrub_str {
+         }
+     }
+     elsif ( $e eq 'comment' ) {
+-        $outstr .= $text if $s->{_comment};
++        if ( $s->{_comment} ) {
++
++            # only copy comments through if they are well formed...
++            $outstr .= $text if ( $text =~ m|^<!--.*-->$|ms );
++        }
+     }
+     elsif ( $e eq 'process' ) {
+         $outstr .= $text if $s->{_process};
+diff --git a/t/jvn53973084.t b/t/jvn53973084.t
+new file mode 100644
+index 0000000..7767609
+--- /dev/null
++++ b/t/jvn53973084.t
+@@ -0,0 +1,21 @@
++# Tests related to JVN53973084
++
++use strict;
++use warnings;
++use Test::More;
++
++use_ok('HTML::Scrubber');
++
++my @allow = qw[
++    hr
++];
++
++my $html_1 = q[<hr><a href="javascript:alert(1)"<hr>abc];
++my $html_2 = q[<img src="javascript:alert(1)"];
++foreach my $comment_value ( 0, 1 ) {
++    my $scrubber = HTML::Scrubber->new( allow => \@allow, comment => $comment_value );
++    is( $scrubber->scrub($html_1), '<hr>abc', "correct result (1) - with comment => $comment_value" );
++    is( $scrubber->scrub($html_2), '',            "correct result (2) - with comment => $comment_value" );
++}
++
++done_testing;
+-- 
+2.6.2
+
diff -Nru libhtml-scrubber-perl-0.11/debian/patches/series libhtml-scrubber-perl-0.11/debian/patches/series
--- libhtml-scrubber-perl-0.11/debian/patches/series	1970-01-01 02:00:00.000000000 +0200
+++ libhtml-scrubber-perl-0.11/debian/patches/series	2015-11-15 21:11:47.000000000 +0200
@@ -0,0 +1 @@
+0001-Test-and-fix-for-JVN53973084.patch

--- End Message ---
--- Begin Message --- 
Version: 8.3

Hi,

The updates referred to in these bugs were included in today's 8.3
Jessie point release.

Regards,

Adam

--- End Message ---
Reply to: